Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

2025-04-24 Thread ross . philipson
On 4/24/25 5:36 AM, Huang, Kai wrote: + +#ifndef __ASSEMBLY__ [...] +#endif /* !__ASSEMBLY */ A minor thing: There's an attempt to convert __ASSEMBLY__ to __ASSEMBLER__ at tree-wide level: https://urldefense.com/v3/__https://lore.kernel.org/lkml/20250314071013.1575167-1-th...@redhat.co

Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

2025-04-24 Thread Huang, Kai
> + > +#ifndef __ASSEMBLY__ > [...] > +#endif /* !__ASSEMBLY */ > A minor thing: There's an attempt to convert __ASSEMBLY__ to __ASSEMBLER__ at tree-wide level: https://lore.kernel.org/lkml/20250314071013.1575167-1-th...@redhat.com/ I am not sure the final result (there's some discussion ar

Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

2025-04-23 Thread ross . philipson
On 4/23/25 11:23 AM, ALOK TIWARI wrote: On 21-04-2025 21:56, Ross Philipson wrote: +static inline int +slr_add_entry(struct slr_table *table, +  struct slr_entry_hdr *entry) +{ +    struct slr_entry_hdr *end; + +    if ((table->size + entry->size) > table->max_size) +    return -1;

Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

2025-04-23 Thread ALOK TIWARI
On 21-04-2025 21:56, Ross Philipson wrote: +static inline int +slr_add_entry(struct slr_table *table, + struct slr_entry_hdr *entry) +{ + struct slr_entry_hdr *end; + + if ((table->size + entry->size) > table->max_size) + return -1; + + memcpy((u8 *)

Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

2025-04-22 Thread ross . philipson
On 4/21/25 12:18 PM, ALOK TIWARI wrote: On 21-04-2025 21:56, Ross Philipson wrote: The Secure Launch Specification is an architectural agnostic, software neutral API/ABI maintainted by the TrenchBoot project. It's function is to allow any typo maintainted compliant boot loader to communic

Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

2025-04-21 Thread ALOK TIWARI
On 21-04-2025 21:56, Ross Philipson wrote: The Secure Launch Specification is an architectural agnostic, software neutral API/ABI maintainted by the TrenchBoot project. It's function is to allow any typo maintainted compliant boot loader to communicate the pre-launch configuration to any c