Re: [PATCH v5 07/20] x86/kexec: Invoke copy of relocate_kernel() instead of the original

2024-12-14 Thread David Woodhouse
On 14 December 2024 23:08:18 GMT, Nathan Chancellor wrote: >Hi David, > >On Thu, Dec 05, 2024 at 03:05:13PM +, David Woodhouse wrote: >> From: David Woodhouse >> >> This currently calls set_memory_x() from machine_kexec_prepare() just >> like the 32-bit version does. That's actually a bit ea

Re: [PATCH v5 07/20] x86/kexec: Invoke copy of relocate_kernel() instead of the original

2024-12-14 Thread Nathan Chancellor
Hi David, On Thu, Dec 05, 2024 at 03:05:13PM +, David Woodhouse wrote: > From: David Woodhouse > > This currently calls set_memory_x() from machine_kexec_prepare() just > like the 32-bit version does. That's actually a bit earlier than I'd > like, as it leaves the page RWX all the time the i

Re: Lockdep warnings on kexec (virtio_blk, hrtimers)

2024-12-14 Thread David Woodhouse
On Fri, 2024-12-13 at 20:16 +, David Woodhouse wrote: > > > As discussed with Dave over IRC, the current implementation isn't > > actually that bad.  It might use PMSG_THAW instead of PMSG_RESTORE in > > kernel_kexec(), but other than this it reflects the code flow around > > the jump from the