Any updates on this ? do we need fix this problem ?
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2041670
Title:
tmpfs: O_DIRECT | O_CREATE open reports open failure but actually
cre
Yes, sorry, I pasted the text into the report and somehow forgot to put
sudo ./reproducer
I just wanted to clarify that the open with O_DIRECT and O_CREAT failure
should not leave the file around if the open call gets an error return
since this is not consistent with other file systems. Also it's
** Changed in: linux
Status: Confirmed => Unknown
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2041670
Title:
tmpfs: O_DIRECT | O_CREATE open reports open failure but actually
Artem: thanks for the Cc.
Colin: I think you misread the reproducer output for 6.6-rc, that's
precisely the release in which this is (unwittingly) fixed on tmpfs:
not by failing the creat part, but by allowing O_DIRECT open and I/O -
it gives me "open succeeded", "stat succeeded", "unlink succeede
We've been here before with the minix file system:
https://lore.kernel.org/all/20220107133626.413379-1-qhjin@gmail.com/T/#u
in that scenario the file was not created on a file error when doing
O_CREAT | O_DIRECT
--
You received this bug notification because you are a member of Kernel
Packag
(In reply to Colin Ian King from comment #7)
> The file is created but the fd is -1. Surely the semantics of a O_CREAT
> failure are a file that's not created.
Not necessarily. You're requesting a file to be created and to be opened
afterwards with O_DIRECT support and what we do in this case is f
Ah, ok sorry now I see:
brauner@wittgenstein|~/src/git/linux/vfs/vfs.super|vfs.super $%>
> git describe --contains e88e0d366f9cfbb810b0c8509dc5d130d5a53e02
v6.6-vfs.tmpfs~2
which means support for O_DIRECT was merged in v6.6.
--
You received this bug notification because you are a member of Ker
The file is created but the fd is -1. Surely the semantics of a O_CREAT
failure are a file that's not created.
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2041670
Title:
tmpfs: O_DIR
I see, tmpfs has FMODE_CAN_ODIRECT
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2041670
Title:
tmpfs: O_DIRECT | O_CREATE open reports open failure but actually
creates a file.
Sta
I think that's intended. You're creating a file and you're requesting it
to be opened with O_DIRECT but if the underlying filesystem doesn't
support O_DIRECT then you fail the open. So that the file is created is
fine.
--
You received this bug notification because you are a member of Kernel
Packa
Launchpad has imported 5 comments from the remote bug at
https://bugzilla.kernel.org/show_bug.cgi?id=218049.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help
Public bug reported:
creating a file on tmpfs with open(filename, O_RDWR | O_DIRECT |
O_CREAT, 0666) reports an open failure error EINVAL, but still creates
the file. The file should not be created if we hit such an error.
Tested and fails on:
mantic amd64: 6.5.0-10-generic
lunar amd64: 6.2.0-35-
12 matches
Mail list logo
