[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Alberto Villa
On Friday 08 April 2011 13:02:35 Max Brazhnikov wrote: > The last one has been fixed already, so only two — not lots :) oh, good :) anyway textproc/wv2 has been fixed on ixystems' by rakuco only, it has to be handled when we commit this cmake update -- Alberto Villa, FreeBSD committer http://pe

[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Max Brazhnikov
On Fri, 8 Apr 2011 12:39:32 +0200, you wrote: > On Friday 08 April 2011 12:33:39 Max Brazhnikov wrote: > > 'Release' was the default build type before we switched to empty type. I > > think exp-run is overkill for this change. > > lots of plists with *.cmake files will need the same thing we did w

[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Alberto Villa
On Friday 08 April 2011 12:33:39 Max Brazhnikov wrote: > 'Release' was the default build type before we switched to empty type. I > think exp-run is overkill for this change. lots of plists with *.cmake files will need the same thing we did with KDE4_BUILD_TYPE (now CMAKE_BUILD_TYPE, i see), as w

[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Max Brazhnikov
On Fri, 8 Apr 2011 12:16:48 +0200, you wrote: > On Friday 08 April 2011 12:10:06 Max Brazhnikov wrote: > > SVN commit 7127 by makc: > > > > Set CMAKE_BUILD_TYPE to Release by default and to Debug if > > WITH_DEBUG is > > > defined. Pass CMAKE_BUILD_TYPE to PLIST_SUB > > this will hardcode -O3 i

[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Alberto Villa
On Friday 08 April 2011 12:25:14 Dima Panov wrote: > If -O3 will cause instablity, we can simply patch cmake itself to use -O2 > :) i don't have any problem with -O3, -O2 or -Owhatever, but i think that users should still be able to customize their CFLAGS as they like, i.e., if they want -O1, it

[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Dima Panov
Hello! 08.04.2011, 21:16, "Alberto Villa" : > On Friday 08 April 2011 12:10:06 Max Brazhnikov wrote: > >>  SVN commit 7127 by makc: >> >>  Set CMAKE_BUILD_TYPE to Release by default and to Debug if > > WITH_DEBUG is > >>  defined. Pass CMAKE_BUILD_TYPE to PLIST_SUB > > this will hardcode -O3 in CF

[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

2011-04-08 Thread Alberto Villa
On Friday 08 April 2011 12:10:06 Max Brazhnikov wrote: > SVN commit 7127 by makc: > > Set CMAKE_BUILD_TYPE to Release by default and to Debug if WITH_DEBUG is > defined. Pass CMAKE_BUILD_TYPE to PLIST_SUB this will hardcode -O3 in CFLAGS. are we sure we want it? perhaps there is an easy way to