KUserFeedback as framework for KF6

2023-07-15 Thread christoph
Hi, several of our projects use it, like Plasma and Kate. Can we make it a framework for KF6? Then we have finally regular releases that include bug fixes. Is there some opposition to do that? I asked in the past but there was just no reaction. Greetings Christoph

Re: These frameworks need new maintainers

2023-08-01 Thread christoph
this information for all Frameworks. I second that, makes a lot more sense. Greetings Christoph Cheers Nico

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-05 Thread christoph
https://invent.kde.org/utilities/kate/-/blob/master/.gitlab-ci.yml?ref_type=heads and require KF 6 + Qt 6 in the CMake files or is there additional stuff that needs updates to avoids one breaks stuff? Greetings Christoph - The KDE Gear release will move by 2 months to allow for the extra time n

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-09 Thread christoph
eek to chime in. Let's make our Qt 6 based 'bundled' release next year a good one ;) Greetings Christoph Cheers, Albert Greetings Christoph >> - The KDE Gear release will move by 2 months to allow for the extra >> >> time needed for testing initial Qt6

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-10 Thread christoph
ne", "stable": "none", "stable_kf5": "release/23.08", "trunk_kf5": "master"} Would it be something like: {"trunk": "master", "stable": "none", "stable_kf5": "release/23.08", "trunk_kf5": "none"} Greetings Christoph

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-12 Thread christoph
quot;) set(QT_MAJOR_VERSION "6") set(KF_MIN_VERSION "5.240.0") set(KF_MAJOR_VERSION "6") in the first step and start later to remove the version ifs. Greetings Christoph

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread christoph
usable with the daemon inside Plasma more or less, too? Greetings Christoph Without any de-KF-ication though this will break things though for building consumers soonish. Example --- 8< --- find_package(KF6 ${KF_MIN_VERSION} REQUIRED COMPONENTS CoreAddons Plasma ) --

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread christoph
, if we are atm moving stuff, might it make sense to move Baloo, too, given it only is usable with the daemon inside Plasma more or less, too? Greetings Christoph Baloo is linked by some apps, e.g. Elisa, and I wouldn't like to make them haul in Plasma stuff. Hi, some applications li

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread christoph
s use the variant Windows uses. Greetings Christoph Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-11 Thread christoph
est with just one variant. And one would always use the variant Windows uses. Hi, any more feedback about this? Greetings Christoph Greetings Christoph Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-13 Thread christoph
de.org/frameworks/baloo/-/merge_requests tells me that one should just stay away from using it, if we can't get more manpower to fix at least the most prominent cashes. I don't say that people working on it miss skills or passion, just that not enough people work on it to get this f

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-13 Thread christoph
ome' Baloo bugs myself to write some tracker based variant https://invent.kde.org/cullmann/baloo-tbaloo It never took of, but yes, tracker has at least more contributors. Greetings Christoph HS

Re: Transitioning to Qt 6.6 for Windows builds - Syndication build failure

2023-11-20 Thread christoph
eduled the job, it already passed at least the syndication step. Greetings Christoph Thanks, Ben

Re: KDE Frameworks with failing CI (master) (29 January 2024)

2024-02-03 Thread christoph
that LC_ALL and LANGUAGE had been set in our FreeBSD containers. That has now been rectified, and the tests in several more Frameworks now pass. (Leaving just Baloo and KFileMetaData as broken I believe) Hi, could it be that extended attributes don't work? I think these tests rely on them. Greetings Christoph

Re: KDE Frameworks with failing CI (kf5) (4 February 2024)

2024-02-04 Thread christoph
On 2024-02-04 13:34, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good news: 9 repositories were fixed Bad news: 2 repositories are still failing, 1 rep

Re: KDE Frameworks with failing CI (master) (4 February 2024)

2024-02-05 Thread christoph
. kfilemetadata - 2nd week * https://invent.kde.org/frameworks/kfilemetadata/-/pipelines/598257 * FreeBSD tests are failing This one has been debugged by Christoph and there is a pending MR to fix this. See https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/126 Caused by differences in the

Re: KDE Frameworks with failing CI (kf5) (11 February 2024)

2024-02-11 Thread christoph
in KF6? Christoph? Yes, it should be backported, otherwise the metadata features are broken on FreeBSD 14+ for users. I can take a look in the next days. Greetings Christoph Cheers, Albert Cheers, Ben

Re: KDE Frameworks with failing CI (kf5) (11 February 2024)

2024-02-13 Thread christoph
* Tests fail on FreeBSD * Should we backport the fix made in KF6? Christoph? Yes, it should be backported, otherwise the metadata features are broken on FreeBSD 14+ for users. I can take a look in the next days. https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/127 Greetings

Re: Fwd: KDE Frameworks 6.0.0 tars

2024-02-21 Thread christoph
Christoph

Re: Fwd: KDE Frameworks 6.0.0 tars

2024-02-21 Thread christoph
some small things we would add tomorrow. Just added the stuff now, current master branch state is ok. Greetings Christoph

Re: KDE Frameworks 6.0.0 tars

2024-02-22 Thread christoph
42 http://embra.edinburghlinux.co.uk/~jr/tmp/ktexteditor-6.0.0-changes_report.html Thanks, that looks correct. Greetings Christoph On Wed, 21 Feb 2024 at 11:44, Jonathan Riddell wrote: Tars for KDE Frameworks 6.0.0 are now available for packagers, release due next Wednesday http://embra.edinburghlin

Re: KDE Frameworks 6.0.0 tars

2024-02-26 Thread christoph
ks/baloo/-/merge_requests/188 Greetings Christoph

Re: KDE Frameworks 6.0.0 tars

2024-02-27 Thread christoph
! Greetings Christoph

Re: Frameworks 6.0.0 is out!

2024-02-28 Thread christoph
et me know if I should. Hi, big thanks to all people that helped to get this done! Greetings Christoph Jonathan

Re: KDE Frameworks with failing CI (kf5) (3 March 2024)

2024-03-04 Thread christoph
On 2024-03-04 00:03, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good news: 1 repository was fixed Bad news: 1 NEW repository is failing syntax-highli

Re: KDE Frameworks with failing CI (kf5) (3 March 2024)

2024-03-05 Thread christoph
-highlighting/-/commit/680c90ba438b7df3447222058a541424c9c91dbd for kf5. Should be fixed again. And thanks for the notice, would not have seen that. Greetings Christoph Cheers, Albert

Re: KatePart causes Konqueror to crash when using the :q! Vi command

2024-03-24 Thread christoph
//invent.kde.org/frameworks/ktexteditor/-/commit/e9ea498d0e9f938510ae35612266097587a03746 Greetings Christoph Thanks in advance Stefano [1] https://bugs.kde.org/show_bug.cgi?id=482436

Re: LibKF6Breeze Icons and KIconLoader

2024-05-23 Thread christoph
e doesn't revert but uses the master state) Greetings Christoph Jonathan

Re: LibKF6Breeze Icons and KIconLoader

2024-05-23 Thread christoph
=2770&straight=false Did you turn on KICONTHEMES_REGISTER_ICON_PLUGIN via CMake? If not my commit can be ignored. Than it is rather just the BreezeIcons::initIcons(); but that is strange, that only should load the resource and set the fallback theme. Greetings Christoph Jonathan

Re: LibKF6Breeze Icons and KIconLoader

2024-05-23 Thread christoph
like an rcc or toolchain bug though (and qrc_breeze-iconstmp.cpp.o looks ok), so it may not be related to the problem you're seeing. That is an issue with qt_add_bigresource. That doesn't like lto. Greetings Christoph ttyl bero

Re: LibKF6Breeze Icons and KIconLoader

2024-05-24 Thread christoph
ource adding and live with the bit longer compile time, I have no problem with changing that. Greetings Christoph Cheers, Fabian ttyl bero

Re: LibKF6Breeze Icons and KIconLoader

2024-05-27 Thread christoph
On 2024-05-27 16:00, Jonathan Riddell wrote: I neon me and David R tracked it down to some optimization probably with the dh_dwz tool from Debian packaging tools, this is the "DWARF optimization and duplicate removal tool" part of the toolchain. And with the discussion here Chr

Re: KDE Frameworks with failing CI (master) (9 February 2025)

2025-02-10 Thread christoph
https://bugs.kde.org/show_bug.cgi?id=499674 Which says the qrc is 110MB and cannot be compiled anymore on 32bit. I wonder if something similar is happening on Windows. Qt 6.9 will de-dupe the file, that should make it a lot smaller. Greetings Christoph David Am Sonntag, 9. Februar 2025,

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-29 Thread Christoph Cullmann
> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

2015-11-29 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126039/#review88923 --- Ok for me, if that allows better error handling. - Christoph

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

2015-12-04 Thread Christoph Feck
appearance of frames and positioning text inside those frames. I guess what you are after is a modified OS X plugin for QPlatformTheme. - Christoph Feck On Dec. 4, 2015, 12:27 p.m., René J.V. Bertin wrote: > > --- > This is an automat

Re: Review Request 126231: Fix a small artifact of kratingwidget on hidpi

2015-12-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126231/#review89145 --- Ship it! Ship It! - Christoph Feck On Dec. 3, 2015, 8:37

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-27 Thread Christoph Cullmann
e full path). Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Christoph Cullmann
. File Attachments (updated) trash.json https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Christoph Cullmann
> On Dec. 28, 2015, 5:20 p.m., Alex Richardson wrote: > > Could you post a patch with the JSON files? I'll look into implementing the > > translations then. Hi, atm my local build is broken, so no new patch, but I have attached the converted trash.protocol r

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-01 Thread Christoph Cullmann
FileOpenEvent just like a dbus request to open a new file (atm I guess only the variant that has some url is feasible, the other variant won't work with the current interfaces to the editor part we have). Same for e.g. KWrite, just open a new windows with the file, like file open.

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2016-01-01 Thread Christoph Cullmann
> On Jan. 1, 2016, 6:12 p.m., Alex Richardson wrote: > > I added support for translating the ExtraNames key here: > > https://svn.reviewboard.kde.org/r/7154/ Cool ;=) Which nice new year present! Thanks! - Christoph ---

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-01 Thread Christoph Cullmann
Hi, > On Friday January 01 2016 17:47:17 Christoph Cullmann wrote: > > Hi, > > Apparently you already looked into this? > >> I can tell you that this needs to be done at the application level, not at >> kpart >> level. > > Can you explain w

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2016-01-01 Thread Christoph Cullmann
pport for translations, like was done for other json files (talk to e.g. > > Luigi Toscano). > > Christoph Cullmann wrote: > Hmm, then we have a problem: We can no longer convert the stuff and > remove the .protocol files, or? > > Christoph Cullmann wrote: > Ok, did r

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-02 Thread Christoph Cullmann
> the KApplication class, do I need to rebuild all dependents to avoid > ABI-related crashing, or only those that are modified to connect to the new > signal? > (IOW, can you add a signal to a class without breaking backwards > compatibility?) Signal adding should be binary comp

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-02 Thread Christoph Cullmann
Hi, > On Saturday January 02 2016 19:56:28 Christoph Cullmann wrote: > > Hi, > > >> I have added this now just to KateApp. >> >> https://quickgit.kde.org/?p=kate.git&a=commit&h=cd6ec201725cf627a336015d472c39f5ff73b2a7 > > Hmm, thanks for the

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-02 Thread Christoph Cullmann
Hi, > On Saturday January 02 2016 20:24:25 Christoph Cullmann wrote: > >> Besides: No need for ifdefs, QFileOpenEvent is there on all platforms, just >> without function. > > True, but there's no point in installing an event filter for it on platforms > where th

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-03 Thread Christoph Cullmann
on Linux. Only minor issue is that the error > > message is a little bit confusing now. hi, same problem occurs on mac, too, i think a better fallback would be something install prefix relative, that would work on win + mac. - Christoph -

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-03 Thread Christoph Cullmann
ory are the desktop files? Unfortunately I can't check as my > > Windows machine broke a while back and I haven't compiled KF5 on Windows > > since. > > > > Patch looks good to me otherwise as it will still check the same > > directories change behaviour

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

2016-01-03 Thread Christoph Cullmann
amp;& make test still OK. File Attachments trash.json https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-04 Thread Christoph Cullmann
ory are the desktop files? Unfortunately I can't check as my > > Windows machine broke a while back and I haven't compiled KF5 on Windows > > since. > > > > Patch looks good to me otherwise as it will still check the same > > directories change behaviour

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-05 Thread Christoph Cullmann
-to-make-my-app-open-a-doc-by-dd-or-doubleclick-on-a-mac.html Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Christoph Cullmann
lehandle)) to have not fclose(f) close the handle, too, and not only the FILE *? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126410/#review90801

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Christoph Cullmann
it was > > exactly. > > Martin Klapetek wrote: > This is the change that breaks kwallet: > > ```diff > +fclose(s3); > + > ``` > > I'm not entirely sure (yet) why though. > > Christoph Cullmann wrote: > Hi, do

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-08 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/#review90807 --- Ship it! Ship It! - Christoph Cullmann On Jan. 8, 2016, 8

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

2016-01-10 Thread Christoph Cullmann
pport for translations, like was done for other json files (talk to e.g. > > Luigi Toscano). > > Christoph Cullmann wrote: > Hmm, then we have a problem: We can no longer convert the stuff and > remove the .protocol files, or? > > Christoph Cullmann wrote: > Ok, did r

Re: Reporting bugs to frameworks

2016-01-15 Thread Christoph Feck
On Friday 15 January 2016 12:55:47 Aleix Pol wrote: > Hi, > I've recently found a bug in kded. I've been trying to report it > but didn't manage to find it on the list [1]. > > What did I miss? frameworks-kdaemon ___ Kde-frameworks-devel mailing list Kd

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

2016-01-17 Thread Christoph Cullmann
pport for translations, like was done for other json files (talk to e.g. > > Luigi Toscano). > > Christoph Cullmann wrote: > Hmm, then we have a problem: We can no longer convert the stuff and > remove the .protocol files, or? > > Christoph Cullmann wrote: > Ok, did r

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-30 Thread Christoph Cullmann
ory are the desktop files? Unfortunately I can't check as my > > Windows machine broke a while back and I haven't compiled KF5 on Windows > > since. > > > > Patch looks good to me otherwise as it will still check the same > > directories change behaviour

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

2016-01-30 Thread Christoph Cullmann
marked as submitted. Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano. Changes --- Submitted with commit f8ae6c3127392de2f01fb3c767b90208cd3129a0 by Christoph Cullmann to branch master. Repository: kio Description --- Allows

Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

2016-01-31 Thread Christoph Cullmann
81cc036 src/ioslaves/trash/trash.json PRE-CREATION src/ioslaves/trash/trash.protocol 7430575 Diff: https://git.reviewboard.kde.org/r/126940/diff/ Testing --- Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

2016-01-31 Thread Christoph Cullmann
trash.json, compared to my first try in https://git.reviewboard.kde.org/r/125869/ Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 179 - Still Unstable!

2016-02-03 Thread Christoph Cullmann
Hi, please take a look Sven, guess was your commit that triggers this. Greetings Christoph - Am 3. Feb 2016 um 18:35 schrieb no-re...@kde.org: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,c

Re: Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 179 - Still Unstable!

2016-02-03 Thread Christoph Cullmann
:=) Btw., public apologize, it was my own commit days ago :=) Thanks Sven for fixing my issues. Greetings Christoph - Am 3. Feb 2016 um 18:42 schrieb cullmann cullm...@absint.com: > Hi, > > please take a look Sven, guess was your commit that triggers this. > > Greeti

Re: Review Request 127232: Make breeze the default icon theme name for KIconThemes

2016-02-29 Thread Christoph Feck
- Christoph Feck On March 1, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

2016-03-06 Thread Christoph Cullmann
marked as submitted. Review request for KDE Frameworks, Alex Richardson and David Faure. Changes --- Submitted with commit a3fee508c6c42b1b86155719e38a84b1128360eb by Christoph Cullmann to branch master. Repository: kio Description --- Move .protocol files of all io slaves bundled

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 259 - Still Unstable!

2016-03-08 Thread Christoph Cullmann
Hi, perhaps I am confused, but this looks strange to me. The TestSuite.kiocore-threadtest fails randomly (it worked in the previous build with the patch inside) and the favicons tests worked with my first try of this patch... Any ideas? Greetings Christoph - Am 8. Mrz 2016 um 11:51

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

2016-03-10 Thread Christoph Feck
he xprop and xwinfo output > for the three windows to the bug report: > https://bugs.kde.org/show_bug.cgi?id=355310#c8 > > It would be great if you could take a look. Martin, does the xinfo attached to the above bug report help to identify the issue? (point Thomas h

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

2016-03-12 Thread Christoph Feck
? Unless it is, I suggest to not work around the Qt bug, because the release of Qt 5.6 is imminent and this fix does not reach our users earlier. - Christoph Feck On March 12, 2016, 2:53 p.m., Anthony Fieroni wrote: > > --- > T

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

2016-03-19 Thread Christoph Feck
. - Christoph Feck On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Delaying KF 5.21

2016-04-03 Thread Christoph Cullmann
Hi, Yeah, this must be fixed. I will take a look myself this afternoon if nobody feels guilty for the changes.. :=/ I already ponged the list some days ago, given I didn't submit any changes in the last time... Greetings Christoph - Am 3. Apr 2016 um 12:03 schrieb bcooksley b

Re: Delaying KF 5.21

2016-04-03 Thread Christoph Cullmann
Hi, > Christoph Cullmann ha scritto: >> Hi, >> >> Yeah, this must be fixed. >> >> I will take a look myself this afternoon if nobody feels guilty for the >> changes.. >> >> :=/ I already ponged the list some days ago, given I didn't su

Re: Delaying KF 5.21

2016-04-03 Thread Christoph Cullmann
Hi, working to get the tests back OK on CI. But I can confirm that in any of the tries I made they always work locally :/ Guess still some stuff globally different there that the different test modes not catch. Greetings Christoph - Am 3. Apr 2016 um 14:09 schrieb cullmann cullm

Re: Delaying KF 5.21

2016-04-03 Thread Christoph Cullmann
Hi, > Hi, > >> Christoph Cullmann ha scritto: >>> Hi, >>> >>> Yeah, this must be fixed. >>> >>> I will take a look myself this afternoon if nobody feels guilty for the >>> changes.. >>> >>> :=/ I already p

Encoding Issues?

2016-04-03 Thread Christoph Cullmann
Hi, the two failed ktexteditor tests seems to be encoding issues. KTextEditor lib no longer is able to detect UTF-8 for some files. Did the locale change to something non-UTF-8 on the CI? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt

Re: Delaying KF 5.21

2016-04-03 Thread Christoph Cullmann
Fixed. IMHO some encoding issue, not sure why, thought :/ Locally they all always worked. But, yes, we need to keep an better eye on the tests, even if not broken by commits to the repo. Greetings Christoph - Am 3. Apr 2016 um 14:09 schrieb cullmann cullm...@absint.com: > Hi, >

Re: Encoding Issues?

2016-04-03 Thread Christoph Cullmann
efore: no need to hurry at all! Enjoy a nice birthday party! And: THANKS for your work on the CI! Greetings Christoph > > On Sun, Apr 3, 2016 at 9:58 AM, Christoph Cullmann > wrote: > >> Hi, >> >> the two failed ktexteditor tests seems to be encoding issues. >>

Re: Encoding Issues?

2016-04-04 Thread Christoph Cullmann
Hi, > On Mon, Apr 4, 2016 at 6:45 AM, Christoph Cullmann > wrote: >> Hi, >> >>> This is likely something I can fix, but I am heading off to my grandsons >>> first birthday, will have to be later. >>> Thanks for understanding. >>> Scarlett

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

2016-05-07 Thread Christoph Feck
:130:9: error: 'translation_found' was not declared in this scope ki18n/src/gettext.h:180:9: error: 'translation_found' was not declared in this scope - Christoph Feck On May 7, 2016, 4:12 a.m., Michael Pyne wrote: > > --

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Christoph Feck
worth it. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: HAVE_X11 usage in KIO/core

2014-02-08 Thread Christoph Feck
ke Gecko) > > to > > Mozilla/5.0 (compatible; Konqueror/4.0; Linux; i686; en_US) > KHTML/4.0.1 (like Gecko) > > will anyone ever care? Had to check if there is a standard that mandates the order or presence of fields, but there is not. +1 for omitting the window system

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Christoph Feck
iding a student requires someone with more in depth > knowledge then i have. (looking at David Faure ^_-) Please only add projects where a mentor is willing to take part of GSoC. Looking at persons that are swamped with other work is nice, but that won't help the potential student who

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Christoph Feck
break when we switch to Wayland? If there are sites out there that need to see the "X11" string, we should simply lie, and always send it for Linux. We aren't a Mozilla browser either... - Christoph --- This is an automa

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
stores the items directly in the pointer array." - Christoph Feck On Feb. 13, 2014, 8:23 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
> On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: > > Making the type movable does not make QList store it directly, how did you > > check this? > > > > http://qt-project.org/doc/qt-5/qlist.html says: > > > > "Internally, QList is represented as

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49758 --- Ship it! Ship It! - Christoph Feck On Feb. 13, 2014, 11

Re: Review Request 115686: Fix mimetype declarations in json files

2014-02-15 Thread Christoph Feck
humbnails folder since 1994, so removing support for this format should not do any harm. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115686/#review49844 --

Re: X11 usage in kdeinit/kinit.cpp

2014-02-17 Thread Christoph Cullmann
DISPLAY is defined, use wayland, else use X11" work? Or would it make any sense to have that defined (in a normal user desktop) but still use X11 as default? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH

Re: KPassivePopup should be in kwidgets ?

2014-02-18 Thread Christoph Feck
27;t really notification specific. > > Shouldn't it rather be in kwidgets? KWidgetsAddons? I quickly looked at KPassivePopup. Unfortunately, it has some X11 specific code, which needs to be ported and/or fixed. Otherwise, I agree that it could be moved. > /Sune > - hopin

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

2014-02-19 Thread Christoph Feck
sense to use an inline method? - Christoph Feck On Feb. 17, 2014, 10:02 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Christoph Feck
> QCoreApplication > in ki18n so far, e.g. the above example works with KJS. > > Also, what happens if one wants to place an i18n call before creating > Q*Application? We had such cases, and had to work around them in few ways. > > > Chusslove Illich w

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-02-24 Thread Christoph Feck
s.cpp <https://git.reviewboard.kde.org/r/115982/#comment35628> Could you rename those variables? "if (!path2.isEmpty() && !image.save(path2))" is a bit clearer :) src/tools/ksvg2icns/ksvg2icns.cpp <https://git.reviewboard.kde.org/r/115982/#comment35629> Use curly braces, ev

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-03-02 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/#review51721 --- Ship it! Ship It! - Christoph Feck On March 2, 2014, 7:13

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-03 Thread Christoph Feck
load-time. For those operations, an exception could be made, because blending could even be hardware-accelerated. - Christoph Feck On March 3, 2014, 1:04 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-04 Thread Christoph Feck
mark it as such. If not, please add some documentation. - Christoph Feck On March 4, 2014, 11:05 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

2014-03-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52048 --- Ship it! Thanks, this supersedes 116603. - Christoph Feck

Re: KSpeech

2014-03-06 Thread Christoph Feck
nice if we had API supporting web speech. Regarding voice selection, it would be very useful to allow the application to specify female/male/child voice via API (in addition to the ability to let the user reconfigure actual voices). Similar to letting the application request Sans, Sans Serif,

Re: Review Request 116729: Add a comment explaining the "kde4" in the mime type

2014-03-11 Thread Christoph Feck
and "kde4" names (if that's even possible)? - Christoph Feck On March 11, 2014, 5 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: KF5 alpha2

2014-03-17 Thread Christoph Cullmann
> On Wednesday 12 March 2014 12:21:36 Christoph Cullmann wrote: > > David Faure wrote: > > > On Wednesday 05 March 2014 19:29:34 Michael Palimaka wrote: > > > > Hi, > > > > > > > > KTextEditor is listed as tier 3, but is missing from this (a

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread Christoph Cullmann
long time); > * kjs (because of khtml I gather); > * kjsembed (ditto); > * krunner (because of upcoming sprinter, and only one user anyway); > * kmediaplayer (unused AFAIK). > > I think that list makes sense. Is there anyone who couldn't sleep at night if > those

  1   2   3   4   5   6   7   8   9   10   >