Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

l.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f Diff: https://git.reviewboard.kde.org/r/126789/diff/ Testing --- Tested in GammaRay, where the layoutChanges are particularly painful as the source model is in a different process. Thanks, Volker Krause __

Re: Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

ding the tests. - Volker --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126789/#review91306 --- On Jan. 18, 2016, 9:59

Re: Improving performance under breeze icons

Thanks for looking into this Aleix! On Wednesday 27 April 2016 02:26:06 Aleix Pol wrote: > Hi, > As assessed lately, one penalty we have when starting an application > is the icons look-up. It's not really Breeze's fault, the intersection > of the standard we're using and how we're using it makes

Re: New test with C++11 and lambda (UDSEntry testcase)

On Saturday 21 September 2013 19:18:01 Mark wrote: > I've just created a quite complicated testcase for frameworks which uses > the new signal/slot connection syntax (since Qt 5.0) and uses a lambda as > slot. The reason i did this is so that i can keep then entire testcase > (minus the initializat

Review Request 113258: Fix compilation with C++11 enabled.

376075541c74f56ceeeb3b640cd9b791b04d32ad Diff: http://git.reviewboard.kde.org/r/113258/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113258: Fix compilation with C++11 enabled.

e0f2c74f4b935994e5d3422d8abdfa1bd955d418 tier4/kcmutils/src/ksettings/dialog.cpp 376075541c74f56ceeeb3b640cd9b791b04d32ad Diff: http://git.reviewboard.kde.org/r/113258/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list

Review Request 113373: Enable C++11 support by default.

integrated into the frameworks branch by now (at least for the subset I have the required dependencies for). Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 113373: Enable C++11 support by default.

ply, visit: http://git.reviewboard.kde.org/r/113373/#review42130 ------- On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 113373: Enable C++11 support by default.

://git.reviewboard.kde.org/r/113373/diff/ Testing --- Compiles, all required fixes have been integrated into the frameworks branch by now (at least for the subset I have the required dependencies for). Thanks, Volker Krause ___ Kde-frameworks-devel

Re: Review Request 113583: Fix build after enabling C++11 standard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113583/#review42872 --- Ship it! Ship It! - Volker Krause On Nov. 2, 2013, 7:38

Re: Removing WinCE support

On Wednesday 09 May 2012 16:47:17 Stephen Kelly wrote: > Alexander Neundorf wrote: > > Hi, > > > > KDAB made kdelibs in some way work with Win CE. > > > > Now Win CE is a very different OS, and IMO we should not even strive to > > port KDE to such OSs (limitations in address space per process, st

Re: Reduce relocations issues on ARM

On Tuesday 11 September 2012 08:12:52 Laszlo Papp wrote: > Hi, > > Trying to build the kde-frameworks branch on ARM, but I am facing the issue > below. I had the impression the reduce_relocations changes in Qt5 is > managed by cmake from the version 2.8.9 which I have been using in this > environm

Re: Reduce relocations issues on ARM

On Thursday 13 September 2012 11:50:05 David Faure wrote: > On Thursday 13 September 2012 11:20:11 Volker Krause wrote: > > On Tuesday 11 September 2012 08:12:52 Laszlo Papp wrote: > > > Hi, > > > > > > Trying to build the kde-frameworks branch on ARM, but I a

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

On Saturday 29 December 2012 11:44:20 David Faure wrote: > On Friday 28 December 2012 02:50:53 Mark wrote: > > Another thing is the "UDS_EXTRA" and "UDS_EXTRA_END". I > > seriously doubt that the functionality is even used anywhere. > > Yes, this got lost with the move from the old konq views to d

Re: FYI: Updates in ThreadWeaver

On Wednesday 03 April 2013 10:09:56 Mirko Boehm wrote: > On 04/02/2013 05:05 PM, Sebastian Kügler wrote: > >> - - Examples are currently in the kdelibs tree, at > >> > >> > tier1/threadweaver/examples. I like that they are in the same > >> > repository, but still - is this the right place? > > >

Notes on C++11 usage from KF5 BoF

Hi, here are my notes on what C++11 features might be usable unconditionally for KF5. regards, Volker C++11 Support in KF5 Minimum compiler requirement: MSVC 2010, GCC 4.5 Possible C++11 features based on http://wiki.apache.org/stdcxx/C++0xCompilerSupport: - auto - dec

Review Request 120184: Remove dead code.

--- Remove dead code. Diffs - src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 Diff: https://git.reviewboard.kde.org/r/120184/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 120186: Make the encoding prober data tables const.

, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120186: Make the encoding prober data tables const.

.bss optimizations. - Volker --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/#review66415 --- On Sept. 13, 2014,

Re: Review Request 120186: Make the encoding prober data tables const.

322d2e6e7e4dd5d049c0212da823b12cbbc48b91 Diff: https://git.reviewboard.kde.org/r/120186/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120187: Make data tables static const.

Description --- Moves 704 bytes from .data to .rodata, ie. from per-process to shared memory. Diffs - src/kcolorscheme.cpp 666418a173b688d52c10cd0d97a6221aea078b98 Diff: https://git.reviewboard.kde.org/r/120187/diff/ Testing --- Thanks, Volker Krause

Re: Review Request 120187: Make data tables static const.

://git.reviewboard.kde.org/r/120187/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120200: Only create one instance of defaultExecutor.

://git.reviewboard.kde.org/r/120200/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120200: Only create one instance of defaultExecutor.

937e9d40d72ea88094a412943a1291fa1c290f0e src/job_p.cpp 4bfc7d6db278a223774f4fd849468868b2eafa6c Diff: https://git.reviewboard.kde.org/r/120200/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 120184: Remove dead code.

marked as submitted. Review request for KDE Frameworks. Repository: karchive Description --- Remove dead code. Diffs - src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 Diff: https://git.reviewboard.kde.org/r/120184/diff/ Testing --- Thanks, Volker Krause

Review Request 122109: Cache QMetaMethods that are invoked on hot paths.

://git.reviewboard.kde.org/r/122109/diff/ Testing --- Tested and measured with the KRFPM usage in GammaRay, saves about 5% of total application CPU cost according to callgrind. Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 122109: Cache QMetaMethods that are invoked on hot paths.

ense, I'll add that. Thanks! - Volker --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122109/#review74187 --- On Jan. 17, 201

Re: Review Request 122109: Cache QMetaMethods that are invoked on hot paths.

- src/krecursivefilterproxymodel.cpp 241f2e8e7e610c397bebc6608a64e4f12e570aea Diff: https://git.reviewboard.kde.org/r/122109/diff/ Testing --- Tested and measured with the KRFPM usage in GammaRay, saves about 5% of total application CPU cost according to callgrind. Thanks, Volker

Review Request 122487: Reorder member variables to reduce memory usage.

// member offset: 40, size: 8, alignment: 8 }; // size: 48, alignment: 8 ``` Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122487: Reorder member variables to reduce memory usage.

// member offset: 32, size: 1, alignment: 1 // 7 byte(s) padding QPluginLoader* loader; // member offset: 40, size: 8, alignment: 8 }; // size: 48, alignment: 8 ``` Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

Re: Review Request 122487: Reorder member variables to reduce memory usage.

tomatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487/#review75629 --- On Feb. 9, 2015, 5:04 p.m., Volker Krause wrote: > > --- > This is an

Re: Review Request 122487: Reorder member variables to reduce memory usage.

On Wednesday 11 February 2015 13:52:36 Thiago Jung Bauermann wrote: > Volker Krause wrote: > >> On Feb. 8, 2015, 8:45 p.m., David Faure wrote: > >> > Which magic tool did you come up with this time, to detect such things? > >> > > >> > :-) > >

Re: Review Request 122487: Reorder member variables to reduce memory usage.

I think. - Volker --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487/#review79066 --- On Feb. 9, 2015, 5:04 p.m.,

Review Request 123390: Reorder member variables to reduce memory usage.

, alignment: 4 // 4 byte(s) padding }; // size: 72, alignment: 8 Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123390: Reorder member variables to reduce memory usage.

timizer to handle bitfield packing. - Volker --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390/#review79078 ------- On

Re: Review Request 123390: Reorder member variables to reduce memory usage.

> On April 16, 2015, 8:43 p.m., Laurent Montel wrote: > > Hi volker > > What did you use as program to detect it ? > > Thanks for info. > > Volker Krause wrote: > The tool is called "elf-packcheck", part of > kde:scratch/vkrause/elf-dissector,

Re: Review Request 123390: Reorder member variables to reduce memory usage.

marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 70e730bf57a5a47e635f8ed118ce04470649bb94 by Volker Krause to branch master. Repository: kwidgetsaddons Description --- Saves 8 byte in all cases, on 64bit systems. Diffs

Accidentally exported private classes

Hi, it turns out KF5 (and PIM, which is where I started looking into this) have quite some unintentionally exported private symbols (2000+ for PIM and the KF5 subset used by it, I'd not entirely trust the tool yet though ;) ). This is mainly caused by using nested private classes, those inherit

Re: Accidentally exported private classes

On Monday 10 August 2015 13:06:29 David Faure wrote: > On Monday 10 August 2015 11:47:43 Volker Krause wrote: > > Hi, > > > > it turns out KF5 (and PIM, which is where I started looking into this) > > have > > quite some unintentionally exported private symbo

Re: Accidentally exported private classes

On Monday 10 August 2015 14:38:34 David Faure wrote: > On Monday 10 August 2015 13:23:05 Volker Krause wrote: > > Yep, and there are more reasons for not using nested classes for this and > > following the Qt scheme instead, such as the Q_D/Q_Q macros for example. > > Right

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

-- > > (Updated Aug. 19, 2015, 7:25 a.m.) > > > Review request for KDE Frameworks, Christoph Feck and Volker Krause. > > > Repository: kiconthemes > > > Description > --- > > This makes QIcon::fromTheme() much faster, for all cases where

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

ed it seems. - Volker Krause On Aug. 19, 2015, 7:25 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

:fromTheme() usage here, hits the disk as before. - Volker Krause On Aug. 20, 2015, 8:07 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

> On Aug. 20, 2015, 4:54 p.m., Volker Krause wrote: > > Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() usage here, > > hits the disk as before. IIUC insertion into the persistent cache only happens when actually rendering the icon, right? I am trying to

Re: QIcon::fromTheme(xxx, someFallback)

On Friday 21 August 2015 10:53:29 Olivier Goffart wrote: > On Friday 21. August 2015 10:05:09 David Faure wrote: > > Hi Olivier, > > > > I've been trying to fix performance problems with QIcon::fromTheme("foo") > > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more > > prec

Re: Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux, gcc - Build # 65 - Unstable!

On Friday 21 August 2015 22:34:21 David Faure wrote: > On Friday 21 August 2015 08:46:28 no-re...@kde.org wrote: > > TestSuite.kiofilewidgets-kfileplacesmodeltest > > Nooo :-( > > The QSet ordering problem is still there, even with > qputenv("QT_HASH_SEED", 0); Does "0" instead of 0

Review Request 124878: Cache a KEmoticons instance here, not a KEmoticonsTheme.

more than 15% of the instructions spend in KConfig parsing code. Diffs - src/integrationplugin/ktexttohtml.cpp 604c18eed06ed76b13aa644fa762a1de6d2f3961 Diff: https://git.reviewboard.kde.org/r/124878/diff/ Testing --- Callgrind + KMail. Thanks, Volker K

Re: Review Request 124879: Optimization readEntryGui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84187 --- Looks good to me. - Volker Krause On Aug. 22, 2015, 3:06

Review Request 124887: Also propagate window titles for folder-only file dialogs.

ialog shows the correct caption now. Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124887: Also propagate window titles for folder-only file dialogs.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit df89f647f19ad61d9075a9057adb5dc0d73dc187 by Volker Krause to branch master. Repository: frameworkintegration Description --- Also propagate window titles for folder-only file dialogs. Diffs

Re: Paths to internal executables (c.f. libexec) hard-coded

On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote: > Heya, > > This is problem on Windows because the *final* installation location is not > known at compile-time (obviously software is installed via installers, users > can pick up the installation prefix). Of course this also limits the > rel

Re: Review Request 124878: Cache a KEmoticons instance here, not a KEmoticonsTheme.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 977afe65ac657f19795effae24059ac298cfe16a by Volker Krause to branch master. Repository: kemoticons Description --- This already contains a cache for the theme, and it is expensive to create

Re: Paths to internal executables (c.f. libexec) hard-coded

On Thursday 27 August 2015 00:14:50 Kevin Funk wrote: > On Wednesday 26 August 2015 13:40:20 Volker Krause wrote: > > On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote: > > > Heya, > > > > > > This is problem on Windows because the *final* installation

Re: QIcon::fromTheme(xxx, someFallback)

On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > On Tuesday 8. September 2015 10:26:20 David Faure wrote: > > On Monday 07 September 2015 15:53:31 Olivier Goffart wrote: > > > But the problem is that QIcon::isNull is likely to be called anyway. > > > And this will again do all the l

Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

runtime warnings in GammaRay, which makes use of resetting the source model. Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9f8b448cf45d71bb28ec4b9dd9300282a2b07d55 by Volker Krause to branch master. Repository: kitemmodels Description --- We need to disconnect from a previous source model if present, not the new

Re: Caveat about QFileDialog

On Wednesday 16 November 2011 18:39:57 Kevin Kofler wrote: > Hi, > > In this recent discussion: > http://mail.kde.org/pipermail/kde-frameworks-devel/2011-November/26.html > it was decided to use QFileDialog instead of KFileDialog, because: > > QFileDialog now uses the platform dialog, includin

Re: Caveat about QFileDialog

On Thursday 17 November 2011 16:07:19 Kevin Ottens wrote: > On Thursday 17 November 2011 15:42:48 Volker Krause wrote: > > On Wednesday 16 November 2011 18:39:57 Kevin Kofler wrote: > > > But the problem is: At least in Qt 4.8 (I haven't checked Qt 5 yet > > > be

Re: KHolidays as Framework (redux)

On Friday 01 January 2016 18:24:17 David Faure wrote: > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > Hi, > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > > for inclusion as a Framework. As far as I am aware there are no > > outstanding > > porting i

Review Request/New Framework: KF5::SyntaxHighlighting

Hi, please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for becoming a framework :) This is a tier1/functional version of the Kate syntax highlighting engine. It's not tied to a particular output format or editor engine, the interface is basically just passing in a line of text

Re: Review Request/New Framework: KF5::SyntaxHighlighting

On Sunday 11 September 2016 05:33:29 Michael Palimaka wrote: > On 11/09/16 01:47, Volker Krause wrote: > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > > becoming a framework :) > > Thanks a lot for working on this

Re: Review Request 128980: Use QTEST_GUILESS_MAIN

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128980/#review99384 --- Ship it! Ship It! - Volker Krause On Sept. 21, 2016, 3

Re: Review Request/New Framework: KF5::SyntaxHighlighting

Thanks! On Friday 30 September 2016 10:08:27 David Faure wrote: > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: > > Hi, > > > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > > becoming a framework :) > > Looks good. I

Re: Review Request/New Framework: KF5::SyntaxHighlighting

On Saturday 01 October 2016 21:28:54 Dominik Haumann wrote: > On Fri, Sep 30, 2016 at 10:08 AM, David Faure wrote: > > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: > >> please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > &g

Re: Please add consistency in naming of (noK)Syntax(-)Highlighting library

Hi, On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote: > one of the things we praise about Qt is the predictability of class names > and methods names. Because the patterns used with them decrease the amount > of knowledge one needs to have, as things can be derived. No need to

Re: Please add consistency in naming of (noK)Syntax(-)Highlighting library

On Friday 04 November 2016 14:54:25 Volker Krause wrote: > Hi, > > On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote: > > one of the things we praise about Qt is the predictability of class names > > and methods names. Because the patterns used with the

Re: Review Request 129795: Only use .xml and .theme files for highlighting and themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129795/#review101886 --- Ship it! Ship It! - Volker Krause On Jan. 8, 2017, 5

Re: KUserFeedback => Frameworks?

On Freitag, 9. Oktober 2020 21:17:42 CEST Christoph Cullmann wrote: > On 2020-09-26 21:52, Christoph Cullmann wrote: > > Hi, > > > > is there any real reason why KUserFeedback is yet no official > > framework? > > > > I just stumbled over this during my try to add it as dependency for > > the Win

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

On Sonntag, 6. Dezember 2020 14:20:47 CET Friedrich W. H. Kossebau wrote: > you might have seen I asked* whether anyone knows a real world requirement > to stick with Qt 5.13 as new current minimum required Qt version for > current KF releases. So far no-one had to report a reason to support Qt >=

Re: KDE review for KWeatherCore

Having implemented the weather support for Itinerary, rebasing that onto a more comprehensive framework would indeed be welcome :) I haven't looked too deeply at the implementation or the API yet, most of the feedback below is based on things learned when implementing this for Itinerary. ## ap

Re: KDE review for KWeatherCore

On Samstag, 2. Januar 2021 12:44:31 CET Dominik Haumann wrote: > This is just by looking at the first two header files. > > Looking at WeatherForecast.cpp: > > double maxTemp = std::numeric_limits::min(); > double minTemp = std::numeric_limits::max(); > > Initializing the temperature to

Re: KDE Frameworks 6 - Virtual Sprint setup

On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > Hello, > I've been talking with David Faure about setting up a Sprint focused on KF6 > work. Some of the topics would include: > - Reviewing the KF6 board > (https://phabricator.kde.org/project/board/310/[1]): -- Clean up > -- Tagging Ju

Re: KDE Frameworks 6 - Virtual Sprint setup

On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > Hello, > I've been talking with David Faure about setting up a Sprint focused on KF6 > work. Some of the topics would include: > - Reviewing the KF6 board > (https://phabricator.kde.org/project/board/310/[1]): -- Clean up > -- Tagging Ju

KF6 meeting notes 2021-06-05

Hi all, here are the notes from today's KF6 weekly call: C++ 17 - can we use std::optional in public API? KPluginLoader has that need - we need to keep source compatibility with older KF5, so unconditional C++17 includes can be a problem during the remaining KF5 lifetime (but not for KF6) - shou

Re: KF6 meeting notes 2021-06-12

On Dienstag, 15. Juni 2021 12:45:21 CEST Luigi Toscano wrote: > David Faure ha scritto: > > On dimanche 13 juin 2021 20:32:42 CEST Luigi Toscano wrote: > >> -> we need need input about dfaure presence and try to avoid conflicts > >> with > >> Plasma BoFs > > > > I'm available Mon-Thu, but since Tu

Re: KF6 meeting notes 2021-06-12

On Freitag, 18. Juni 2021 15:01:00 CEST Kevin Ottens wrote: > Hello, > > On Tuesday, 15 June 2021 18:17:27 CEST Volker Krause wrote: > > On Dienstag, 15. Juni 2021 12:45:21 CEST Luigi Toscano wrote: > > > David Faure ha scritto: > > > > On dimanche 13 juin 20

Re: KF6 meeting notes 2021-06-12

On Freitag, 18. Juni 2021 22:27:40 CEST Kevin Ottens wrote: > On Friday, 18 June 2021 15:21:07 CEST Volker Krause wrote: > > Added now, Monday 09:00 UTC. > > OK, I will show up only at 10 though. I can't do 9. oh, sorry, I did this from the top of my head ("Monday mo

KF6 Akademy BoF Notes 2021-06-21

KF6 BoF Akademy Notes 2021-06-21 Topics: - how to continue and when to branch for a Qt 6 port - implications of Kevin's talk - better time for the weekly call - better priorities on the task board Branching: - Plasma and things depending on shadertools/RHI would like this to be done earlier than

KService as a platform abstraction framework?

Hi, while looking at implementing a pretty straightforward KApplicationTrader/ KIO::ApplicationLauncherJob use ([1]) for Android, I found myself wondering whether we should have an Android backend for KService. KService conceptually matches android.content.pm.PackageManager/PackageInfo [2, 3],

KF6 meeting notes 2021-07-12

Hi, apparently many people who voted for Monday 15:00 UTC as the new meeting time didn't get the memo yet that this is the new meeting time now ;-) So here's mainly topics that we weren't able to discuss and that we then need to cover next week (unless they resolve themselves on the mailing lis

KF6 meeting notes 2021-07-19

Topics remaining from last week: * Raising the Qt minimum version to 5.15.2: https://mail.kde.org/pipermail/ kde-frameworks-devel/2021-July/118039.html * STL use in KF implementation: https://invent.kde.org/frameworks/kio/-/ merge_requests/484 * Friedrich's alternative ECM branching proposal: https

KF6 meeting notes 2021-08-02

* https://phabricator.kde.org/T13056: Technically not a KF task, and solved itself by moving away from KAboutData. * https://phabricator.kde.org/T14564: There are a number of good reasons to consistently use JSON files, desktop files for editing might be nicer, but those files are rarely edited

Reminder: Weekly KF6 Meeting

Hi everyone, please remember the weekly KF6 meeting, every Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem. Attendance during the last two weeks was minimal unfortunately, hopefully just due to vacation time for many of you. Thank you, Volker signature.asc Description: Thi

KF6 meeting notes 2021-08-30

* https://phabricator.kde.org/T14312 - plugin loading is using a struct for this, so we consider this lower priority for now. * should we have a "nice to have" column on the work board? * https://phabricator.kde.org/T14784 - seems never set/used, so can be removed. * https://phabricator.kde.or

D28030: Also expose the true minimum size to QML

vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Useful in case you want to implement manual scaling there, for example. REPOSITORY

D27730: Add API to check whether a barcode is one- or two-dimensional

vkrause updated this revision to Diff 77607. vkrause added a comment. Rebase and bump version number to 5.69. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77128&id=77607 BRANCH arcpatch-D27730 REVISION DETAIL https://phabricator.kde.org/D277

D27730: Add API to check whether a barcode is one- or two-dimensional

This revision was automatically updated to reflect the committed changes. Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77607&id=7

D27909: Move barcode image scaling logic to AbstractBarcode

This revision was automatically updated to reflect the committed changes. Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to AbstractBarcode (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27909?vs=77158&id=77610 REVI

D27952: Simplify minimum size handling

vkrause updated this revision to Diff 77611. vkrause added a comment. Rebase and bump version numbers. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77302&id=77611 BRANCH arcpatch-D27952 REVISION DETAIL https://phabricator.kde.org/D27952 AFF

D27952: Simplify minimum size handling

This revision was automatically updated to reflect the committed changes. Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77611&id=77612 REVISION DETAIL https:/

D27989: Add a new set of barcode size functions

This revision was automatically updated to reflect the committed changes. Closed by commit R280:838f886c380f: Add a new set of barcode size functions (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27989?vs=77441&id=77647 REVISION DETAIL

D28030: Also expose the true minimum size to QML

This revision was automatically updated to reflect the committed changes. Closed by commit R280:e0dec83dd692: Also expose the true minimum size to QML (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28030?vs=77578&id=77650 REVISION DETAIL

D25984: Load translations

vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION DETAI

Re: New Framework Review: KDAV

ttens wrote: > Hello, > > On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > > the CalDav/ CardDav/GroupDav

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D28577 To: dfaure, vkrause, aacid, cgiboudeaux, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

vkrause added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:82 > Thanks for the heads-up. > > As you have noticed, the message is vague, so someone with access to one of > the affected systems should test it and submit a review. I don't have either of those here to test it

D28834: Add metadata properties to calendar

vkrause added a comment. In D28834#648405 , @winterz wrote: > I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now This is handled auto

D29079: android: include the architecture on the apk name

vkrause added a comment. +1, I can't judge the impact on the subsequent pipeline though, such as the fdroid repo handling. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks Cc: vkrause, kde-frameworks-devel, kde-builds

D29323: Handle multi-line and rich-text notifications on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY By default only a single line of the notification message is shown, for making longer messages readable we need to use

D29323: Handle multi-line and rich-text notifications on Android

vkrause added a comment. F8275264: Screenshot_20200501_124105.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >