D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH improve-notification-bell-icon (branched from master) REVISION DETAIL https://phabr

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky
trickyricky26 added a comment. I have made some slight adjustments from the original KAlarm design, such as a shadow line at the bottom instead of orange, to better fir our style. Should I make those changes in the original icon as well? REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH okular-trim-icons (branched from master) REVISION DETAIL https://phabricator.kde.or

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18552 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 added a comment. I'm not quite sure about the naming and the 32px `trim-to-selection` design as it shows the entire page as opposed to the other sizes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18552 To: trickyricky26, #vdg Cc: kde-framework

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. Going to make one more tiny change REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18552 To: trickyricky26, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 added a comment. In D18552#400495 , @ndavis wrote: > BTW, how did you change the colors of the labels for `montage`? I added `fill '#ff'` to the command. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabrica

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH okular-trim-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18552 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 updated this revision to Diff 50336. trickyricky26 added a comment. This revision is now accepted and ready to land. - Enlarge faded lines in trim-to-selection icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18552?vs=50334&id=50336

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread TrickyRicky
trickyricky26 added a comment. In D18552#400508 , @ngraham wrote: > I think the differences between those icon sizes is okay. If it's considered a problem, maybe we could make the 32px version match the smaller ones and omit the bottom line. I i

D18553: Add 32px changes

2019-01-26 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18439_1 REVISION DETAIL https://phabricator.kde.org/D18553 AFFECTED FILE

D18553: Add 32px changes

2019-01-26 Thread TrickyRicky
trickyricky26 abandoned this revision. trickyricky26 added a comment. This was created by mistake when I tried to work around Phabricators symlink bug. It shall remain a testament to this terrible pain facing developers. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kd

D18554: (Hopefully) rebase on master

2019-01-26 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18439 REVISION DETAIL https://phabricator.kde.org/D18554 AFFECTED FILES

D18439: Add proper edit-delete-shred icons

2019-01-26 Thread TrickyRicky
trickyricky26 updated this revision to Diff 50341. trickyricky26 added a comment. Hopefully finally rebase on master, please? REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18439?vs=50116&id=50341 BRANCH arcpatch-D18439 REVISION DETAIL https://ph

D18554: (Hopefully) rebase on master

2019-01-26 Thread TrickyRicky
trickyricky26 abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18554 To: trickyricky26 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-26 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. I will try to visually improve the design. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: ndavis, djarvie, kde-frameworks-devel, michaelh, ngraham,

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread TrickyRicky
trickyricky26 added a comment. I changed the shape a bit, but making it less flat is difficult: Linear gradients look off because of the curvature of the bell. Other options are blurring a curved object or using mesh gradients, but I'm not sure how well, if it all, these will work in ico

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-02 Thread TrickyRicky
trickyricky26 updated this revision to Diff 50703. trickyricky26 added a comment. - Use a less flat gradient with a silver ringer REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18533?vs=50280&id=50703 BRANCH improve-notification-bell-icon (branched

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-02 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

2019-02-10 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH drone-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D189

D18901: Add device icons for drones

2019-02-10 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, hein. trickyricky26 added a subscriber: hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg,

D18901: Add device icons for drones

2019-02-10 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. In D18901#409255 , @ngraham wrote: > From a distance, I wonder if those stationary rotors really connote the right thing. How hard would it be to make them look spinni

D18901: Add device icons for drones

2019-02-10 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg, hein Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

2019-02-10 Thread TrickyRicky
trickyricky26 updated this revision to Diff 51351. trickyricky26 added a comment. - Use a circular design for the rotor to make it more recognisable REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18901?vs=51323&id=51351 BRANCH drone-icons (branched

D18940: Add battery icons

2019-02-12 Thread TrickyRicky
trickyricky26 added a comment. I like it! Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part ends? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

2019-02-12 Thread TrickyRicky
trickyricky26 added a comment. Try rendering pngs of these icons with the montage-breeze commands found here: https://invent.kde.org/ndavis/hig-kde-org/wikis/home REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik Cc: trickyricky26,

D18940: Add battery icons

2019-02-12 Thread TrickyRicky
trickyricky26 added a comment. In D18940#410980 , @ndavis wrote: > I think having a different location based on battery level would get annoying You're probably right. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread TrickyRicky
trickyricky26 added a comment. I think the monochrome version is fine. For the colorful version, I suggest making the screen much bigger if that side isn't going to be filled with more buttons or the like. Also the partial outlines only on the top and bottom feel weird to me. I know th

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread TrickyRicky
trickyricky26 added a comment. In D18986#411807 , @ngraham wrote: > I like the head-on camcorder style, but there's the risk that it's less recognizable than the "classic" style of video recorder icon that's used pretty much everywhere. If we go

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread TrickyRicky
trickyricky26 added a comment. I like it! I think the "Type User" Icon would look better if the bars acting as placeholder text were a bit less regular in width and would not be shorter than they are tall (which is the case for the rightmost rectangle). Also, can the usernames in the t

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread TrickyRicky
trickyricky26 added a comment. As they are now it's long, short, long (exact same length as rectangle number 1), shorter than height (which looks bad imo). There are no medium lengths and the same length is used twice. I would suggest giving every bar a different length. If you're going

D18986: [breeze-icons] Add video camera icons

2019-02-19 Thread TrickyRicky
trickyricky26 commandeered this revision. trickyricky26 added a reviewer: rooty. trickyricky26 added a comment. I will make some minor changes to the 64px design. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, mich

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 updated this revision to Diff 52151. trickyricky26 added a comment. - Use a 64px design with a shotgun-type mic; use steeper angle for the lens on small versions REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52021&id=52151 BRA

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 updated this revision to Diff 52154. trickyricky26 added a comment. - Improve contrast by making the camera silver, add Breeze-style shadows to screen and buttons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52151&id=52154 BR

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 updated this revision to Diff 52161. trickyricky26 added a comment. - Add the bottom 1px shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52154&id=52161 BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.or

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread TrickyRicky
trickyricky26 updated this revision to Diff 52165. trickyricky26 added a comment. - Add -symbolic symlinks to the 16px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18986?vs=52161&id=52165 BRANCH arcpatch-D18986 REVISION DETAIL https://p

D19307: Enforce new muted icon style in all action icons

2019-02-25 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH correct-muted-action-icons (branched from master) REVISION DETAIL https://phabricat

D19307: Enforce new muted icon style in all action icons

2019-02-25 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

2019-02-25 Thread TrickyRicky
trickyricky26 updated this revision to Diff 52543. trickyricky26 added a comment. - Lower opacity of inactive sound waves to 0.25 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19307?vs=52542&id=52543 BRANCH correct-muted-action-icons (branched from

D19307: Enforce new muted icon style in all action icons

2019-02-25 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

2019-02-25 Thread TrickyRicky
trickyricky26 updated this revision to Diff 52566. trickyricky26 added a comment. - Change 16px player-volume-muted to symlink in order to pass duplicate test REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19307?vs=52543&id=52566 BRANCH correct-mute

D19307: Enforce new muted icon style in all action icons

2019-02-25 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricato

D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

2019-03-08 Thread TrickyRicky
trickyricky26 updated this revision to Diff 53430. trickyricky26 added a comment. - Name -symbolic icons properly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53315&id=53430 BRANCH collapse-expand-all-icons (branched from master) REVISIO

D19575: Add collapse-all and expand-all action icons

2019-03-09 Thread TrickyRicky
trickyricky26 updated this revision to Diff 53522. trickyricky26 added a comment. - Use design by @ndavis with tighter spacing REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53430&id=53522 BRANCH collapse-expand-all-icons (branched from mas

D19575: Add collapse-all and expand-all action icons

2019-03-09 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

2019-03-11 Thread TrickyRicky
trickyricky26 added a comment. Sure, go ahead. I'm busy right now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D20063: Sublime Merge Icon.

2019-03-27 Thread TrickyRicky
trickyricky26 added a comment. I think the cyan color is too bright and saturated. It fits the original branding well, but stands out from other Breeze icons. I would suggest using a darker, more blue than cyan color. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.

D21169: Add app icon for the Kirogi Drone control app

2019-05-12 Thread TrickyRicky
trickyricky26 created this revision. trickyricky26 added a reviewer: hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY Adds an app icon for @hein's upcoming Kirogi app. REPOSITORY R266 B

D21169: Add app icon for the Kirogi Drone control app

2019-05-12 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26, hein, #vdg Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread TrickyRicky
trickyricky26 created this revision. trickyricky26 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY Renamed the Sublime Text icon from sublime.svg to sublime-text.svg to e

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16815 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16905: Add a generic sorting options icon

2018-11-15 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kd

D16905: Add a generic sorting options icon

2018-11-15 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze Cc: kde-frameworks-devel, mich

D16905: Add a generic sorting options icon

2018-11-15 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

2018-11-15 Thread TrickyRicky
trickyricky26 added a comment. I do agree that the 22px version is clearer with two lines in between the arrows: F6425790: sorting-icon-22-alt.png To fit this into the 16px was difficult, however: F6425793: sorting-icon-16-alt.png

D16905: Add a generic sorting options icon

2018-11-15 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. I have adjusted the arrows to fit the `view-sort-ascending` style: F6425856: sorting-icon-22-alt.png 22px F6425879: sorting-icon-16-alt.png

D16905: Add a generic sorting options icon

2018-11-15 Thread TrickyRicky
trickyricky26 added a comment. So should I include the renaming of the existing icons and add ascending and descending versions of these new ones in this revision? That way applications that use `view-sort-ascending` for alphabetical order will have it replaced, but I guess that's okay becau

D16905: Add a generic sorting options icon

2018-11-16 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

2018-11-16 Thread TrickyRicky
trickyricky26 added a comment. I made all necessary versions of these icons (`24px` not shown since they're the same as `22px`): | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | -- | --- | - | -- | | `16px`

D16905: Add a generic sorting options icon

2018-11-16 Thread TrickyRicky
trickyricky26 added a comment. This is how the set looks with the arrows above the lines in the descending versions: | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | - | --- | - | --

D16905: Add a generic sorting options icon

2018-11-16 Thread TrickyRicky
trickyricky26 added a comment. | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | - | --- | - | -- | | `16px`| F6427148: view-sort-16.svg.png

D16905: Add a generic sorting options icon

2018-11-16 Thread TrickyRicky
trickyricky26 updated this revision to Diff 45599. trickyricky26 edited the test plan for this revision. trickyricky26 added a comment. This revision is now accepted and ready to land. - Add new generic sorting icons, rename existing ordered sorting icons to -name scheme (see updated revi

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-16 Thread TrickyRicky
trickyricky26 retitled this revision from "Add a generic sorting options icon" to "Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme". trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R2

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-16 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. @emateli 1. You're absolutely right about that, don't know how I missed this. With the correct naming, should the arrows still point to the end with longer lines? 2. They are sorted, but some lines were short

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-16 Thread TrickyRicky
trickyricky26 added a comment. So you're saying the direction of the arrows is consisten with the current way, as long as the ascending and descending names are switched, correct? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #b

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-16 Thread TrickyRicky
trickyricky26 updated this revision to Diff 45611. trickyricky26 added a comment. This revision is now accepted and ready to land. - Fix naming of ascending and descending versions; make ascending versions less confusing; fix symlink sort-name I have flipped the naming of the ascending an

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-16 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-16 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, mic

D16934: Add help-browser symlink to 16px and 22px directories

2018-11-16 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-help-browser-symlink (branched from master) REVISION DETAIL https://phabricator

D16934: Add help-browser symlink to 16px and 22px directories

2018-11-16 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16934 To: trickyricky26, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16934: Add help-browser symlink to 16px and 22px directories

2018-11-17 Thread TrickyRicky
trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16934 To: trickyricky26, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-17 Thread TrickyRicky
trickyricky26 added a comment. I am sure that in ascending, the lines get longer further down (representing larger file sizes etc.). The thing I am not quite sure about is the direction of the arrows. In D16905#360524 , @cfeck wrote: > On l

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-17 Thread TrickyRicky
trickyricky26 updated this revision to Diff 45667. trickyricky26 added a comment. - Switch arrow directions in ascending and descending variants REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45611&id=45667 BRANCH add-sort-options-icon (bra

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

2018-11-17 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, mic

D16905: Add new generic sorting icons; rename existing sorting icons

2018-11-17 Thread TrickyRicky
trickyricky26 retitled this revision from "Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme" to "Add new generic sorting icons; rename existing sorting icons". REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISIO

D16905: Add new generic sorting icons; rename existing sorting icons

2018-11-17 Thread TrickyRicky
trickyricky26 added a comment. That was not supposed to be there anymore after we changed the name. I'm going to remove `sort.svg` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham

D16905: Add new generic sorting icons; rename existing sorting icons

2018-11-17 Thread TrickyRicky
trickyricky26 updated this revision to Diff 45684. trickyricky26 added a comment. - Remove old sort.svg icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45667&id=45684 BRANCH add-sort-options-icon (branched from master) REVISION DETAIL

D16905: Add new generic sorting icons; rename existing sorting icons

2018-11-17 Thread TrickyRicky
trickyricky26 added a comment. Ok I will change that, however the graphic on the Icons HIG Page (https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 28px which means 2px margins on each size. So that graphic should be updated, or if the 4px margins only apply to acti

D16905: Add new generic sorting icons; rename existing sorting icons

2018-11-17 Thread TrickyRicky
trickyricky26 updated this revision to Diff 45689. trickyricky26 added a comment. - Change margins to 4px in 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45684&id=45689 BRANCH add-sort-options-icon (branched from master) REVIS

D16905: Add new generic sorting icons; rename existing sorting icons

2018-11-17 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16964: Change archive-* action icons to represent archives

2018-11-17 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH change-archive-action-icons (branched from master) REVISION DETAIL https://phabrica

D16964: Change archive-* action icons to represent archives

2018-11-17 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16964 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D16951: Add mouse button icons

2018-11-18 Thread TrickyRicky
trickyricky26 added a comment. I would suggest making the mouse wheel itself turn blue as highlighting REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, mic

D16964: Change archive-* action icons to represent archives

2018-11-18 Thread TrickyRicky
trickyricky26 added a comment. Do you think this is more consistent: F6430252: archive-extract-22-new.svg.png F6430251: archive-extract-16-new.svg.png I shortened the zipper to make more room for the action

D16964: Change archive-* action icons to represent archives

2018-11-18 Thread TrickyRicky
trickyricky26 updated this revision to Diff 45719. trickyricky26 added a comment. - Make zipper consistent with archive mimetype icons; tightened the gap for the emblems to be more consistent; 32px icons with 2px margins REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phab

D16964: Change archive-* action icons to represent archives

2018-11-18 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16964 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

2018-11-18 Thread TrickyRicky
trickyricky26 added a comment. I think it's not quite clear enough on it's own, however together with the other icons it will be clear REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolas

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

2018-11-20 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-dialog-ok-apply (branched from master) REVISION DETAIL https://phabricator.kde.

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

2018-11-20 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17062 To: trickyricky26, #vdg, #breeze Cc: kde-frameworks-devel, mich

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

2018-11-22 Thread TrickyRicky
trickyricky26 updated this revision to Diff 46036. trickyricky26 added a comment. Rebase onto master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17062?vs=45914&id=46036 BRANCH arcpatch-D17062 REVISION DETAIL https://phabricator.kde.org/D17062

  1   2   3   >