Re: Review Request 129252: Support non integer scale factors in KFileDelegate

aswell. - Roman Gilg On Okt. 24, 2016, 5:05 nachm., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Differential] [Commented On] D4040: [Icon Item] Round size we want to load a pixmap in

subdiff added a comment. Just tested and this solves pixelated launcher icons, i.e. https://bugs.kde.org/show_bug.cgi?id=374707 REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4040 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Commented On] D4040: [Icon Item] Round size we want to load a pixmap in

subdiff added a comment. It seems there have been problems with this before the new aspect-ratio aware IconItem aswell. See https://bugs.kde.org/show_bug.cgi?id=365326 Could your patch also solve this issue? Then we need to backport it to 5.8. REPOSITORY R242 Plasma Frameworks REVISIO

D24826: Enforce 100 chars line width

romangg added a comment. FYI I'm using a strict 100 chars limit nowadays on all my KWinFT projects (with the exception of KWinFT itself for now) and I'm very happy with this decision. As an example you can compare these two otherwise still pretty similar files: https://invent.kde.org/p

D24826: Enforce 100 chars line width

romangg abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: carewolf, winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

romangg added a comment. README.md is common for viewing in modern code hosting solutions with markdown support. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D28620 To: davidedmundson, #plasma, apol

D28620: Add readmes clarifying state of plasma component versions

romangg accepted this revision. romangg added a comment. If you want to you can also add a ⚠️ (`:warning:`) emoticon to the deprecated text and in both some headings with `#`, `##`, etc. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.o

D28882: Create protocol to manage video feeds

romangg added inline comments. INLINE COMMENTS > screencast.xml:8 > + ]]> > + > + Interface names should be scoped too. Example

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

romangg added inline comments. INLINE COMMENTS > zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:129 > We probably need to ask folks in `#wayland` whether inhibitors outlive the > manager object. In general objects created through some interface can outlive the interface bind if not oth

Re: Recent breakage in kwallet

On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > Hi all, > Recently, the package of KWallet framework for neon (devel unstable, > package built out of current master state) seems to be broken: kwallet > now can't open anymore wallets previously created (it works if the > local kwallet data

Re: Recent breakage in kwallet

On Fri, May 15, 2020 at 3:53 PM Roman Gilg wrote: > > On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > > > Hi all, > > Recently, the package of KWallet framework for neon (devel unstable, > > package built out of current master state) seems to be brok

D1231: Add Remote Access interface to KWayland

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:430 > +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui > KF5::WaylandClient KF5::WaylandServer) > +add_test(kwayland-testRemoteAccess testRemoteAccess) > +ecm_mark_as_test(testRemoteAccess) `add_test(NAME kwayland-testRe

D11583: Add platform detection and adjustment to kded

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH platform-detection REVISION DETAIL https://phabricator.kde.org/D11583 To: graesslin, #frameworks, #plasma, apol, romangg Cc: michaelh, ngraham

D1231: Add Remote Access interface to KWayland

romangg accepted this revision. romangg added a comment. Looks fine to me. Tested compilation as well as runtime with KWin's DRM+EGL backend. - Please change in comments the frameworks version number these changes are landing in. - I would like to have @davidedmundson look over this pa

D11709: Don't create dependency loop

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH fix-kpackag REVISION DETAIL https://phabricator.kde.org/D11709 To: bshah, romangg Cc: #frameworks, michaelh, ngraham

D11732: Improve protocols documentation

romangg created this revision. romangg added a reviewer: Frameworks. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY Improves the outputmanagement and outputdevice protocol documentation. REPOSITORY R127 KWayland BRANCH improv

D11732: Improve protocols documentation

romangg added a comment. Currently I'm reading through these protocols for my 5.13 color correction work and I was wondering about the output management related protocol documentation, which seems to me faulty in large areas. In fact it seems to me so wrong, that I'm asking myself if I just

D11732: Improve protocols documentation

romangg updated this revision to Diff 30925. romangg marked an inline comment as done. romangg added a comment. - Say properties REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11732?vs=30673&id=30925 BRANCH improveOutputManagementDoc REVISION DETAIL

D11732: Improve protocols documentation

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice.xml:67 > earlier you changed all the "compositor" to "server" The usage of terms compositor and server is not clearly regulated in the Wayland world besides that these terms describe the same "application" (fo

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a dummy only on non-Linunx systems? This way we could use the system one on Linux.

D12235: Add XDG Output Protocol

romangg added a reviewer: romangg. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12235 To: davidedmundson, romangg Cc: #frameworks, michaelh, ngraham, bruns

D11732: Improve protocols documentation

romangg added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks Cc: davidedmundson, michaelh, ngraham, bruns

D12235: Add XDG Output Protocol

romangg added a task: T8501: Fractional Scaling. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12235 To: davidedmundson, romangg Cc: #frameworks, michaelh, ngraham, bruns

D12388: Output device color curves correction

romangg created this revision. romangg added a reviewer: Frameworks. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY Extends the output device and output configuration interfaces with the ability to query and set the RGB color int

D12235: Add XDG Output Protocol

romangg added a comment. - Replace `XDGOUTPUTVERSION` with the next framework release version. - xdgoutputtest.cpp is missing INLINE COMMENTS > registry.h:624 > + * Prefer using createXdgOutputManager instead. > + * @see createXdgOutputUnstableV1 > + * @since 5.XDGOUTPUTVERSION

D12235: Add XDG Output Protocol

romangg added inline comments. INLINE COMMENTS > display.h:263 > +/** > + * Creates the ServerSideDecorationPaletteManagerInterface > + * the //XdgOutputManagerInterface// > xdgoutput_interface.cpp:107 > +}); > +connect(this, &QObject::destroyed, this, [this, output]

D12235: Add XDG Output Protocol

romangg added a comment. According to protocol the logical size and position events should only be send (i) on creation of an xdg_output object and (ii) when the size or position changed. There is currently no check in the server interface, if the size and position really changed w

D12235: Add XDG Output Protocol

romangg added inline comments. INLINE COMMENTS > romangg wrote in xdgoutput_interface.cpp:83 > This variable is only relevant until the compositor has sent for the first > time the done event via `XdgOutputInterface::done()`. Afterwards it is always > true. Is it meant this way? If yes, could w

D12388: Output device color curves correction

romangg added inline comments. INLINE COMMENTS > zzag wrote in outputconfiguration.cpp:184 > Maybe `static_cast`? > > I haven't used wl_array but can't you allocate big enough contiguous chunk of > memory and call memcpy, e.g. > > wl_array wlRed; > > wl_array_init(&wlRed); > auto* red

D12388: Output device color curves correction

romangg updated this revision to Diff 33397. romangg added a comment. - autotests - improve doc - memcpy wl_array REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=32669&id=33397 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https:

D11732: Improve protocols documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R127:272112a07f07: Improve protocols documentation (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11732?vs=30925&id=33400 REVISION DETAIL http

D12388: Output device color curves correction

romangg updated this revision to Diff 33453. romangg added a comment. - memcpy wl_array in colorcurvesCallback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33397&id=33453 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https://phabr

D12388: Output device color curves correction

romangg marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks Cc: davidedmundson, zzag, cfeck, michaelh, bruns

D12388: Output device color curves correction

romangg updated this revision to Diff 33551. romangg added a comment. - Fix protocol versions, events/requests order REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33453&id=33551 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https:/

D12388: Output device color curves correction

romangg marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks, davidedmundson, graesslin Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns

D12388: Output device color curves correction

romangg updated this revision to Diff 33554. romangg added a comment. Rebase on current master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33551&id=33554 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https://phabricator.kde.org/D

D12388: Output device color curves correction

romangg updated this revision to Diff 33563. romangg added a comment. - Use const size_t instead of int - Remove struct keyword on function calls - More const keyword - memcpy in sendColorCurves REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs

D12388: Output device color curves correction

romangg marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks, davidedmundson, graesslin Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns

D12388: Output device color curves correction

romangg updated this revision to Diff 33564. romangg added a comment. Increase org_kde_kwin_outputmanagement version as well (needed to create config objects of version 2) REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33563&id=33564 BRANCH o

D12820: Add KWayland virtual desktop protocol

romangg added a comment. The file org_kde_plasma_virtual_desktop.xml should be renamed to virtual-desktops.xml or plasma-virtual-desktops.xml to have a similar name format as the other protocol files we have. Also I would in general prefer to just call it "VirtualDesktop..." instaed of "Plas

D12820: Add KWayland virtual desktop protocol

romangg added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > isn't better the layout to be communicated by the manager? the reasoning was > to have it loosely map on models. > the model tells how many rows it has, then the single item on what row it is

D12235: Add XDG Output Protocol

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D12235 To: davidedmundson, romangg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

romangg added a comment. In D12820#263516 , @mart wrote: > but then... how to manage collisions? allowing to set the same row/column to different desktops and make kwin responsibility of this not happening? For a layout change the composi

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Dialog might try to set PlasmaShellSurface before Wayl

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg added a task: T8771: PlasmaQuick::Dialog and/or KWin (internal window) problems. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg added a comment. In D13037#266379 , @davidedmundson wrote: > should mean the server will announce all the interfaces and we block all execution until we've processed it all. DialogShadows is created as Q_GLOBAL_STATIC. Maybe that

D13076: Increase org_kde_plasma_shell interface version

romangg created this revision. romangg added reviewers: Plasma, sharvey. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY It was forgotten in 10b00a219e

D13076: Increase org_kde_plasma_shell interface version

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f0363584861c: Increase org_kde_plasma_shell interface version (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13076?vs=34745&id=34768 REVISI

D12388: Output device color curves correction

romangg updated this revision to Diff 34770. romangg added a comment. - Send color curves only for version 2 and above REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33564&id=34770 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https

D12388: Output device color curves correction

romangg marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks, davidedmundson, graesslin Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, ngraham, bruns

D13190: [autotests] Fix surface destroy test

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Interfaces must be cleaned up correctly and client pro

D13191: [server] Small code cleanup in SurfaceInterface

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Use lambda function to reduce code duplication and put

D13191: [server] Small code cleanup in SurfaceInterface

romangg added a comment. In D13191#270177 , @davidedmundson wrote: > > function definitions in correct order. > > What's more correct about this order? In surface_interface_p.h the functions are declared in this order: void ins

D13190: [autotests] Fix surface destroy test

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d3a29d6babc3: [autotests] Fix surface destroy test (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13190?vs=35092&id=35098 REVISION DETAIL

D13238: [tests] Add pointer constraints test

romangg created this revision. romangg added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY To better test the usage of pointer confine

D13238: [tests] Add pointer constraints test

romangg edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13238 To: romangg, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13238: [tests] Add pointer constraints test

romangg added a comment. There are some visual glitches with the QWidget code. If there are simple fixes for that, I will very happily do them. Otherwise since it's just a test application, it isn't really worth the effort. I also thought about using QGraphicsAnchorLayout, instead of normal

D13238: [tests] Add pointer constraints test

romangg added a project: Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13238 To: romangg, #plasma, #frameworks Cc: kde-frameworks-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, jensreuterbe

D13238: [tests] Add pointer constraints test

romangg added a task: T8923: Improve cursor locking and confining. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13238 To: romangg, #plasma, #frameworks Cc: kde-frameworks-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, al

D13238: [tests] Add pointer constraints test

romangg updated this revision to Diff 35265. romangg added a comment. - Cleanup one shot constraints REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13238?vs=35256&id=35265 BRANCH pointerConstraintsTest REVISION DETAIL https://phabricator.kde.org/D132

D13238: [tests] Add pointer constraints test

romangg added a comment. It could make more sense to have this test in KWin instead of KWayland. Especially when later on the Xwayland backend is added (would be optional on compile time though). Any opinions on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg created this revision. romangg added reviewers: Plasma, KWin, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This solves for me not working relati

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg added a task: T8923: Improve cursor locking and confining. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg, #plasma, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#265444 , @graesslin wrote: > any update on this? Currently I'm working on other stuff and don't want to increase the mental load. I really only need this when looking again into sub-surfaces to handle Xwa

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. What's the current state of this patch and the KWin one? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: fredrik, #kwin, #plasma, graessl

D13302: check for needed version of libavcode, libavformat and libavutil

romangg added a comment. I tried this patch on Neon with FFmpeg 2.8.14. KFileMetaData builds now because it detects that the FFmpeg module version numbers are too low. CMake log: P230 Few remarks: - In the log it says 3 times `Could NOT fi

D13191: [server] Small code cleanup in SurfaceInterface

romangg edited the summary of this revision. REPOSITORY R127 KWayland BRANCH surfaceCodeCleanup REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

romangg added a comment. How is a change of neighbors supposed to work for clients already bound to the proxy objects? For example consider virtual desktop grid: D1 D2 D3 D4 Compositor removes `D3` and let `D4` flow back to the left: D1 D2 D4 `desktop_removed` e

D13238: [tests] Add pointer constraints test

romangg abandoned this revision. romangg added a comment. I decided to add the test to KWin instead with: D13439 Thanks to Vlad for review comments. I incorporated them in the new patch for KWin. REPOSITORY R127 KWayland REVISION DETAIL https://

D13191: [server] Small code cleanup in SurfaceInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:31b1c144fde7: [server] Small code cleanup in SurfaceInterface (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13191?vs=35095&id=35957 REVISI

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg, #plasma, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg abandoned this revision. romangg added a comment. Abandoned in favor of D13084 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: graesslin, davidedmundson, kde-frameworks-de

D12820: Add KWayland virtual desktop protocol

romangg added a comment. We can remove every layout reference in the manager as well as in the VDs. I don't see the advantage then with a list in contrast to events desktopAdded / desktopRemoved and a done event. What is better about having an ordering? It's only relevant for the special cas

D13494: Fix stupid copy paste bug in XDGShellV6 Client

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > xdgshell_v6.cpp:180 > uint32_t constraint = 0; > + > if > (positioner.constraints().testFlag(XdgPositioner::Constraint::SlideX)) { remove this new line RE

D13488: Make XDGShellV5 co-compilable with XDGWMBase

romangg added inline comments. INLINE COMMENTS > xdgshell_v5.cpp:36 > public: > -void setupV5(xdg_shell *shell) override; > +void setupV5(xdg_shell *shell); > void release() override; This should be still an override. > wayland-xdg-shell-v5-client-protocol.h:1 > +/* Generated by w

D13495: Fix XDGV6 popup test

romangg added a comment. What's with positioner2? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

romangg added inline comments. INLINE COMMENTS > registry.cpp:88 > #include > +#include > nitpick: put this include directly below the other xdg-shell ones above. > xdgshell_stable.cpp:195 > + > +uint32_t constraint = 0; > +if > (positioner.constraints().testFlag(XdgPositioner::Co

D13510: Add XDG WM Base support to our XDGShell API

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_stable_interface.cpp:246 > What role do you think it should be? > > I'm using the error for when a wl_surface has another role in the case that > you call get_xdg_surface twice on the same wl_surface, which seems

D13535: Do not cancel old clipboard selection if it is same as the new one.

romangg added a comment. In D13535#278441 , @fvogt wrote: > in TestDataDevice::testReplaceSource() and it fails without this patch. > With this patch however, the selection isn't offered (is that correct behaviour?) so the wait() times out.

D13535: Do not cancel old clipboard selection if it is same as the new one.

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks, romangg Cc: michalsrb, romangg, graesslin, kde-frameworks-devel, michaelh, ngraham,

D13601: OutputManagement fractional scaling

romangg added inline comments. INLINE COMMENTS > outputdevice_interface.cpp:449 > SETTER(setScale, int, scale) > +SETTER(setScaleF, qreal, scale) > SETTER(setSubPixel, SubPixel, subPixel) The macro does not do a fuzzy compare. > outputdevice_interface.h:138 > void refreshRateChanged(int)

D13601: OutputManagement fractional scaling

romangg requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13601 To: davidedmundson, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg edited the summary of this revision. REPOSITORY R127 KWayland BRANCH fixRelativeMotionFrame REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg, #plasma, #kwin, #frameworks, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg added a comment. Correct, in the end we want to combine input events and send them batched. For now the KWayland code does not allow this in general. REPOSITORY R127 KWayland BRANCH fixRelativeMotionFrame REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg, #plasma

D13257: [server] Send frame event instead of flush on relative pointer motion

This revision was automatically updated to reflect the committed changes. Closed by commit R127:5e195c2a67ce: [server] Send frame event instead of flush on relative pointer motion (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13257?vs=

D12820: Add KWayland virtual desktop protocol

romangg added inline comments. INLINE COMMENTS > plasma-virtual-desktop.xml:55 > + > + > + This needs more description. Other events below as well. > plasmavirtualdesktop_interface.cpp:181 > + > +PlasmaVirtualDesktopInterface > *PlasmaVirtualDesktopManagementInterface::createDe

D13488: Make XDGShellV5 co-compilable with XDGWMBase

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13488 To: davidedmundson, #plasma, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13730: Fix memory management in WaylandOutputManagement

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. This seems to depend on D13601 because of the `scaleFCallback`. REPOSITORY R127 KWayland BRANCH dave REVISION DETAIL https://phabricator.kde.o

D13729: Isolate every test within WaylandOutputManagement

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. There is no reason to use the member variable `m_outputConfiguration` and the method `createConfig` anymore. Just use a scoped pointer in the tests you need it. But we can leave it like t

D13510: Add XDG WM Base support to our XDGShell API

romangg added a comment. From my side I can't see anything wrong right now. Since we would merge after the next release anyways we have some time to correct any overlooked mistakes afterwards. Or would it make sense to wait on merging until Qt 5.12 with XDG WM Base support is available to ha

D12820: Add KWayland virtual desktop protocol

romangg added a comment. The VD protocol was a pure "consumer" protocol before this last revision. Now it gets more complicated by putting requests into it for asking the compositor to change its configuration. I thought this was supposed to go through Dbus. How do you plan to restrict s

D12820: Add KWayland virtual desktop protocol

romangg added a comment. In D12820#286961 , @mart wrote: > But.. how would you implement "move this window to a new desktop" in that case? This functionality is part of the (amended) plasma window management protocol and not of the new V

D13510: Add XDG WM Base support to our XDGShell API

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Implement support for locked pointer cursor hints. TE

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37917. romangg added a comment. - Cleanup: remove hint getter REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37916&id=37917 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 AFFECTED

D14175: Support cursor hints on locked pointer

romangg added a task: T4692: [kwayland] Support cursor hint on LockedPointerInterface. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg added a dependent revision: D14176: Use locked cursor position hint. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37938. romangg added a comment. - Add autotest REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37917&id=37938 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 AFFECTED FILES autote

D14175: Support cursor hints on locked pointer

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in pointerconstraints_interface.h:126 > do we not want a getter method? > > One of kwayland's main roles is to be a property cache The hint is used by the compositor after unlock again. This unlock can also happen on destruc

D14183: Fix selection and seat auto tests

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The selection test is broken since 5e195c2a67ce

  1   2   3   4   >