Re: Stepping down as KRunner maintainer

Thanks for all your work Kai and congratulations Alexander, this is well deserved! Cheers Nico On 08.10.20 19:17, Kai Uwe Broulik wrote: Hi everyone, you might not even have known this but officially I have been KRunner's maintainer for several years at this point :-) However, I have decide

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29020: Add example/test application

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29020 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28834: Add metadata properties to calendar

nicolasfella abandoned this revision. nicolasfella added a comment. moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/19 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause, w

D24443: Add a plugin system

nicolasfella abandoned this revision. nicolasfella added a comment. Moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/20 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc

PSA: Frameworks depends on Qt 5.13 now

Hi, per our Qt dependency policy [0] Frameworks depends on Qt 5.13 6 months after the release of Qt 5.15, which is now. Have fun with the new stuff. Nico [0] https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

Re: Would distributions have an issue if KF 5.77+ would require Qt >= 5.14 (instead of >= 5.13 as of now)?

Hi, with my KDE Android hat on this would be fine, we use Qt 5.15. For KDE's own Windows/Mac builds I'd expect it to be similar. What most/all not-traditional-Linux-distro users have in common is that they are not bound to the specific Qt version decided and shipped by a vendor and instead eithe

D23835: Add TabKCM

nicolasfella abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D22093: Don't show progress window for jobs that don't report progress

nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22093 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: ngraham, davidedmundson, aspotashev, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: KDE review for KWeatherCore

On 12/21/20 3:19 PM, Friedrich W. H. Kossebau wrote: Am Montag, 21. Dezember 2020, 07:16:09 CET schrieb hanyoung: KWeatherCore: https://invent.kde.org/libraries/kweathercore is a library for querying weather forecast data. During the development of KWeather, we found the need to have a weather

D26449: [PoC] Port to KRecentFileMenu

nicolasfella abandoned this revision. nicolasfella added a comment. https://invent.kde.org/utilities/ark/-/merge_requests/39 REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D26449 To: nicolasfella, #ark, #frameworks Cc: meven, mlaurent, kde-utils-devel, fbampaloukas, tctar

KGlobalAccel on non-Plasma systems

Hi, we received a few reports [1] [2] from people using non-Plasma systems that the kglobalaccel5 process was started, leading to clashes with the native global shortcut system. This seems to happen when apps call some API of KGlobalAccel which results in the kglobalaccel5 process to be DBus-act

Re: KGlobalAccel on non-Plasma systems

XDG_CURRENT_DESKTOP set to KDE, so it is safe in that regard. On Tue, 2021-04-06 at 17:29 +0200, Nicolas Fella wrote: Hi, we received a few reports [1] [2] from people using non-Plasma systems that the kglobalaccel5 process was started, leading to clashes with the native global shortcut system.

Re: KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.15 - Build # 58 - Still Unstable!

Hi David, this should be fixed with https://invent.kde.org/frameworks/ki18n/-/merge_requests/15 Cheers Nico On 1 May 2021 11:20:31 CEST, David Faure wrote: >Hi Nicolas, > >It looks like the ki18n commit > >Backport FindIntl.cmake from CMake 3.20 > >might have broken the lookup of tran

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

nicolasfella added a comment. Do we actually *want* to use the API that has been introduced in production? From QStringView:: toInt: Note: This method has been added in 5.15.2 to simplify writing code that is portable between Qt 5.15 and Qt 6. The implementation is not tuned for p

Respin request for qqc2-desktop-style

Hi David, can we please get a respin for the qqc2-desktop-style tarball with https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/73 inside? Cheers Nico

Re: Notice of withdrawal of CI services: KDevelop and KDE Connect

Hi Ben, On 16.06.21 20:28, Ben Cooksley wrote: Hi all, The following is notice that I intend to withdraw CI services from the following two KDE projects due to faults in their code or build system which are having a significant adverse impact on the CI system and negatively impacting on other p

Re: dark theme on windows in KF 5.83

On 17.06.21 10:18, Alexander Semke wrote: Hi, with the last nighly build for LabPlot we observed a big regression on Windows. Attached are two files. The first one is based on KF 5.82, the second one on 5.83. In both cases the default color scheme is used in LabPlot which is Window's dark theme

T14621: [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar

nicolasfella added a comment. I'm not sure this makes sense on a semantic level. The current PlasmoidHeading happens to be very similar to a toolbar, but is that always going to be the case? I don't want us to be locked into a situation where we can't change things later on because they woul

T14621: [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar

nicolasfella removed a project: KF6. TASK DETAIL https://phabricator.kde.org/T14621 To: nicolasfella Cc: nicolasfella, niccolove, mart, kde-frameworks-devel, mikeljohnson, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezh

Re: KService as a platform abstraction framework?

On 03.07.21 10:25, Volker Krause wrote: Hi, while looking at implementing a pretty straightforward KApplicationTrader/ KIO::ApplicationLauncherJob use ([1]) for Android, I found myself wondering whether we should have an Android backend for KService. KService conceptually matches android.conten

Re: Gitlab CI - Inbound

On 05.09.21 08:13, Ben Cooksley wrote: Hi all, This morning after much work i'm happy to announce that the new generation CI scripts intended for use with Gitlab CI successfully completed their first build (of ECM, and then subsequently of KCoreAddons). This begins our first steps towards trans

D28110: PersonsModel: Fix PersonVCardRole

nicolasfella added inline comments. INLINE COMMENTS > personsmodel.cpp:186 > case PersonsModel::PersonVCardRole: > -return QVariant::fromValue(person); > +return person->customProperty(QStringLiteral("vcard")); > case PersonsModel::ContactsVCardRole: Use AbstractContact

D28110: PersonsModel: Fix PersonVCardRole

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fix-personsmodel-vcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D28110 To: jbbgameich, apol, nicolasfella Cc: nicolasfella, kde-frameworks-devel,

D27635: Restore kio-webdav plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R155:693d7361428e: Restore kio-webdav plugin (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27635?vs=77280&id=77965#toc REPOSITORY R155 KAccounts Integration CHANGES

D25660: Decouple KBookmarksMenu from KActionCollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:0c888e2f8098: Decouple KBookmarksMenu from KActionCollection (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25660?vs=73666&id=78402#toc REPOSITORY R294 KBookmarks

D26918: Improve KNotification API docs

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in Mainpage.dox:9 > @class so we create a link. Doxygen should do that automatically http://www.doxygen.nl/manual/autolink.html REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfel

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 78416. nicolasfella added a comment. - Add a dedicated main page and link to the HIG from there - Move most content to main page - Fix code example REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 78423. nicolasfella added a comment. - Drop user config file description since it's an implementation detail REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=78416&id=78423 BRANCH docs REVISION DE

D28312: Implement urls using hints

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Set the hint directly in KNotification instead of the backe

D28295: Introduce KNotificationJobUiDelegate

nicolasfella added inline comments. INLINE COMMENTS > knotificationjobuidelegate.h:29 > + * > + * A UI delegate using KMessageBox for interaction (showing errors and > warnings). > + * s/KMessageBox/KNotification/g? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.or

D28295: Introduce KNotificationJobUiDelegate

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Otherwise looks good to me INLINE COMMENTS > knotificationjobuidelegate.h:28 > + * @class KNotificationJobUiDelegate knotificationjobuidelegate.h > KNotificationJobUiDelegate >

D28391: [pc3/busyindicator] Hide when not running

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When not running the indicator should be invisible. This matches the b

D28391: [pc3/busyindicator] Hide when not running

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bc3ccd1782cb: [pc3/busyindicator] Hide when not running (authored by nicolasfella). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28391?vs=78768

D24443: Add a plugin system

nicolasfella planned changes to this revision. nicolasfella added a comment. - single level hierarchy with a calendargroup object - calendar entry folded into calendar - calendar::open REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28800: Always create actioncollection

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Otherwise subclasses that unconditionally use m_actionCollection will get crashes. Observed in D28789

D28800: Always create actioncollection

nicolasfella added reviewers: Frameworks, dfaure, stefanocrocco. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D28800 To: nicolasfella, #frameworks, dfaure, stefanocrocco Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R296 KDeclarative BRANCH tweakdocs REVISION DETAIL https://phabricator.kde.org/D28805 AFFECTED FILES src/qm

D28805: Tweak kcmcontrols docs

nicolasfella added a reviewer: jucato. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks, jucato Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

nicolasfella added a comment. In D28800#647508 , @dfaure wrote: > (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) makes sense REPOSITORY R294 KBookmarks BRANCH empty

D28800: Always create actioncollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b3fc2aedd86: Always create actioncollection (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28800?vs=80034&id=80051 REVISION DETAIL

D26918: Improve KNotification API docs

nicolasfella added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28831: Add note about porting loadMimeTypeIcon

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We're phasing out loadMimeTypeIcon in favor of QIcon::fromTh

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. In D25707#645694 , @dfaure wrote: > OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. > > I remember wondering th

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee08d0b4e56e: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25707?vs=70853&i

D27704: Drop FindAccountsFileDir.cmake

nicolasfella abandoned this revision. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella, #frameworks, bshah, leinir, lbeltrame Cc: lbeltrame

D22554: Finer No-Dbus on Windows

nicolasfella added a comment. @brute4s99 Is this still relevant? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

nicolasfella updated this revision to Diff 80139. nicolasfella added a comment. - Update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70143&id=80139 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES src/core

D25443: [chmodjob] Port away from QLinkedList

nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28834: Add metadata properties to calendar

nicolasfella added reviewers: Frameworks, KDE PIM, vkrause. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

nicolasfella added a dependent revision: D24443: Add a plugin system. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss

D24443: Add a plugin system

nicolasfella updated this revision to Diff 80141. nicolasfella added a comment. - Remove calendarentry REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=71067&id=80141 BRANCH arcpatch-D24443_2 REVISION DETAIL https://phabricator.kde.org/D

D24443: Add a plugin system

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D28834: Add metadata properties to calendar. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim, dkard

D24443: Add a plugin system

nicolasfella updated this revision to Diff 80142. nicolasfella added a comment. - Convert license headers to SPDX REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=80141&id=80142 BRANCH arcpatch-D24443_2 REVISION DETAIL https://phabricato

D24443: Add a plugin system

nicolasfella planned changes to this revision. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, fbampaloukas, dcaliste, dvas

D28834: Add metadata properties to calendar

nicolasfella updated this revision to Diff 80150. nicolasfella added a comment. - default to ReadWrite - rename icon to iconname to reflect that it's just the name REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28834?vs=80140&id=80150 BRANCH pro

D28834: Add metadata properties to calendar

nicolasfella marked an inline comment as done. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil

D25443: [chmodjob] Port away from QLinkedList

nicolasfella edited the summary of this revision. REPOSITORY R241 KIO BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D19913: [plasma-desktop] make it compiles without foreach

nicolasfella added a comment. The title says plasma-desktop, but this is plasma-framework? REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: nicolasfella, broulik

D25443: [chmodjob] Port away from QLinkedList

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e18ae3ea52dc: [chmodjob] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=80139&id=80187 REVISION DETAIL

D28831: Add note about porting loadMimeTypeIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon (authored by nicolasfella). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28831?vs=80128&id=80186 REVISI

D26034: Replace KLocalSocket with QLocalSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26034?vs=71642&id=80188 REVISION DETAIL

D28851: Mark KStatusBarOfflineIndicator as deprecated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Conceptually it doesn't really belong to KIO and KTorrent wa

D28851: Mark KStatusBarOfflineIndicator as deprecated

nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28851 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D17805: Allow specifying multiple mimetypes as constraints

nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17805 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80197. nicolasfella added a comment. - Update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=72413&id=80197 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES s

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80199. nicolasfella added a comment. - Fix update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=80197&id=80199 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella planned changes to this revision. nicolasfella added a comment. Seems like I missed some usages REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28851: Mark KStatusBarOfflineIndicator as deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as deprecated (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28851?vs=80190&id=80201 REVISION

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

Hi, this looks like a simple prison build failure to me. However, I cannot reprocuce this with the binary factory container and the current Prison Android CI builds is blue. There is a single red Android build in the Prison CI history (https://build.kde.org/job/Frameworks/ job/prison/job/kf5-qt

D28020: New class ProcessLauncherJob in KIOGui

nicolasfella added a comment. IIRC startup notification is still a big question mark in Wayland, but other Plasma devs know better REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28020 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: jbbgameich, kde-

D22701: [kfileutils] Add isExecutableFile from KRun

nicolasfella abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22701 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

This revision was automatically updated to reflect the committed changes. Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by nicolasfella). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28805?vs=80044&id=80640 REVISION DETAIL http

D29020: Add example/test application

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The purpose of this is twofold. It serves as a code example

D29020: Add example/test application

nicolasfella updated this revision to Diff 80685. nicolasfella added a comment. - Add license header REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29020?vs=80684&id=80685 BRANCH example REVISION DETAIL https://phabricator.kde.org/D29020 AFFEC

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 AFFECTED FILES sr

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, Plasma, broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik

D29079: android: include the architecture on the apk name

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks, nicolasfella Cc: vkrause, kde-frameworks-devel, kde-buildsystem, LeGa

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH useconsistentlyconfigfile REVISION DETAIL https://phabricator.kde.org/D29269 To: kossebau, #frameworks, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cbl

D26605: Remove fallback to KPassivePopup

nicolasfella abandoned this revision. nicolasfella added a comment. In favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26605 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblac

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella abandoned this revision. nicolasfella added a comment. I favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, mi

D29323: Handle multi-line and rich-text notifications on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29336: Remove galago from method/variable naming

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY With D29021 the fallba

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella added a dependent revision: D29336: Remove galago from method/variable naming. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, mi

D29335: Implement notification grouping on Android

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Haven't tested it, but the code looks sensible INLINE COMMENTS > NotifyByAndroid.java:171 > +Notification.Builder builder; > +if (Build.VERSION.SDK_INT >= 26) {

D29335: Implement notification grouping on Android

nicolasfella added inline comments. INLINE COMMENTS > vkrause wrote in NotifyByAndroid.java:171 > That seems counter-productive to me, as the Android API documentation always > speaks about API level numbers, so you'd need to do an additional translation > to/from the letters in your head. So f

D29342: Implement support for notification urgency on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29342 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29339: Implement updating of notifications on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When an icon isn't found within a theme we are supposed to l

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a replacement for CloseOnWidgetActivated that opera

D29021: Remove checks for notification service and fallback to KPassivePopup

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a5f0b1f7c812: Remove checks for notification service and fallback to KPassivePopup (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > Generally +1 > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? I'll ta

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? lol, turns out that doesn

D29405: [PoC] Make notifications work without a notifyrc file

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY In KNotificationManager when reading the actions d

D29405: [PoC] Make notifications work without a notifyrc file

nicolasfella added a comment. We want to phase out notifyrc files for several reasons: - They are an overkill for many simple use cases - A common pitfall when using KNotifications are missing or incorrect notifyrc files - Most of the information in there is duplicate/overridden at ru

  1   2   3   4   5   6   7   8   9   >