Re: Review Request 126161: OS X housekeeping

On November 27, 2015 01:02:31 PM Alexander Richardson wrote: > Has anyone done measurements on a recent system? Does it give any > noticable benefit? I have not, nor are my machines good representations. I don't think considering machines with 2G of memory with older processors to be out of line

Review Request 126555: Remove unused variable in KConfigPrivate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126555/ --- Review request for KDE Frameworks and Matthew Dawson. Repository

Review Request 126556: Ensure group is unescaped properly in kconf_update.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/ --- Review request for KDE Frameworks and Matthew Dawson. Repository

Re: Review Request 126556: Ensure group is unescaped properly in kconf_update.

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit 55bf90ff787f4e84947a5df833f66082e54016df by Matthew Dawson to branch master. Repository: kconfig Description --- During a kconf_update run, an invalid group name may be

Re: Review Request 126555: Remove unused variable in KConfigPrivate

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit df3440f328405623de927595b4555e06600d5626 by Matthew Dawson to branch master. Repository: kconfig Description --- This seems to be left over from KDE 3.5 times, and isn&#

Re: kconfig question

On Friday, January 15, 2016 9:46:00 AM EST Boudewijn Rempt wrote: > I noticed that krita on windows wrote its kritarc to Roaming\local\ or > Local\local instead of Roaming\krita\kritarc, and I was wondering why that > was. I now think it's because KConfig's default is to write to > GenericConfigLoc

Re: kconfig question

On Monday, January 18, 2016 8:53:22 AM EST Boudewijn Rempt wrote: > On Sun, 17 Jan 2016, Matthew Dawson wrote: > > It appears this is the desired behaviour. On most platforms, > > GenericConfigLocation and ConfigLocation are the same things, except > > Windows. Acco

Re: kconfig question

On Saturday, January 23, 2016 11:54:56 AM EST David Faure wrote: > On Monday 18 January 2016 10:28:18 Matthew Dawson wrote: > > On Monday, January 18, 2016 8:53:22 AM EST Boudewijn Rempt wrote: > > > On Sun, 17 Jan 2016, Matthew Dawson wrote: > > > > It appears this

Re: kconfig question

On Wednesday, January 27, 2016 10:32:50 AM EST Boudewijn Rempt wrote: > On Sat, 23 Jan 2016, David Faure wrote: > > (I don't mean "it's called KConfig" ;-) I mean what does the code using > > it, look like? I think this needs some debugging to find out where this > > "local" string comes from) >

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

erated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review93920 --- On March 22, 2016, 11:23 a.m., Sandro Knauß wrote: > > --- > This is an automatica

Re: Review Request 127462: Add support for get QStandardPaths locations.

e. On non-unix platforms, we shouldn't be using those variables as they have their own standard we should integrate against. - Matthew Dawson On March 27, 2016, 10:22 a.m., Sandro Knauß wrote: > > --- > This is

Re: Review Request 127462: Add support for get QStandardPaths locations.

> On March 28, 2016, 1:39 a.m., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt han

Re: Review Request 127462: Add support for get QStandardPaths locations.

llback strategy if the environment variable is not set. They instead map to a location from QStanardPaths. They are: docs/options.md (line 96) <https://git.reviewboard.kde.org/r/127462/#comment64059> Nitpick: s/QStandardsPath/QStandardPaths/ - Matthew Dawson On March 28, 201

Re: Review Request 127765: RFC: Cache global config files

do that in the first place anyways. - Matthew Dawson On April 27, 2016, 12:14 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 127813: Process paths just once

have no problem taking it. - Matthew Dawson On May 4, 2016, 9:02 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127948: Avoid skipping KAuthorized check

for this behaviour? Otherwise looks good to go. - Matthew Dawson On May 17, 2016, 3:57 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127948: Avoid skipping KAuthorized check

it is testing TryExec in general, which is being tested above. That name is hopefully a little more descriptive of the issue under test. - Matthew Dawson On May 19, 2016, 4:17 p.m., David Edmundson wrote: > > --- > This is a

Taking over maintainer role for KConfig/KDNSSD

Hi all, Just to let everyone know, I'm taking over the role of maintainer for both KConfig and KDNSSD. I'm most contactable at this email address ( matt...@mjdsystems.ca ). I'm usually idling on IRC with a nick of MJD, but I'm not always watching IRC. I'll do my best to watch over the framew

Re: Taking over maintainer role for KConfig/KDNSSD

On February 6, 2014 12:12:18 PM Alex Merry wrote: > On 06/02/14 07:38, Matthew Dawson wrote: > > I'll do my best to watch over the frameworks, but I'm not sure how much > > I'll be able to push them forward in the near future. At the very least > > I'l

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

On February 23, 2014 11:15:47 AM David Faure wrote: > Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as > returned by config(). > I had thought that when dealing with smart pointers, one should in general always pass around the smart pointer and not the raw pointer behind it.

Re: KDNSSD merge

On March 3, 2014 12:51:10 AM Albert Astals Cid wrote: > > I wasn't following the discussion. Can anyone summarize how 4.x are releases > affected? > > Thanks! > > Albert The kdnssd repository in the kdenetwork module would be renamed to zeroconf- ioslave, and the kdnssd-framework repository woul

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what h

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

, the default from KSharedConfig::openConfig() is used - Matthew Dawson On March 10, 2014, 4:36 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > <https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990> > > > > Also, can you change the documentation for KCoreConfigSke

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52913 --- Ship it! Ship It! - Matthew Dawson On March 13, 2014, 4

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > <https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990> > > > > Also, can you change the documentation for KCoreConfigSke

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what h

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what h

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what h

Re: Review Request 116845: Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

https://git.reviewboard.kde.org/r/116845/#comment37410> Since we are modifying this function, can you also kill this line please? - Matthew Dawson On March 16, 2014, 7:08 p.m., David Faure wrote: > > --- > This is an automa

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what h

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

> On March 16, 2014, 11:10 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.h, line 1055 > > <https://git.reviewboard.kde.org/r/116845/diff/1/?file=254551#file254551line1055> > > > > I can't find any instances (lxr.kde.org returns way too

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

rest can be done later. If you prefer, I'll revert the DelayedParsing commit after you commit this. - Matthew Dawson On March 17, 2014, 7:17 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. T

Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

pass. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

b3bcb Diff: https://git.reviewboard.kde.org/r/117010/diff/ Testing --- Unit tests continue to pass. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117486: Rewrite kiosk documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117486/#review55422 --- Ship it! Ship It! - Matthew Dawson On April 10, 2014, 12

Re: Review Request 117989: Store app config file in ~/.config//rc

be made later. - Matthew Dawson On May 4, 2014, 2:32 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Deprecation Defines

Hi all, I was looking into my frameworks, to prepare them for the 5.0. One thing was looking into was the deprecation defines. In KConfig, there are a couple of defines to disable deprecated functions: - KDE_NO_DEPRECATED - KCONFIGCORE_NO_DEPRECATED - KCONFIGGUI_NO_DEPRECATED Where KDE_NO_D

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118039/#review58433 --- Ship it! Excellent. Thanks for the patch! - Matthew Dawson

Re: Review Request 118332: Update usage of QVariant::type() for Qt5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118332/#review58506 --- Ship it! Ship It! - Matthew Dawson On May 26, 2014, 2:38

Re: Review Request 118339: Update usage of QVariant::type() for Qt5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118339/#review58533 --- Ship it! Ship It! - Matthew Dawson On May 26, 2014, 11:36

Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

eLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 Diff: https://git.reviewboard.kde.org/r/118340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel ma

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

On May 27, 2014 07:53:03 AM Marko Käning wrote: > On 27 May 2014, at 07:29 , Ben Cooksley wrote: > > Please try the following syntax instead. > > Note that I recommend you override this in > > config/build/darwin-mavericks.cfg instead to ensure all CMake projects > > on OS X are affected by it. >

Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

ild.kde.org/job/kdelibs4support_master_qt5/203/ Diffs - src/kdecore/kconfiggroup_kurl.h 4d7059dba68aff65eb8c0952ccb83d8cc7f35383 Diff: https://git.reviewboard.kde.org/r/118359/diff/ Testing --- Tests pass. Thanks, Matthew Dawson ___ Kde-f

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #203

On May 27, 2014 04:03:03 PM Mark Gaiser wrote: > I looked at this issue and it is introduced by commit: > 5f4dc2973f10cd44b2c70680fee72dd8fc545d2f in kconfig. > Belonging to this review request: > https://git.reviewboard.kde.org/r/118039/ It removes readCheck and > writeCheck. > > I don't know wha

Re: Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

--- Tests pass. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

ill do this, wasting effort. - Matthew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58731 ------- On May 2

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58733 ----------- On May 27, 2014, 1:27 a.m., Matthew Dawson wrote: > > --- >

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

18340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118458: Fix KDirWatch to act more reliably against various backends.

s as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

ui/kconfigloader.cpp 1dd9e7fc44a367165fedc2e7760c8b524ecd210e src/kconfig_compiler/kconfig_compiler.cpp 28b151c579c2c40e118b3b738a1e6ac81e461b3e Diff: https://git.reviewboard.kde.org/r/118489/diff/ Testing --- Unit tests still pass, regardless of whether or not deprecated features are enabled. Tha

Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

ggestion and just make it inline and return false. - Matthew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59066 --- On Ju

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

rg/r/118489/diff/1/?file=277677#file277677line170> > > > > Q_DECL_OVERRIDE? Will add. - Matthew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/#review59060

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

second call should pass "created(QString)" rather > > than "deleted(QString)". Copy and paste errors are the worst ... - Matthew --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

de.org/r/118458/diff/ Testing --- Unit tests all pass now with gamin. Using FAM, one test fails as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

Matthew Dawson. Changes --- New version, taking into account all comments. I'd appreciate it if someone can have a quick look over the comment to verify it makes sense. Summary (updated) - Properly mark ServiceBrowser::isRunning as deprecated. Repository: k

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Repository: kdnssd Description --- Properly mark ServiceBrowser::isRunning as deprecated. Fix the @deprecated notation to be correct. Also, make the function a simple inline function that always returns false

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

18458/diff/ Testing --- Unit tests all pass now with gamin. Using FAM, one test fails as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-fra

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

18458/diff/ Testing --- Unit tests all pass now with gamin. Using FAM, one test fails as described above, but I've confirmed the daemon itself is causing the issue. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-fra

Re: Jenkins build became unstable: kcoreaddons_master_qt5 #104

On June 6, 2014 03:36:43 PM KDE CI System wrote: > See I've been trying to figure out what caused this issue, but the test passes perfectly on my local systems. Is there any information on what the KDE CI runs for the tests, for insta

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

.cpp <https://git.reviewboard.kde.org/r/118564/#comment41428> Just to be safe, can you please save + restore the previous default? - Matthew Dawson On June 6, 2014, 7:43 a.m., Martin Gräßlin wrote: > > --- > This is an automatically

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 7:21 a.m., John Layt wrote: > > src/core/kconfig.cpp, line 98 > > > > > > The bcp47Name() is a complicated beast that could add lots of other > > bits on like script to use, etc. I would stick

Re: Jenkins build became unstable: kcoreaddons_master_qt5 #104

On June 7, 2014 04:14:20 PM Alex Merry wrote: > On 07/06/14 01:59, Matthew Dawson wrote: > > On June 6, 2014 03:36:43 PM KDE CI System wrote: > >> See <http://build.kde.org/job/kcoreaddons_master_qt5/104/changes> > > > > I've been trying to figure out wh

Review Request 118612: Fix KDirWatch's unit tests on certain file system.

Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

rwatch.cpp 7da1fdba8cd1a2e6a7d5bf9cef999d50b44ebf99 Diff: https://git.reviewboard.kde.org/r/118612/diff/ Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailin

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 7, 2014, 12:33 a.m., Matthew Dawson wrote: > > autotests/kconfigtest.cpp, line 930 > > <https://git.reviewboard.kde.org/r/118564/diff/3/?file=279334#file279334line930> > > > > Similarly, can you just change the config object's locale to somet

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

de.org/r/118564/#comment41675> Whitespace - Matthew Dawson On June 11, 2014, 2:54 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

rwatch.cpp 7da1fdba8cd1a2e6a7d5bf9cef999d50b44ebf99 Diff: https://git.reviewboard.kde.org/r/118612/diff/ Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel ma

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

iff: https://git.reviewboard.kde.org/r/118612/diff/ Testing --- Unit tests all pass on all four backends (FAM only tested against gamin) Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.o

Re: Review Request 118739: Make KSharedConfig thread-safe

re, when the T must be GlobalSharedConfigList? Why not just put the logic in globalSharedConfigList? src/core/ksharedconfig.cpp <https://git.reviewboard.kde.org/r/118739/#comment42038> Can you also please document the new behaviour of openConfig, that each instance is thread specific?

Re: Review Request 118692: Fix reading of entries for language/country combinations

therwise fine with the replacements. src/core/kconfigdata.h <https://git.reviewboard.kde.org/r/118692/#comment42056> Another Q_NULLPTR src/core/kconfigini.cpp <https://git.reviewboard.kde.org/r/118692/#comment42057> Another Q_NULLPTR. - Matthew Dawson On June 16, 201

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 17, 2014, 6:50 p.m., Matthew Dawson wrote: > > src/core/kconfigdata.h, line 206 > > <https://git.reviewboard.kde.org/r/118692/diff/2-3/?file=280489#file280489line206> > > > > Another Q_NULLPTR > > Martin Gräßlin wrote: > sorry

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 18, 2014, 3:04 a.m., Oswald Buddenhagen wrote: > > i don't see that you are proactively excluding the @modifier. it would seem > > that it's effectively part of the country, and the test works only because > > it's expected to fall back to de instead of de_AT anyway. > > > > there is

Re: Review Request 118739: Make KSharedConfig thread-safe

> On June 17, 2014, 12:50 p.m., Matthew Dawson wrote: > > src/core/ksharedconfig.cpp, line 52 > > <https://git.reviewboard.kde.org/r/118739/diff/1/?file=28#file28line52> > > > > Why create a template function here, when the T must be > > Global

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 17, 2014, 6:50 p.m., Matthew Dawson wrote: > > autotests/kdesktopfiletest.cpp, line 88 > > <https://git.reviewboard.kde.org/r/118692/diff/2-3/?file=280487#file280487line88> > > > > Please add a test for both: > > - when both the c

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60621 --- Ship it! Ship It! - Matthew Dawson On June 20, 2014, 4:56

Re: Review Request 118739: Make KSharedConfig thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60681 --- Ship it! Ship It! - Matthew Dawson On June 21, 2014, 5:37

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

5/#comment42593> As this seems to be mainly an optimization to ensure the config is not unnecessarily deleted, I think it makes sense to still run this on alternate threads. - Matthew Dawson On June 27, 2014, 6:31 p.m., David Faure wrote: > > --

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

> On June 28, 2014, 11:31 p.m., Matthew Dawson wrote: > > I'm not sure about moving the warning about immutable files to only happen > > on the main thread, as it is possible that an application may use it > > KSharedConfig on an alternate thread only. >

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

patch, feel free to commit it once fixed. src/core/ksharedconfig.cpp <https://git.reviewboard.kde.org/r/118985/#comment42692> Whitespace. - Matthew Dawson On June 29, 2014, 9:55 a.m., David Faure wrote: > > ---

Re: Review Request 119074: Fix reading of XDG style semicolon separated lists with escaped '; '

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119074/#review61417 --- Ship it! Ship It! - Matthew Dawson On July 1, 2014, 2:35

Re: Deprecation Defines

On July 7, 2014 11:39:38 PM David Faure wrote: > On Monday 05 May 2014 13:14:07 Alex Merry wrote: > > On 05/05/14 07:27, Matthew Dawson wrote: > > > Hi all, > > > > > > I was looking into my frameworks, to prepare them for the 5.0. One > > > thi

Re: Deprecation Defines

On July 8, 2014 11:20:37 AM David Faure wrote: > > > > I have a patch sitting in review for kconfig. > > What's the RR number? I can't see it in my k-f-d folder. 118489. It already has comments on it, with the decision that policy needs to be figured out before it is pushed. > > > I'm waiting

Re: Deprecation Defines

On July 8, 2014 10:50:18 PM David Faure wrote: > > I agree. I figured the first step was to come up with a draft policy and > > post to the list for comments, and as I said I'm trying to get a new > > contributer to help (they have lots of experience writing documents, and > > have a strong techni

Review Request 119577: Allow translations to have context again.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119577/ --- Review request for KDE Frameworks and Matthew Dawson. Bugs: 337979

Re: Review Request 119577: Allow translations to have context again.

it.reviewboard.kde.org/r/119577/#review63677 --- On Aug. 2, 2014, 1:07 p.m., Matthew Dawson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 119577: Allow translations to have context again.

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Bugs: 337979 https://bugs.kde.org/show_bug.cgi?id=337979 Repository: kconfig Description --- Allow translations to have context again. Switch to using QT_TRANSLATE_NOOP3 so that context information can be

Re: Review Request 119991: Use Juvia to add comments on the API class pages

(or other interested parties) to watch their framework's comments, to be on the look out for any interesting conversation? Users may make comments about the API's that would be good to follow up on. Thanks for looking into this! - Matthew Dawson On Aug. 29, 2014, 10:16 a

Re: Review Request 119997: Add documentation to KConfig::sync()

accept either a KConfig or a KConfigGroup and be able load/persist its settings would be good. - Matthew Dawson On Aug. 29, 2014, 5:42 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 119997: Add documentation to KConfig::sync()

> On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used ou

Re: Review Request 119997: Add documentation to KConfig::sync()

> On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used ou

Re: Review Request 119991: Use Juvia to add comments on the API class pages

> On Sept. 8, 2014, 6:22 p.m., Ben Cooksley wrote: > > What is the status of this? Is there anything blocking it being shipped and > > made available on api.kde.org? > > Denis Steckelmacher wrote: > It works locally, so I'm just waiting for a ship-it or other comments :-) > > Aleix Pol Gon

Re: Review Request 119997: Add documentation to KConfig::sync()

> On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used ou

Re: Review Request 119991: Use Juvia to add comments on the API class pages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/#review66315 --- Ship it! Ship It! - Matthew Dawson On Aug. 29, 2014, 10

Re: Review Request 119991: Use Juvia to add comments on the API class pages

r comments :-) > > Aleix Pol Gonzalez wrote: > Let's see if we can get this discussed in the KF5 BoF today. > > Aleix Pol Gonzalez wrote: > I kind of forgot... :( > > Anyway, +1 for me. If there are no reasons to keep postponing it, I'd say > let

Re: Review Request 119991: Use Juvia to add comments on the API class pages

On September 12, 2014 03:19:13 AM Ben Cooksley wrote: > > On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: > > Matthew Dawson wrote: > > I don't think upstream would be happy with the patch, as it hijacks > > the moderator emails (which should link to the ad

Re: Review Request 120283: make KConfigLoader more predictable by exposing a getter to KConfig's OpenFlags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120283/#review66958 --- Ship it! Ship It! - Matthew Dawson On Sept. 19, 2014, 7

  1   2   >