Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

ework integration. In my opinion framework integration should only be about Plasma. I'll start a new thread about it. - Martin Gräßlin On Nov. 29, 2015, 8:53 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generat

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

settings, why don't follow what linux distros do? That is ship some default configuration interface. For inspiration check e.g. kubuntu-default-settings. - Martin Gräßlin On Dec. 1, 2015, 9:29 p.m., René J.V. Bertin wrote: > > --- &

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

g/r/126198/#comment60946> please use the newer and easier endif() variant. - Martin Gräßlin On Dec. 1, 2015, 9:29 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the appl

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-setti

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

/#comment60989> why does the mac platform want to setupXcbFlush? - Martin Gräßlin On Dec. 3, 2015, 10:51 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/CMakeLists.txt, lines 67-69 > > <https://git.reviewboard.kde.org/r/126198/diff/6/?file=420926#file420926line67> > > > > don't make thie an elsif, just an if. It's not an e

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/main_mac.cpp, line 45 > > <https://git.reviewboard.kde.org/r/126198/diff/6/?file=420937#file420937line45> > > > > why does the mac platform want to setupXcbFlush? > > René J.V.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

tps://git.reviewboard.kde.org/r/126198/#comment61002> same here src/platformtheme/kdemactheme.mm (line 188) <https://git.reviewboard.kde.org/r/126198/#comment61001> do we still need that? I thought 5.3 is the minimum version anyway - Martin Gräßlin On Dec. 4, 2015, 2:05 p.m., René

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > <https://git.reviewboard.kde.org/r/126198/diff/6/?file=420929#file420929line41> > > > > why did you add the virtual? The methods are marked as Q_DECL

Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

/kstartupinfo.cpp a97b8b5416ca67a083960a76093933fb098327a5 src/kstartupinfo.h dfcd42797d887ca6d43161f8c3b767ad436e5116 Diff: https://git.reviewboard.kde.org/r/126312/diff/ Testing --- autotest still passes Thanks, Martin Gräßlin ___ Kde-frameworks-devel

Review Request 126313: Use an xcb for interaction with KStartupInfo

sting --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126314: Port klauncher to xcb

://git.reviewboard.kde.org/r/126314/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

e same. Similar one doesn't need the QWidget usage as QWindow is already there. - Martin Gräßlin On Dec. 13, 2015, 2:54 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

tps://git.reviewboard.kde.org/r/126198/#comment61219> this looks like a not needed debug statement, same in dtor and loadSettings and KFontSettings - Martin Gräßlin On Dec. 12, 2015, 7:08 p.m., René J.V. Bertin wrote: > > ---

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 60d4037f34b67570205d3aaaec349c3ae61f6aa2 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- Adds for each of sendStartup, sendChange, sendFinish an

Re: kdeinit freezes on Wayland in OOM protection

Am 2015-12-15 03:20, schrieb Michael Pyne: On Mon, December 14, 2015 16:07:38 Martin Graesslin wrote: On Friday, November 27, 2015 1:05:26 PM CET Michael Pyne wrote: > On Thu, November 26, 2015 13:16:04 Martin Graesslin wrote: > > we are facing a problem during the startup of Plasma on Wayland.

Re: kdeinit freezes on Wayland in OOM protection

Am 2015-12-15 08:33, schrieb Martin Gräßlin: Am 2015-12-15 03:20, schrieb Michael Pyne: On Mon, December 14, 2015 16:07:38 Martin Graesslin wrote: On Friday, November 27, 2015 1:05:26 PM CET Michael Pyne wrote: > On Thu, November 26, 2015 13:16:04 Martin Graesslin wrote: > > we are

Review Request 126362: Allow timeout in reset_oom_protection while waiting for SIGUSR1

--- Seems to not work correctly yet as I don't hit the timeout condition with the broken kwin_wayland. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

--- Compiz not available on Debian, cannot test. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

9d287043c24894ca3c29c439c7939b139da055e8 Diff: https://git.reviewboard.kde.org/r/126397/diff/ Testing (updated) --- User in referenced bug report tested it, works. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

enerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/#review89648 ------- On Dec. 17, 2015, 10:21 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

tps://git.reviewboard.kde.org/r/126324/#comment61408> That doesn't match the method name. It's saveWindowSize, not saveWindowGeometry. It's highly unexpected that saveWindowSize saves the position. If you want that: please introduce a new saveWindowGeometry method. - Martin

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > <https://git.reviewboard.kde.org/r/126324/diff/4/?file=422749#file422749line38> > > > > That doesn't match the method name. It's saveWindowSiz

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

423> Q_NULLPTR - Martin Gräßlin On Dec. 17, 2015, 7:40 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > <https://git.reviewboard.kde.org/r/126198/diff/10/?file=424265#file424265line45> > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I

Re: Review Request 126417: don't rely on char* to QString implicit conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89717 --- Ship it! Ship It! - Martin Gräßlin On Dec. 18, 2015, 3:20

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review89720 --- Looks good to me. - Martin Gräßlin On Dec. 18, 2015, 7:30

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:36 p.m., Sebastian Kügler wrote: > > Nice. > > > > I agree with Aleix that the env var would be good to have documented. (Is > > that even English?) But then, where? as an idea check: https://community.kde.org/KWin/Environment_Variables - Martin --

Re: Review Request 126587: Add option to build with gcov support

> On Jan. 2, 2016, 12:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? > > Dāvis Mosāns wrote: > I don't know... I based this on KWin > https://quickgit.kde.org/?p=kwin.git&a=blob&hb=master&f=CMakeLists.txt#l249 the check in KWin predates the one in ecm and as Aleix

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90522 --- anyone tested this on an "affected system"? - Mart

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

> On Jan. 2, 2016, 10:59 a.m., David Edmundson wrote: > > src/properties.h, line 215 > > > > > > adding an enum value in the middle breaks API > > Kai Uwe Broulik wrote: > where can I place it? the last entr

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > <https://git.reviewboard.kde.org/r/126324/diff/4/?file=422749#file422749line38> > > > > That doesn't match the method name. It's saveWindowSiz

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > <https://git.reviewboard.kde.org/r/126324/diff/4/?file=422749#file422749line38> > > > > That doesn't match the method name. It's saveWindowSiz

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > <https://git.reviewboard.kde.org/r/126324/diff/4/?file=422749#file422749line38> > > > > That doesn't match the method name. It's saveWindowSiz

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > <https://git.reviewboard.kde.org/r/126324/diff/4/?file=422749#file422749line38> > > > > That doesn't match the method name. It's saveWindowSiz

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > <https://git.reviewboard.kde.org/r/126324/diff/4/?file=422749#file422749line38> > > > > That doesn't match the method name. It's saveWindowSiz

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

eTime? My first thought would have been Solid, so I'm interested in the reasoning. - Martin Gräßlin On Jan. 6, 2016, 8:17 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To re

Re: Draft split for qpt plugin from frameworkintegration

Am 2016-01-06 22:18, schrieb Albert Astals Cid: El Friday 18 December 2015, a les 10:03:39, Martin Graesslin va escriure: On Thursday, December 17, 2015 5:48:47 PM CET Martin Graesslin wrote: > On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > > On Wed, Dec 16, 2015 at 4:12 PM, Ma

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90869 --- Ship it! Ship It! - Martin Gräßlin On Jan. 10, 2016, 10

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

better who is responsible for cleanup and how the Inhibition is released. - Martin Gräßlin On Jan. 6, 2016, 8:17 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 126717: Fix DBus service name of polkit agent

r State: no Map State: IsViewable Override Redirect State: no Corners: +704+318 -1941+318 -1941-398 +704-398 -geometry 555x364+704+318 Observe: WM_TRANSIENT_FOR is set correctly. Thanks, Martin Gräßlin ___ Kde-frameworks-dev

Re: Review Request 126717: Fix DBus service name of polkit agent

marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 815ddf5628324ea550c01c701fe3b124b8a19762 by Martin Gräßlin to branch master. Repository: kauth Description --- It's nowadays org.kde.polkit-kde-authentication-ag

Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

f0d69c647f00728525ee78e946a938f270ddb300 Diff: https://git.reviewboard.kde.org/r/126723/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126724: Expose callingUser in HelperSupport if available

veId())); file.write("\n"); return ActionReply::SuccessReply(); } created the file /tmp/authtest with the following content: /home/martin martin 1000 Which matches my user. Thanks, Martin Gräßlin ___ Kde-frame

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

ply, visit: https://git.reviewboard.kde.org/r/126723/#review90956 ----------- On Jan. 12, 2016, 10:09 a.m., Martin Gräßlin wrote: > > --- > This is an automatically gen

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

eems to be > > quite common. > > So I am not sure about the best solution (bump dep upstream have it patched > > downstream, or just leave it the way it is and do not require a higher > > version number). > > Martin Gräßlin wrote: > I didn't even realize

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

eems to be > > quite common. > > So I am not sure about the best solution (bump dep upstream have it patched > > downstream, or just leave it the way it is and do not require a higher > > version number). > > Martin Gräßlin wrote: > I didn't even realize

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90970 ------- On Jan. 12, 2016, 10:09 a.m., Martin Gräßlin wrote: > > --- > This is an automatically

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

t. Diffs (updated) - core/polkitqt1-subject.h 4c7a22bae51a501f9aed2eadac0579baea174d0d core/polkitqt1-subject.cpp f0d69c647f00728525ee78e946a938f270ddb300 Diff: https://git.reviewboard.kde.org/r/126723/diff/ Testing --- Thanks, Mart

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

> On Jan. 11, 2016, 1:05 p.m., Martin Gräßlin wrote: > > src/inhibition.h, line 30 > > <https://git.reviewboard.kde.org/r/126650/diff/1/?file=428572#file428572line30> > > > > Maybe an explicit InhibitLockScreen? > > Martin Klapetek wrote: > Ca

Re: Review Request 126724: Expose callingUser in HelperSupport if available

ng to upload again to RB. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review90971 --- On Jan. 12, 20

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

marked as submitted. Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and Matthias Klumpp. Changes --- Submitted with commit d1bcbbe315dab07bef1ddb9c6f7335f88e0ebdbd by Martin Gräßlin to branch master. Repository: polkit-qt-1 Description --- This adds a new

Making polkit-qt-1 a tier1 framework

Hi all, I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. Reasons are: * kdesupport is basically what became tier1 in frameworks * it's used by other frameworks, e.g. KAuth (tier 2) and in kde/workspace * polkit-qt-1 is currently in a not really released state (last rel

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

9d287043c24894ca3c29c439c7939b139da055e8 Diff: https://git.reviewboard.kde.org/r/126397/diff/ Testing --- User in referenced bug report tested it, works. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Making polkit-qt-1 a tier1 framework

Am 2016-01-14 18:40, schrieb David Edmundson: On Thu, Jan 14, 2016 at 12:20 PM, Martin Gräßlin wrote: Hi all, I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. Reasons are: * kdesupport is basically what became tier1 in frameworks * it's used by other frameworks

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

flag. My suggestion is that we verify it's a bug, locate it and fix it and don't work around it. To verify that it is a bug: xprop and xwininfo of all three windows are needed. - Martin Gräßlin On Jan. 15, 2016, 1

Review Request 126758: Drop support for building with Qt 4

/126758/diff/ Testing --- compiles Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

> On Jan. 20, 2016, 2:58 a.m., Aleix Pol Gonzalez wrote: > > src/platforms/xcb/kwindowsystem_p_x11.h, line 147 > > > > > > Should this (maybe) be static? Or rather Q_GLOBAL_STATIC? > > > > Or we'll just

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126818/#review91362 --- Ship it! Ship It! - Martin Gräßlin On Jan. 20, 2016

Re: Review Request 126813: Fix build with older polkit

> On Jan. 19, 2016, 5:22 p.m., David Jarvie wrote: > > The symbol `polkit_system_bus_name_get_user_sync` doesn't exist in the > > Debian stable polkit libraries (it doesn't exist in the polkit-1 package > > sources or Debian patches either). The Debian stable package version is > > 0.105-8. >

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

e 160) <https://git.reviewboard.kde.org/r/126870/#comment62571> why bind it to compositingActive? - Martin Gräßlin On Jan. 24, 2016, 4:20 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-m

Re: Review Request 126813: Fix build with older polkit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review91567 --- Ship it! Ship It! - Martin Gräßlin On Jan. 21, 2016, 5

Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 527c3490a867b7a0a22a45a8d5d7a706578f9503 by Martin Gräßlin to branch master. Repository: kinit Description --- By changing to xcb we can use NETRootInfo to get the current

Re: Review Request 126314: Port klauncher to xcb

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit b958641f5f015e2452a3916a9b19e9f5caadc44a by Martin Gräßlin to branch master. Repository: kinit Description --- Port klauncher to xcb Diffs - src/klauncher

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

ession. ;) > > Andreas Hartmetz wrote: > Same here. sorry about that, I'm on it. - Martin ----------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/#review91596

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

gt; > ) > > at /home/lb/Coding/KDEsrc/kinit/src/kdeinit/kinit.cpp:643 > > #7 0x008e559d in () > > #8 0x in () > > ``` > > > > I had to revert it or kdeinit would crash and prevent me from having a > > functional session

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

gt; > ) > > at /home/lb/Coding/KDEsrc/kinit/src/kdeinit/kinit.cpp:643 > > #7 0x008e559d in () > > #8 0x in () > > ``` > > > > I had to revert it or kdeinit would crash and prevent me from having a > > functional session. ;)

Review Request 126887: Fix crash if KWindowSystem::mapViewport is called without a QCoreApplication

.kde.org/r/126887/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

s long as you don't configure a shortcut on a QAction it won't actually start the runtime part. If the motivation is to ensure you don't need it on Krita on non-Linux: just don't ship the binary. You don't need it. - Martin Gräßlin On Jan. 26,

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > > Boudew

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

g/r/126895/#comment62624> should be RECOMMENDED in my opinion - Martin Gräßlin On Jan. 26, 2016, 7:25 p.m., Andre Heinecke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126887: Fix crash if KWindowSystem::mapViewport is called without a QCoreApplication

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9248b92eb24ea0fae4f372b7810c08a32bca8a28 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- NETRootInfo can be used without requiring a QCoreApplication. But there

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 27, 2016, 8:02 a.m., Martin Gräßlin wrote: > > Just in case that there is misunderstanding going on: > > > > > Global Shortcuts (we don't have kded so this won't work for us anyway) > > > > Global shortcut handling does not depend

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Review Request 126908: Change licence header from "Library GPL 2 or later" to "Lesser GPL 2.1 or later"

2e38889f6e4aaa1d2b6e98012a5e107a4511343e Diff: https://git.reviewboard.kde.org/r/126908/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 25, 2016, 9 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > <https://git.reviewboard.kde.org/r/126870/diff/2/?file=436482#file436482line160> > > > > why bind it to compositingActive? > > Anthony Fieroni w

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 25, 2016, 9 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > <https://git.reviewboard.kde.org/r/126870/diff/2/?file=436482#file436482line160> > > > > why bind it to compositingActive? > > Anthony Fieroni w

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 29, 2016, 9:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on someth

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

rs have the risk on clicking > > on something that doesn't work. > > > > Default global shortcuts set by apps won't work of course, but AFAICS this > > is done using KGlobalAccel API anyway, not kxmlgui API. So that's perfect > > IMHO, neither users or a

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e > transparent to hackers that if you do thomething with GlobalAccel "please > guard it". > > Aleix Pol Gonzalez wrote: > @boud, yes, I also thought about your RR, in fact I looked it up but > couldn't find it. > > Ok, maybe it's actuall

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

rs have the risk on clicking > > on something that doesn't work. > > > > Default global shortcuts set by apps won't work of course, but AFAICS this > > is done using KGlobalAccel API anyway, not kxmlgui API. So that's perfect > > IMHO, neither users or a

Re: Review Request 126908: Change licence header from "Library GPL 2 or later" to "Lesser GPL 2.1 or later"

marked as submitted. Review request for KDE Frameworks and Jonathan Riddell. Changes --- Submitted with commit 2e31bdda32788d3e27d031ebdcfe5ce428876ca3 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- Header taken from https://techbase.kde.org/Policies

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

ed is also adding a service watcher to check whether it becomes available later on. But I'd say that's outside the scope of this class. - Martin Gräßlin On Jan. 26, 2016, 7:13 p.m., Martin Klapetek wrote: > > --- > Thi

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

rs have the risk on clicking > > on something that doesn't work. > > > > Default global shortcuts set by apps won't work of course, but AFAICS this > > is done using KGlobalAccel API anyway, not kxmlgui API. So that's perfect > > IMHO, neither users or a

Re: Review Request 127004: WIP: OpenFileManagerWindowJob

d you please provide more info about the Startup Id. src/widgets/openfilemanagerwindowjob.h (line 109) <https://git.reviewboard.kde.org/r/127004/#comment62862> also here it would be useful to know what "asn" is - Martin Gräßlin On Feb. 7, 2016, 7:20

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

if enabled would not compile src/platforms/osx/kwindowsystem_macobjc.mm (line 447) <https://git.reviewboard.kde.org/r/126291/#comment63001> QObject() - Martin Gräßlin On Feb. 14, 2016, 5:44 p.m., René J.V. Bertin wrote: > >

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 15, 2016, 8:42 a.m., Martin Gräßlin wrote: > > Thanks for contributing the code, I'm very happy to see this happening! > > Sorry, that I cannot provide a good review as I'm not really into the OSX > > API, thus my review here might look a little bit nit

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

/klauncher/klauncher.h (line 274) <https://git.reviewboard.kde.org/r/127166/#comment63181> const QByteArray & - Martin Gräßlin On Feb. 24, 2016, 6:19 a.m., Xuetian Weng wrote: > > --- > This is an automatically generat

  1   2   3   4   5   6   7   8   9   10   >