Re: Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126088/#review88790 --- Ship it! Ship It! - Marco Martin On Nov. 16, 2015, 12:57

Review Request 126185: Make the KAppTemplate CMake module global

- kde-modules/KDETemplateMacro.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126185/diff/ Testing --- done some templates installed by plasma-framework Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 126185: Make the KAppTemplate CMake module global

ported to a place avaiable to all frameworks Diffs (updated) - kde-modules/KDETemplateMacro.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126185/diff/ Testing --- done some templates installed by plasma-framework Thanks, Marco Martin

Re: Review Request 126185: Make the KAppTemplate CMake module global

marked as submitted. Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter. Changes --- Submitted with commit 1e8e0da3eb475bb8b78baa54cb0c34b913c2dc5d by Marco Martin to branch master. Repository: extra-cmake-modules Description --- templates are very

Re: Review Request 126185: Make the KAppTemplate CMake module global

> kde-modules/KDETemplateMacro.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > --- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

commit the patch, I'll delete the macro from KAppTemplate and move > > all templates to the specific projects > > - I also should write a second macro, that tests the generated application > > - but since I started my Bachelor I completely run out off time :/ >

Re: Review Request 126226: kdetemplate_add_app_templates installs previews

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126226/#review89081 --- Ship it! Ship It! - Marco Martin On Dec. 3, 2015, 1:27

Re: Purpose as a KDE Framework

ible that $webservice would need some monster client library -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Purpose as a KDE Framework

comic applet. but i don't think scripted plugins can be added as an aftertought as the structure of the framework may be influenced by that (yeah, i know, dependencies, but my wet dream is to have those sharing scripts findable of ghns/kdelook and installable with kpackage) -- Marco Ma

Review Request 126246: Add test for dynamically changing file definitions

/packagestructuretest.h de2038e autotests/packagestructuretest.cpp 4784bfd Diff: https://git.reviewboard.kde.org/r/126246/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Scope of framework integration plugin?

; Opinions? +1 even more than that, I add that it may be specific of plasma*desktop* as in plasma mobile we may want it at least partly different (like an own mobile oriented file selection dialog) -- Marco Martin ___ Kde-frameworks-devel mailing list

Re: Purpose as a KDE Framework

> > of ghns/kdelook and installable with kpackage) > > I'll give scripted plugins some thought. > my suggestion is to try that before making it a framework, in case incompatible changes would be needed -- Marco Martin ___ Kde-f

Re: Review Request 126185: Make the KAppTemplate CMake module global

/diff/ Testing --- done some templates installed by plasma-framework Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

make it customizable by parameter tough - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89242 ------

Re: Review Request 126185: Make the KAppTemplate CMake module global

-framework Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

it.reviewboard.kde.org/r/126185/#review89275 ------- On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126246: Add test for dynamically changing file definitions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89312 --- ping? - Marco Martin On Dec. 4, 2015, 6:23 p.m., Marco

Re: Review Request 126246: Add test for dynamically changing file definitions

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit e3d27e00c6ad4428b59188058a10e1864f85 by Marco Martin to branch master. Repository: kpackage Description --- this, referred to https://git.reviewboard.kde.org/r/126244/ tests

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89452 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2015, 6:48

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

tps://git.reviewboard.kde.org/r/126324/#comment61227> we really can't add a dependency to QWidgets here. depending on qwidgets will make many potential interested project not able to use it - Marco Martin On Dec. 13, 2015, 1:54 p.m., René J.V. B

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

t you want in OSX nor what you want in GNOME or XFCE and yeah, probably not even in LXQt even in Plasma Mobile, we'll need a different QPT -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

take ${KDE_INSTALL_KTEMPLATESDIR} as default or would be mandatory to be passed by the caller? - Marco ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89388

Re: Review Request 126185: Make the KAppTemplate CMake module global

-framework Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

.org/r/126185/#review89391 --- On Dec. 15, 2015, 10:38 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126185/diff/ Testing --- done some templates installed by plasma-framework Thanks, Marco Martin

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

t/qml-plasmoid/qml-plasmoid.png PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126185/diff/ Testing --- done some templates installed by plasma-framework Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kd

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126185: Make the KAppTemplate CMake module global

Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

marked as submitted. Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter. Changes --- Submitted with commit 76377cdf5d0658672bea5cc84f1c7d5657b8aea2 by Marco Martin to branch master. Repository: extra-cmake-modules Description

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90303 --- Ship it! Ship It! - Marco Martin On Dec. 15, 2015, 3:24

Re: Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/#review90530 --- Ship it! Ship It! - Marco Martin On Dec. 31, 2015, 6:47

Review Request 126632: add a "Complementary" color scheme to kcolorscheme

d need for it to support this "complementary" area as well. Diffs - src/kcolorscheme.h 22bc21b src/kcolorscheme.cpp 427ffa4 Diff: https://git.reviewboard.kde.org/r/126632/diff/ Testing --- Thanks, Marco Martin ___ Kde-fram

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

follow the system color scheme, I would need for it to support this "complementary" area as well. Diffs (updated) - src/kcolorscheme.h 22bc21b src/kcolorscheme.cpp 427ffa4 Diff: https://git.reviewboard.kde.org/r/126632/diff/ Testing --- T

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90808 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2016, 7:11

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90871 --- ping? - Marco Martin On Jan. 5, 2016, 11:16 a.m., Marco

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

ay be useful to add then? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90886 --- On Jan. 5, 2

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

> On Jan. 11, 2016, 12:14 p.m., David Edmundson wrote: > > >Gwenview switches to a dark palette when in fullscreen mode for instance > > > > and how does this help solve that? There's no method to get a palette from > > a ColorSet > > Marco Martin wr

Re: Review Request 126740: Add a script for optimizing svgs

plasma-framework :p (mainly because git) what needs to happen is probably the compression to svgz to be done at build time and have all simple svgs in the repository - Marco Martin On Jan. 14, 2016, 3 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

(line 245) <https://git.reviewboard.kde.org/r/126742/#comment62190> Agree with David, clearActions() - Marco Martin On Jan. 14, 2016, 12:42 p.m., James Smith wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 71ddb9ff47a00cc17c70a877794405d251a9130c by Marco Martin to branch master. Repository: kconfigwidgets Description --- Since some releases, plasma-frameworks locally expands

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 25, 2016, 8 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126949: Remove Air and Oxygen themes

* maintain the Air theme - Marco Martin On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071

Re: Review Request 127088: Let KDocTools stay optional on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127088/#review92448 --- Ship it! Ship It! - Marco Martin On Feb. 16, 2016, 2

Re: Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126883/#review92668 --- Ship it! Ship It! - Marco Martin On Jan. 25, 2016, 2

Review Request 127191: KCompletionBox should *not* be a tooltip

icked Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

made the desired behavior when tooltip was picked Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

broken?? ok, i'm blind :p - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/#review92809 ------- On Feb

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92886 --- Ship it! Ship It! - Marco Martin On Feb. 28, 2016, 5

Re: Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/#review92893 --- Ship it! Ship It! - Marco Martin On Feb. 29, 2016

Re: Review Request 127223: Don't emit destroyedChanged(true) twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127223/#review93074 --- Ship it! Ship It! - Marco Martin On Feb. 29, 2016, 4

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

... - Marco Martin On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127268: Docs for IconItem

/iconitem.h (line 85) <https://git.reviewboard.kde.org/r/127268/#comment63496> Since is a property, just True if a valid icon is set. False otherwise without Returns? src/declarativeimports/core/iconitem.h (line 90) <https://git.reviewboard.kde.org/r/127268/#comment63497> Sam

Re: Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/#review93118 --- Ship it! Ship It! - Marco Martin On March 3, 2016, 6

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/#review93251 --- any updates? - Marco Martin On Feb. 26, 2016, 2:18 p.m

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

> On Feb. 26, 2016, 2:14 p.m., Thomas Lübking wrote: > > src/kcompletionbox.cpp, line 66 > > <https://git.reviewboard.kde.org/r/127191/diff/1/?file=445519#file445519line66> > > > > q->setAttribute(Qt::WA_X11NetWmWindowTypeCombo); // broken?? > >

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

marked as submitted. Review request for KDE Frameworks and kwin. Changes --- Submitted with commit a4aced126beb14adc539edcb21e2423dd82ab6b0 by Marco Martin to branch master. Repository: kcompletion Description --- KCompletionbox it's actually more of a combobox popup t

Re: Review Request 127345: Make it possible for an applet to offer a test object

tps://git.reviewboard.kde.org/r/127345/#comment63685> you don't really need this http://doc.qt.io/qt-5/qqmlengine.html#qmlEngine src/plasmaquick/appletquickitem.cpp (line 648) <https://git.reviewboard.kde.org/r/127345/#comment63686> who will be using this? from the shell? -

KWayland as framework

libraries, and it's a while we have a policy of abi stability for it. I think the library now is mature enough to be a framework (tier 1 as doesn't depend on other frameworks) there won't be abi incompatible changes for the foreseeable future, just additions. Opinions? c

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 12, 2016, 10:26 a.m., Sebastian Kügler wrote: > > src/plasma/private/packages.cpp, line 46 > > > > > > I'd just go for test.qml or perhaps even autotest.qml test.qml would be good if the abstract name

Re: Review Request 127345: Make it possible for an applet to offer a test object

"test.qml" as sebas already pointed out - Marco Martin On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 127345: Make it possible for an applet to offer a test object

tps://git.reviewboard.kde.org/r/127345/#comment63711> appletquickitem.h is now installed as a public header, <> include should be fixed somehow - Marco Martin On March 12, 2016, 3 p.m., Aleix Pol Gonzalez wrote: > > --

Re: Review Request 121575: FindEpoxy.cmake

two repos. This is the file coming from KWin Diffs - find-modules/Findepoxy.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121575/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

tps://git.reviewboard.kde.org/r/127405/#comment63857> they're installed headers, so i think it should be #include - Marco Martin On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

ply, visit: https://git.reviewboard.kde.org/r/127424/#review93716 --- On March 19, 2016, 8:56 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Review Request 127448: After installing a package, load it

g/r/127448/diff/ Testing --- autotest included Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127448: After installing a package, load it

76614a0 src/kpackage/private/packagejob_p.h acafa5e Diff: https://git.reviewboard.kde.org/r/127448/diff/ Testing --- autotest included Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

l. To reply, visit: > https://git.reviewboard.kde.org/r/127424/ > --- > > (Updated March 20, 2016, 12:06 p.m.) > > > Review request for KDE Frameworks, kdewin, kwin, and Marco Martin. > > > Repository: kcomple

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93888 --- Ship it! Ship It! - Marco Martin On Feb. 24, 2016, 11

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

> On March 23, 2016, 10:51 a.m., Marco Martin wrote: > > Ship It! (as in, ignore my comment about the option, I'm fine with the added option now) - Marco --- This is an automatically generated e-mail. To reply

Re: Review Request 127469: Use QQuickWidget for QML KCMs

random c++ code from plugins, we can't ensure this will not happen. - Marco Martin On March 23, 2016, 10:29 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review94145 --- Ship it! Ship It! - Marco Martin On March 16, 2016, 4

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94703 --- Ship it! Ship It! - Marco Martin On April 19, 2016, 3

Re: Review Request 127756: Remove platformtheme plugin

* it's a plugin, so it doesn't have bic issues - Marco Martin On April 27, 2016, 11:16 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 127764: warn about need for production data, skip tests that depend on them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127764/#review94906 --- Ship it! Ship It! - Marco Martin On April 27, 2016, 1

Review Request 127779: use system colors for monochrome icons

://git.reviewboard.kde.org/r/127779/diff/ Testing --- File Attachments dadel1.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-09c7a703a456__dadel1.png Thanks, Marco Martin ___ Kde-fram

Re: Review Request 127779: use system colors for monochrome icons

rc/kiconloader.cpp 75ab482 Diff: https://git.reviewboard.kde.org/r/127779/diff/ Testing --- File Attachments dadel1.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-09c7a703a456__dadel1.png Thanks, Marco Martin ___

Re: Review Request 127779: use system colors for monochrome icons

rc/kiconloader.cpp 75ab482 Diff: https://git.reviewboard.kde.org/r/127779/diff/ Testing --- File Attachments dadel1.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-09c7a703a456__dadel1.png Thanks, Marco Martin ___

Re: Review Request 127779: use system colors for monochrome icons

) - CMakeLists.txt 2e838e8 src/CMakeLists.txt 0e30a35 src/kiconloader.cpp 75ab482 Diff: https://git.reviewboard.kde.org/r/127779/diff/ Testing --- File Attachments dadel1.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-0

Re: Review Request 127779: use system colors for monochrome icons

) - CMakeLists.txt 2e838e8 src/CMakeLists.txt 0e30a35 src/kiconloader.cpp 75ab482 Diff: https://git.reviewboard.kde.org/r/127779/diff/ Testing --- File Attachments dadel1.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-0

Re: Review Request 127779: use system colors for monochrome icons

tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94957 ------- On April 28, 2016, 12:59 p.m., Marco Martin wrote: > > --- > This is an

Re: Review Request 127779: use system colors for monochrome icons

a new one every time is used? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94961 --- On April 28, 2016, 12

Re: Review Request 127779: use system colors for monochrome icons

oard.kde.org/r/127779/#review94964 --- On April 28, 2016, 12:59 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > <https://git.reviewboard.kde.org/r/127779/diff/5/?file=461490#file461490line870> > > > > I'd only use QBuffer in the case of svg. > > Marco Martin

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > <https://git.reviewboard.kde.org/r/127779/diff/5/?file=461490#file461490line870> > > > > I'd only use QBuffer in the case of svg. > > Marco Martin

Re: Review Request 127779: use system colors for monochrome icons

ace { > > QString NULL_EFFECT_FINGERPRINT() { > > return QStringLiteral("noeffect"); > > } > > QString STYLESHEET_TEMPLATE() { > > return QStringLiteral("..."); > > } > > } > > Marco Martin w

Re: Review Request 127779: use system colors for monochrome icons

) - CMakeLists.txt 2e838e8 src/CMakeLists.txt 0e30a35 src/kiconloader.cpp 75ab482 Diff: https://git.reviewboard.kde.org/r/127779/diff/ Testing --- File Attachments dadel1.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-0

  1   2   3   4   5   6   7   8   9   10   >