oxygen icon name clasheroo

2016-03-19 Thread Harald Sitter
Hola! Our most awesome icon maintainers wanted to carry over icon symlinking from breeze to oxygen, alas that turned up a whole slew of compatibility problems. examples: https://bugs.kde.org/show_bug.cgi?id=360605 https://bugs.kde.org/show_bug.cgi?id=360510 # Problem In kde4 software people used

Re: oxygen icon name clasheroo

2016-03-21 Thread Harald Sitter
On Sun, Mar 20, 2016 at 10:08 AM, David Faure wrote: > On Wednesday 16 March 2016 15:57:45 Harald Sitter wrote: >> Hola! >> >> Our most awesome icon maintainers wanted to carry over icon symlinking >> from breeze to oxygen, alas that turned up a whole slew o

Re: oxygen icon name clasheroo

2016-04-01 Thread Harald Sitter
On Thu, Mar 31, 2016 at 9:47 AM, David Faure wrote: > On Monday 21 March 2016 09:30:02 Harald Sitter wrote: >> On Sun, Mar 20, 2016 at 10:08 AM, David Faure wrote: >> > On Wednesday 16 March 2016 15:57:45 Harald Sitter wrote: >> >> Hola! >> >> >>

Review Request 127577: install index.theme to same directory it always was in

2016-04-05 Thread Harald Sitter
://git.reviewboard.kde.org/r/127577/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127577: install index.theme to same directory it always was in

2016-04-05 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter. Changes --- Submitted with commit 25a83b55f6b2439470bcc5d0963fd2ffa5c086ee by Harald Sitter to branch master. Repository: oxygen-icons5 Description --- otherwise we break

ECM metainfo path

2016-04-21 Thread Harald Sitter
ahoy ahoy! http://commits.kde.org/extra-cmake-modules/4b7a90bfe7a3e2eb3ae83c946c182a79fabc51e3 doesn't that break compatibility with older appstreams for everything that uses ECM? if so, I am not sure that is appropriate TBH HS ___ Kde-frameworks-devel

Review Request 127743: mkpath instead of mkdir

2016-04-25 Thread Harald Sitter
p/kcookiejar/kcookieserver.cpp 9f9d9449b2f06f33ac479b0b5fb47f26c169fb41 Diff: https://git.reviewboard.kde.org/r/127743/diff/ Testing --- tested the at the outlined scenario works make test still passes Thanks, Harald Sitter ___ Kde-frameworks-devel

Re: ECM metainfo path

2016-04-25 Thread Harald Sitter
On Fri, Apr 22, 2016 at 10:13 PM, Matthias Klumpp wrote: > 2016-04-22 12:45 GMT+02:00 Harald Sitter : >> Lost mailing list CC, I am assuming that was intentional? (: > > Oops, no - I didn't see the CC and didn't hit reply-all then... > Adding the list back (h

Re: Review Request 127743: mkpath instead of mkdir

2016-04-26 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 90e8bb655f98722f6904c4aeb5b1089249814224 by Harald Sitter to branch master. Repository: kio Description --- if the parent directory/ies does not exist yet mkdir would fail even when

Review Request 127759: fix unresolvable types by adding relevant includes

2016-04-27 Thread Harald Sitter
ake test - abi-compliance-checker happy Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127759: fix unresolvable types by adding relevant includes

2016-04-27 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 95e30fd2668700374140d4c590aa96dd6d1f593d by Harald Sitter to branch master. Repository: kcoreaddons Description --- - QString for versionString - uint is a typedef, use

Review Request 127764: warn about need for production data, skip tests that depend on them

2016-04-27 Thread Harald Sitter
eviewboard.kde.org/r/127764/diff/ Testing --- test passes in minimal environment - skips when xdg_data is not set - doesnt' skip with data set - skips when hicolor is not installed at all - passes when hicolor is installed Thanks, Harald Sitter _

Re: Review Request 127764: warn about need for production data, skip tests that depend on them

2016-04-27 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit c9e8c4b38c0d633b9e288169f647bceebddda72f by Harald Sitter to branch master. Repository: plasma-framework Description --- numerous icon tests expect the actual production plasma

Review Request 127830: use QUrl::fromUserInput to construct sound url

2016-05-04 Thread Harald Sitter
/notifybyaudio.cpp 6ae63b8df8e7aa692e88b03ca7b7538c78101917 Diff: https://git.reviewboard.kde.org/r/127830/diff/ Testing --- builds & test pass & I trust my testing in https://git.reviewboard.kde.org/r/127829/ Thanks, Harald Sitter ___ Kde-framewo

Review Request 127829: use QUrl::fromUserInput to construct sound url

2016-05-04 Thread Harald Sitter
gactionswidget.cpp 98286c4d0e8a7deec5d35986a261222931afb60d Diff: https://git.reviewboard.kde.org/r/127829/diff/ Testing --- built and played all of the above Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-d

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

2016-05-04 Thread Harald Sitter
ply, visit: https://git.reviewboard.kde.org/r/127829/#review95167 ------- On May 4, 2016, 1:26 p.m., Harald Sitter wrote: > > --- > This is an automatically gen

Re: Review Request 127830: use QUrl::fromUserInput to construct sound url

2016-05-09 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 9db06adc8114163f401417064b07772139bc36bc by Harald Sitter to branch master. Bugs: 337276 https://bugs.kde.org/show_bug.cgi?id=337276 Repository: knotifications Description

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

2016-05-09 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 4832f7d9f2f3bd0fa8ab9b9162bf50e855efc448 by Harald Sitter to branch master. Bugs: 337276 https://bugs.kde.org/show_bug.cgi?id=337276 Repository: knotifyconfig Description

Review Request 127905: refine current icon theme heuristics

2016-05-13 Thread Harald Sitter
iff: https://git.reviewboard.kde.org/r/127905/diff/ Testing --- test all scenarios. unfortunately I couln't figure out a way to take the theme plugin out of the equation to unit test this consistently even when a theme plugin is available Thanks,

Re: Review Request 127905: refine current icon theme heuristics

2016-05-13 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks, Christoph Feck and Marco Martin. Changes --- Submitted with commit 1425523dad0ba4f3acb9d0caa0ff772fd0a1a7e2 by Harald Sitter to branch master. Repository: kiconthemes Description --- this is to prevent incorrect default themes

Re: Broken ABI in networkmanager-qt

2016-05-17 Thread Harald Sitter
On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > Hi, > > we decided to drop WiMAX support in nm-qt when it's compiled against NM 1.2.0, > but this seems to break binary compatibility when nm-qt was previously build > against older NM version. I didn't realize this before that this could happ

Review Request 127952: add a function to override the current theme heuristics with a static value

2016-05-18 Thread Harald Sitter
https://git.reviewboard.kde.org/r/127952/diff/ Testing --- unit test + adapted plasma-framework's themetest to use this Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/li

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

2016-05-18 Thread Harald Sitter
with the presented ::forceCurrent we can solve the issue at hand and reduce overhead code in testing. - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/#review

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

2016-05-18 Thread Harald Sitter
emetest to use this Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

2016-05-18 Thread Harald Sitter
> On May 18, 2016, 9:58 a.m., Marco Martin wrote: > > src/kicontheme.h, line 223 > > <https://git.reviewboard.kde.org/r/127952/diff/1/?file=465111#file465111line223> > > > > what about just a testmode bool like qstandardpaths? > > Harald Sitter wrote:

Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

2016-05-18 Thread Harald Sitter
/actions/go-up.png autotests/icons/oxygen/64x64/actions/go-up.png autotests/icons/oxygen/index.theme Diff: https://git.reviewboard.kde.org/r/127953/diff/ Testing --- - test fails without /usr/share/icons and icons/oxygen fake dir - test passes with icons/hicolor Thanks, Harald Sitter

Re: Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

2016-05-18 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit cfc0a65e4dda986311c74f10797b09b1084a8e19 by Harald Sitter to branch master. Repository: kxmlgui Description --- rename fake icon set to hicolor as oxygen is no longer a

Review Request 127954: force icon themes explicitly via new testing helper function

2016-05-18 Thread Harald Sitter
/127954/diff/ Testing --- passes in session env. whether it passes in testbeds we'll see on jenkins :O Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

2016-05-18 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 7580470534c33ea7fdaf0b4c719a648f96350039 by Harald Sitter to branch master. Repository: kiconthemes Description --- this allows unit tests to force a specific name to be

Re: Review Request 127954: force icon themes explicitly via new testing helper function

2016-05-18 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 6ad988cb3df6ca3eac302444182b68fef383770f by Harald Sitter to branch master. Repository: plasma-framework Description --- force icon themes explicitly via new testing

Re: Plasma Next - Translations KCM - What Languages?

2014-03-17 Thread Harald Sitter
On Fri, Mar 14, 2014 at 2:31 PM, John Layt wrote: > Hi, > > I'm doing some more work on the new KCM for Translations, i.e. the KCM in > Plasma Next to configure the LANGUAGE env var that startkde will export for > all apps running under Plasma Next to use, including Gtk as well as Qt apps. > Becau

Re: Plasma Next - Translations KCM - What Languages?

2014-03-17 Thread Harald Sitter
On Mon, Mar 17, 2014 at 1:03 PM, Chusslove Illich wrote: >> [: Harald Sitter :] >> What we need is some plugin awesomeness (or equally fancy mechanism) to >> allow the distribution to put everything into context. The KCM wants to >> know what translations are available -&g

Q: kconfig without kaboutdata behavior

2014-04-03 Thread Harald Sitter
ahoy, I just wanted to ask whether it is still mandatory to have a KAboutData instance set to have classes such as KConfigShared work in a convenient fashion (e.g. KConfigShared::openConfig() will open the applications config as long as qapp::applicationName is set). In my particular case the pho

Re: Q: kconfig without kaboutdata behavior

2014-04-03 Thread Harald Sitter
On Thu, Apr 3, 2014 at 12:30 PM, Alex Merry wrote: > On 03/04/14 09:34, Harald Sitter wrote: >> ahoy, >> >> I just wanted to ask whether it is still mandatory to have a >> KAboutData instance set to have classes such as KConfigShared work in >> a convenient fashio

Re: KDE Frameworks Release Cycle

2014-05-05 Thread Harald Sitter
On Mon, May 5, 2014 at 11:11 AM, Martin Klapetek wrote: > On Sun, May 4, 2014 at 6:36 PM, David Faure wrote: >> >> [Cross posting against my will...] >> >> On Sunday 04 May 2014 16:27:44 Luigi Toscano wrote: >> > I understand that the big concern was about the testing: stable branches >> > did >>

phonon5 phonon4 phonon4qt5

2013-10-23 Thread Harald Sitter
since sebas asked me to bring up the phonons as he fears that lack of actual source compat in phonon5 could compromise the frameworks effort there will be the following libraries: === phonon5 === (current five branch) will *not* be 100% source compatible because pieces of the architecture disapp

konsole build broken

2013-11-11 Thread Harald Sitter
Would be great if someone could look at it. https://launchpadlibrarian.net/156314974/buildlog_ubuntu-saucy-i386.project-neon5-konsole_0.0%2Bgit2013%2Br5106~ffbca60%2Bneon6~ubuntu13.10.1_FAILEDTOBUILD.txt.gz http://build.kde.org/job/konsole_frameworks_qt5/33/console Generating moc_Part.cpp /bu

applications assert when no sycoca was generated before start

2013-11-18 Thread Harald Sitter
ahoy, I just noticed that frameworks applications explode when started without a sycoca: Trying to open ksycoca from "/home/me/.project-neon5-kde//cache/ksycoca5" Trying to open global ksycoca from "/home/me/.project-neon5-kde//local/share/kde5/services/ksycoca5" Still no database... ASSERT: "str

PSA: export XDG vars at build time

2013-11-20 Thread Harald Sitter
In case someone was not aware (because I was not :P), at build time you need to have XDG_DATA_DIRS and XDG_CONFIG_DIRS exported if your target prefix is not /usr. Otherwise tools may not be able to find their data/config files. For example meinproc5 looks up dtd files via QStandardPaths which enti

Re: Running tests faster..

2012-05-15 Thread Harald Sitter
On Tue, May 15, 2012 at 6:42 PM, David Faure wrote: > On Sunday 13 May 2012 00:04:43 Alexander Neundorf wrote: >> Hi, >> >> just a quick hint, maybe you don't know this yet: >> >> You can run tests using "make test". >> This will run test by test after each other. >> Internally this simply calls c

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread Harald Sitter
> On Oct. 20, 2012, 8:23 p.m., David Faure wrote: > > kcoreaddons has KFileSystemType, to distinguish local from NFS/SMB (which I > > guess this is what this was about). > > Maybe it could go into Qt I guess for now this is ok (unless we want to > > use kcoreaddons in phonon, but I doubt th

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Harald Sitter
nd url would be useful - Harald Sitter On Oct. 21, 2012, 9:59 a.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Harald Sitter
> On Oct. 21, 2012, 10:30 a.m., Harald Sitter wrote: > > phonon/mediasource.cpp, line 58 > > <http://git.reviewboard.kde.org/r/106974/diff/2/?file=91573#file91573line58> > > > > documentation on why path and url would be useful > > Jon Severinsson wro

phonon4qt5

2013-01-26 Thread Harald Sitter
as discussed previously there is now a transitional library for qt5 called phonon4qt5 and lives in a branch of the regular phonon git repos (pending release). phonon4qt5 is a 100% source compatible version of phonon4 that builds against qt5. it is directly derived from master and as such should be

Re: phonon4qt5

2013-01-27 Thread Harald Sitter
On Sun, Jan 27, 2013 at 11:03 PM, David Faure wrote: > On Sunday 27 January 2013 03:10:04 Harald Sitter wrote: > > as discussed previously there is now a transitional library for qt5 > called > > phonon4qt5 and lives in a branch of the regular phonon git repos (p

Re: Phonon4Qt5 & Phonon5 Branches

2013-06-13 Thread Harald Sitter
On Tue, Jun 4, 2013 at 12:47 AM, David Faure wrote: > On Wednesday 29 May 2013 16:13:23 Harald Sitter wrote: > > As you may be aware phonon supports building the phonon4 API against Qt5 > by > > building the phonon4qt5 branch. > > > > Due to consolidation eff

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60591 --- Ship it! looks good to me - Harald Sitter On June 20

Re: KAuth and KF5

2014-06-25 Thread Harald Sitter
On Wed, Jun 25, 2014 at 9:40 AM, Milian Wolff wrote: > On Tuesday 24 June 2014 23:44:12 Luca Beltrame wrote: >> Hello, >> >> currently, the KF5 version of KAuth is not quite usable as any helper used >> by KAuth segfaults: the most notable is backlighthelper, which always >> crashes at login. FWI

Re: KIconLoader problem with KFontInst

2014-06-30 Thread Harald Sitter
On Mon, Jun 30, 2014 at 12:02 PM, Martin Klapetek wrote: > ...or have the icons installed properly (hicolor?) and remove the custom > addAppDir call altogether? Not that I grasp the issue, but if it is a general problem that could have impact on every application using custom icon overloads/addit

Re: Translations in frameworks released tarballs

2014-07-09 Thread Harald Sitter
On Wed, Jul 9, 2014 at 11:27 AM, Alexander Potashev wrote: > 2014-07-09 2:38 GMT+04:00 David Faure : >> On Tuesday 08 July 2014 23:24:36 Christoph Feck wrote: >>> Is it possible to strip them before the archives are packed? Or can >>> they even be stripped in the repositories? >> >> Good question.

Re: Translations in frameworks released tarballs

2014-07-09 Thread Harald Sitter
On Wed, Jul 9, 2014 at 8:32 PM, Albert Astals Cid wrote: > El Dimecres, 9 de juliol de 2014, a les 22:25:29, Albert Astals Cid va > escriure: >> El Dimecres, 9 de juliol de 2014, a les 11:59:01, Harald Sitter va escriure: >> > On Wed, Jul 9, 2014 at 11:27 AM, Alexander Pota

Review Request 119540: don't construct bogus KAuthAction objects

2014-07-29 Thread Harald Sitter
https://git.reviewboard.kde.org/r/119540/diff/ Testing --- tested with clock kcm, succesfully can talk with the helper app if the bogus actionid "" wasn't used intermediately Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-fram

Review Request 119542: create qapplication before using dbus

2014-07-29 Thread Harald Sitter
https://git.reviewboard.kde.org/r/119542/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119542: create qapplication before using dbus

2014-07-30 Thread Harald Sitter
uture Diffs - src/kauthhelpersupport.cpp 99868803fdfaf99283d65a8ab61e7a32fb22e708 Diff: https://git.reviewboard.kde.org/r/119542/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-07-30 Thread Harald Sitter
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/#review63509 ----------- On Juli 30, 2014, 12:32 vorm., Harald Sitter wrote: > >

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-08-01 Thread Harald Sitter
Diffs - src/kcmodule.cpp 92e5427c121491e4ebf289addda040cc117cdd68 Diff: https://git.reviewboard.kde.org/r/119540/diff/ Testing --- tested with clock kcm, succesfully can talk with the helper app if the bogus actionid "" wasn't used intermediately Th

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Harald Sitter
-- On Aug. 1, 2014, 2:29 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119563/ > -----

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-14 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64581 --- +1 - Harald Sitter On Aug. 14, 2014, 11:10 p.m., Aleix Pol

Re: Interesting issue with KAboutData and icons

2014-08-18 Thread Harald Sitter
On Mon, Aug 18, 2014 at 9:41 AM, David Faure wrote: > On Monday 04 August 2014 22:01:15 Michael Pyne wrote: >> Hi all, >> >> I received a bug (https://bugs.kde.org/show_bug.cgi?id=337938) reported >> against KAboutData in KCoreAddons, that setting the window icon doesn't >> actually set the window

SIC in KIO master

2014-08-26 Thread Harald Sitter
alohas, it would appear to me that a recent change in kio [1] was rather, very, entirely source incompatible (one could argue binary but let's not go there). Say I had the following in my application using kio 5.0/1: connect(copyjob, &CopyJob::aboutToCreate, this, &MyThing::onABoutToCreate); my

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Harald Sitter
implementing the qapp property in qt (which would probably be pointless since we get nothing out of setting the data via kaboutdata to begin with) - Harald Sitter On Aug. 28, 2014, 4:39 p.m., Jonathan Riddell wrote: > > --- > T

Re: SIC in KIO master

2014-08-29 Thread Harald Sitter
On Tue, Aug 26, 2014 at 4:29 PM, Harald Sitter wrote: > alohas, > > it would appear to me that a recent change in kio [1] was rather, > very, entirely source incompatible (one could argue binary but let's > not go there). > > Say I had the following in my application us

Re: SIC in KIO master

2014-08-31 Thread Harald Sitter
On Fri, Aug 29, 2014 at 8:26 PM, David Faure wrote: > On Tuesday 26 August 2014 16:29:23 Harald Sitter wrote: >> alohas, >> >> it would appear to me that a recent change in kio [1] was rather, >> very, entirely source incompatible (one could argue binary but let'

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Harald Sitter
write a krunner replacement that doesn't depend/ispartof plasma workspace one would still run into the broken behavior so long as kde-cli-tools are not installed - Harald Sitter On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: > > -

Re: There's no proper replacement for KIcon

2014-09-03 Thread Harald Sitter
On Wed, Sep 3, 2014 at 10:26 PM, Eike Hein wrote: > I think the fd.o spec pro- > scribes the hicolor theme then? ^ this > In that case it would > be up to the distro to make sure this works out. That wouldn't help the original issue that we previously had a hardcoded fallback to oxygen, in fac

Re: Review Request 120040: Install kdesu under bin

2014-09-16 Thread Harald Sitter
> On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: > > >in kde4 kdesu was installed under bin > > > > it was actually also in libexec. just that KStandardDirs::findExe() looked > > in libexec paths, QStandardPaths doesn't... > > Marco Martin wrote: > right, it seems on both places here, b

frameworks' cmake configs looking for other things

2014-10-10 Thread Harald Sitter
Alohas as described in [1] I think there is a bit of a problem how we track inter-dependencies in cmake configs right now (that is: the configs frameworks install to be found by 3rd party bits). If I write a 3rd party software that does this: > find_package(KF5Runner) it will eventually trigger

pkexec vs kdesu

2014-11-23 Thread Harald Sitter
hola! how about we replace all of our kdesu usage with pkexec. pkexec has a lovely nice dialog, is backed by polkit, very secure, very nice, totally cool. also, absolutely sufficient. thoughts? HS ___ Kde-frameworks-devel mailing list Kde-frameworks-de

Re: pkexec vs kdesu

2014-11-23 Thread Harald Sitter
On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson wrote: > You will probably get massively different behaviour regarding your env. > > pkexec won't copy anything, sudo will. > Without $DISPLAY graphical apps are out. Surely not an unsolvable problem. Clearly wayland fixes this ;) > That said, pol

Review Request 121262: make kservice_desktop_to_json warning an author_warning

2014-11-26 Thread Harald Sitter
--- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121262: make kservice_desktop_to_json warning an author_warning

2014-11-27 Thread Harald Sitter
dcb7cce6fc2e57b1b7b863da500c88b61e447ef5 Diff: https://git.reviewboard.kde.org/r/121262/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: phonon fails to INSTALL on branch master

2014-11-27 Thread Harald Sitter
On Thu, Nov 27, 2014 at 8:59 AM, Marko Käning wrote: > Phonon built fine, but failed to install for some reason, as a file must be > missing: I think that needs some more investigation. I can not reproduce this nor can I even think of how that would happen :/ HS

FYI: watch out for Q_GADGET with cmake2.8

2014-12-04 Thread Harald Sitter
alohas Qt has a magic macro Q_GADGET which according to a websearch falls slightly short of magic. It apparently allows non-QObject classes to grow a metaobject such that one can use properties/enums/invokables. Now the problem with that is that Q_GADGET is not supported by the cmake2.8 automoc c

Re: Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin wrote: > On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: >> On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson >> >> wrote: >> > You will probably get massively different behaviour regarding your env. >&g

Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson wrote: > That said, polkit is totally the way forward and anything using kdesu should > be ported. I think the biggest concern is our custom desktop entry allowing *any* third party developer to leverage the power of kdesu and easily elevate their

Re: Re: Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Thu, Dec 11, 2014 at 2:29 PM, Martin Gräßlin wrote: > On Thursday 11 December 2014 14:06:59 Harald Sitter wrote: >> On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin wrote: >> > On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: >> >> On Sun, Nov 23, 20

qca-qt5 package name

2014-12-17 Thread Harald Sitter
alohas. recently the QCA maintainer and I got into a discussion [1] whether a qca-qt5 library should be a different config inside the same cmake package or an independent one (detailed discussion in the longest comment thread of the review). > find_package(Qca NAMES Qca-qt5 Qca-QT5 Qca-5 Qca REQU

Re: qca-qt5 package name

2014-12-27 Thread Harald Sitter
On Wed, Dec 24, 2014 at 11:47 AM, David Edmundson wrote: > > > On Wed, Dec 17, 2014 at 12:47 PM, Harald Sitter wrote: >> >> alohas. >> >> recently the QCA maintainer and I got into a discussion [1] whether a >> qca-qt5 library should be a different config

Re: qca-qt5 package name

2014-12-27 Thread Harald Sitter
On Sat, Dec 27, 2014 at 1:47 PM, Alex Merry wrote: > On Saturday 27 December 2014 12:24:25 Harald Sitter wrote: >> I think(tm) the way to fix this properly (which I have not ever seen >> done by us :P) is fiddling with the find_package related variables >> (supposedly PACKA

Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Harald Sitter
Description --- add reviewbaordrc, targets kdeframeworks and plasma groups Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121833/diff/ Testing --- made this here review request Thanks, Harald Sitter

Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
8f6fe5a198329528692d3edf30ea5d4e36932872 Diff: https://git.reviewboard.kde.org/r/121834/diff/ Testing --- make & install & make test & man kpackagetool5; all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Harald Sitter
here review request Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Harald Sitter
://git.reviewboard.kde.org/r/121836/diff/ Testing --- make & install & test; all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
docs/kpackagetool/man-kpackagetool.1.docbook 8f6fe5a198329528692d3edf30ea5d4e36932872 Diff: https://git.reviewboard.kde.org/r/121834/diff/ Testing --- make & install & make test & man kpackagetool5; all good Thanks, Harald Sitter ___

Re: Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Harald Sitter
/dynamictreemodel.h 283d6ed3f938c5d7d69504ced36e11e437d2aaad Diff: https://git.reviewboard.kde.org/r/121836/diff/ Testing --- make & install & test; all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-framewor

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
346982d97340e94846a7c9ddebddb260a694b40a docs/kpackagetool/man-kpackagetool.1.docbook 8f6fe5a198329528692d3edf30ea5d4e36932872 Diff: https://git.reviewboard.kde.org/r/121834/diff/ Testing --- make & install & make test & man kpackagetool5; all good Thanks, H

qca-qt5 2.1.0.1

2015-01-08 Thread Harald Sitter
お早う As some of you might know qca's qt5/qt4 co-installability is a bit of an issue with the maintainer not wanting to force a unified suffix for qt5 builds so here is a grand unified version with a forced qt5 suffix: http://download.kde.org/stable/qca-qt5/2.1.0.1/src/qca-qt5-2.1.0.1.tar.xz.mirror

backwards compatibility & how namespacing might help or not

2015-01-26 Thread Harald Sitter
ahoy ahoy so... kf5.7 will contain kglobalacceld5 plasma5.2 will also contain kglobalacceld5 if it was built with kf5.6 this poses a binary conflict which makes kf5.7 not a simple "drop-in" replacement for kf5.6 without recompiling plasma, which effectively makes this new construct just like the

Re: backwards compatibility & how namespacing might help or not

2015-01-27 Thread Harald Sitter
On Mon, Jan 26, 2015 at 10:01 PM, Albert Astals Cid wrote: > Yeah, i don't think that what you suggest really helps much, otherwise you'd > end up with two kglobalaccels running at the same time, which is probably a > very bad thing. It's dbus invoked, so in the kglobaccel case specifically david

Re: backwards compatibility & how namespacing might help or not

2015-01-28 Thread Harald Sitter
On Tue, Jan 27, 2015 at 11:54 PM, Albert Astals Cid wrote: > El Dimarts, 27 de gener de 2015, a les 10:28:24, Harald Sitter va escriure: >> On Mon, Jan 26, 2015 at 10:01 PM, Albert Astals Cid wrote: >> > Yeah, i don't think that what you suggest really helps much, othe

Re: backwards compatibility & how namespacing might help or not

2015-01-28 Thread Harald Sitter
On Wed, Jan 28, 2015 at 1:56 AM, Vishesh Handa wrote: > > On Tue, Jan 27, 2015 at 10:28 AM, Harald Sitter wrote: >> >> > So yes, a better way of moving thing arounds is needed, or maybe we just >> > need >> > the dust to settle a bit so that we reali

Re: New framework: KXmlRpcClient

2015-02-13 Thread Harald Sitter
On Thu, Feb 12, 2015 at 8:25 PM, Albert Astals Cid wrote: > El Dijous, 12 de febrer de 2015, a les 12:31:14, Daniel Vrátil va escriure: >> On Friday, January 30, 2015 09:12:01 AM David Faure wrote: >> > On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: >> > > I guess I should update kde-b

KHTML binary incompatible change

2015-03-04 Thread Harald Sitter
Ahoy, As of 2015-03-03 KHTML has a commit that renames a public function of the DOMString class introduced in KF5.5 last year. This constitutes a binary and source incompatible change that should either be revisited to be made compatible or the libKF5KHtml.so version needs to be increased to 6 sta

Re: KHTML binary incompatible change

2015-03-04 Thread Harald Sitter
On Wed, Mar 4, 2015 at 9:55 AM, Luigi Toscano wrote: > Il 04 marzo 2015 09:50:32 CET, Harald Sitter ha scritto: >> Ahoy, >> >> As of 2015-03-03 KHTML has a commit that renames a public function of >> the DOMString class introduced in KF5.5 last year. This constit

cmake CMP0028 & missing targets - what does one do about it?

2015-03-19 Thread Harald Sitter
alohas While investigating a wall of build failures in the kubuntu ci this morning I stumbled upon a very interesting problem. Problem tldr: target A links library B, A doesn't get the includes of link libraries of B by default. e.g. A links B, B links karchive, A doesn't have access to the karch

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-04-01 Thread Harald Sitter
On Tue, Mar 31, 2015 at 9:29 PM, Alex Merry wrote: > On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: >> Problem tldr: target A links library B, A doesn't get the includes of >> link libraries of B by default. e.g. A links B, B links karchive, A >> doesn

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-04-02 Thread Harald Sitter
On Wed, Apr 1, 2015 at 10:41 PM, Alex Merry wrote: > On Wednesday 01 April 2015 21:39:45 Alex Merry wrote: >> This appears to be a regression with the 3.0 branch of CMake. 2.8.12 doesn't >> have an issue, and neither does 3.1.3. > > For reference: http://www.cmake.org/Bug/view.php?id=15101 Uh, th

kconfiggui symbol retraction

2015-05-12 Thread Harald Sitter
not quite sure how it got lost - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base 5.9.0+git20150512.0743+15.04-0 +#MISSING: 5.9.0+git20150512.0743+15.04-0# _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 __

Re: kconfiggui symbol retraction

2015-05-12 Thread Harald Sitter
On Tue, May 12, 2015 at 12:51 PM, David Faure wrote: > On Tuesday 12 May 2015 11:57:44 Harald Sitter wrote: >> not quite sure how it got lost >> >> - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 >> + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base >&g

Review Request 123768: port to new ecm_add_test PROPERTIES argument

2015-05-13 Thread Harald Sitter
test -j9 Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

  1   2   3   4   5   6   7   8   9   10   >