Re: IconDialog customLocation

Hi, copy pasting my response from https://bugs.kde.org/show_bug.cgi?id=427434 : I think you want to set "user: true". The name of this property comes from KIconDialog [1] which is wrapped by IconDialog [2] Best regards, David [1] https://api.kde.org/frameworks/kiconthemes/html/classKIconDialo

Re: How to sort TableModel QML Type

Am Samstag, 17. Oktober 2020, 20:38:43 CEST schrieb chiasa.men: > Is there a way to sort a TableModel without relying on c++ code? Hi, we have QSortFilterProxyModel bindings in KItemModels, which makes it easy to create and use such a proxy model from Qml: https://api.kde.org/frameworks/ kitemmo

Re: KGlobalAccel on non-Plasma systems

Hi, I agree that it's most useful on plasma. >On systems that do not use X11 (Windows, macOS, Android) it >is most likely not useful at all. There exists code for mac and windows but I don't know either if it's working or just a dummy so it compiles. Also for everyone interested in the topic,

Re: Including instead of , does it upset POSIX?

Looking into the C++ 17 working draft (http://open-std.org/JTC1/SC22/WG21/ docs/papers/2017/n4659.pdf) is actually the same as the POSIX header. In section 22.4 (page 517) >The contents of the headerare the same as the POSIX header, except thaterrnoshallbe defined as a macro. [Note:The intent is

Re: Noteworthy changes when porting to C++17

Hi I found these two papers http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1319r0.html http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0636r1.html Regards, David

D28033: Create ExpandableListItem

davidre added a comment. I would love if we could find a way to show that the item is expandable REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28033: Create ExpandableListItem

davidre added a comment. In D28033#627192 , @ngraham wrote: > In D28033#627184 , @cblack wrote: > > > In D28033#627180 , @davidre wrote: > > > > > I wou

D28130: Introduce api for passive notifications

davidre added a comment. I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28130 To: mart Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27617: [breeze-icons] Add telegram-desktop tray icons

davidre added a comment. In D27617#630336 , @IlyaBizyaev wrote: > In D27617#630228 , @ngraham wrote: > > > So... how do we fix this so that you can use a nice monochrome Breeze icon in your system

D27617: [breeze-icons] Add telegram-desktop tray icons

davidre added a comment. In D27617#630440 , @ilya-fedin wrote: > In D27617#629987 , @ngraham wrote: > > > Would it help this use case if we moved the Telegram icon into the Plasma theme for now, pe

D28223: Add "Stat" prefix to StatDetails Enum entries

davidre added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest I think this enum was not released yet REPOSITORY R241 KIO REVISI

D28203: Move corner fold to top right in 24 icons

davidre reopened this revision. davidre added a comment. This broke the build. Please note that tagging is today REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeG

D28203: Move corner fold to top right in 24 icons

davidre requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, G

D28203: Move corner fold to top right in 24 icons

davidre added a comment. Seems @kossebau was faster ;) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

davidre added a comment. In D28470#640468 , @cblack wrote: > Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me. I had assumed it's because of https://en.m.wikipedia.org/wiki/Str

D28203: Move corner fold to top right in 24 icons

davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, mich

D28203: Move corner fold to top right in 24 icons

davidre closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27848: Remove the panel tooltip icon

davidre added a comment. I think this was done at the wrong level. If we don't want icons in the systray then the way would be to net set the property in the systray and not ignore the property in the generic component but keep the property for api stability purposes. Now we have a componen

D28624: Print a warning if runner is incompatible with KRunner

davidre created this revision. davidre added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Useful for finding out why runner isn't loaded even though it's enabled in settings

D27848: Remove the panel tooltip icon

davidre added a comment. In D27848#643045 , @ngraham wrote: > See the parent task. > > This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these t

D28697: Also relase the window in the destructor

davidre created this revision. davidre added reviewers: broulik, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise the keyboard is never released when the item is destroyed while

D28697: Also relase the window in the destructor

This revision was automatically updated to reflect the committed changes. Closed by commit R296:6c5619ffebae: Also relase the window in the destructor (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28697?vs=79688&id=79690 REVISION

D28699: Add startCapture method

davidre created this revision. davidre added reviewers: Frameworks, davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Starts capturing as if the user clicked on the main button

D28699: Add startCapture method

This revision was automatically updated to reflect the committed changes. Closed by commit R296:5eb3c795a8f2: Add startCapture method (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28699?vs=79691&id=79764 REVISION DETAIL https://

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. In D24956#648991 , @meven wrote: > In D24956#648968 , @davidedmundson wrote: > > > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre created this revision. davidre added reviewers: davidedmundson, fvogt, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Works for writable and not writable files. Additional positive we

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre updated this revision to Diff 80206. davidre added a comment. foo REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28856?vs=80205&id=80206 BRANCH disable (branched from master) REVISION DETAIL https://phabricator.kde.org/D28856 AFFECTED FI

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre added inline comments. INLINE COMMENTS > globalshortcutsregistry.cpp:274 > +auto disabledComponents = KConfigGroup(&_config, > "disabledComponents").readEntry("disabled", QStringList()); > for (const QString &groupName : groupList) > { good point > globalshortcutsregi

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre marked 4 inline comments as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D28856 To: davidre, davidedmundson, fvogt, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28856: Save disabling of desktop file components in kglobalshortcutsrc

davidre updated this revision to Diff 80265. davidre added a comment. Don't parse the disabledGroup as component REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28856?vs=80206&id=80265 BRANCH disable (branched from master) REVISION DETAIL https://

D29011: Fix variable mixup

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Caused icons to be not longer recolored when changing the color scheme until an application is started again TEST PL

D29011: Fix variable mixup

davidre abandoned this revision. davidre added a comment. Oh I diffed the wrong repo... REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29011 To: davidre, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

davidre added reviewers: Breeze, Plasma. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29011 To: davidre, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

davidre added inline comments. INLINE COMMENTS > kcolorscheme.cpp:271 > static const DecoDefaultColors defaultDecorationColors = { > { 61, 174, 233 }, // Focus > { 147, 206, 233 }, // Hover I would have expected at least of one the new colors to have the same value as this one. REP

D29232: [WIP][RFC]Introduce the Header color set

davidre added inline comments. INLINE COMMENTS > ndavis wrote in kcolorscheme.cpp:271 > Why is that? The only one that might is Active, but that's not really used > much right now. Because the new colors are the replacement for theses colors. I thought one of those might map to this REPOSITOR

D28093: [breeze-icons] add TeamViewer tray icons

davidre added a comment. Couldn't we put the tray icon in the plasma theme? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka, #vdg, ngraham, ndavis Cc: davidre, IlyaBizyaev, ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, brun

D28624: Print a warning if runner is incompatible with KRunner

This revision was automatically updated to reflect the committed changes. Closed by commit R308:e56def21a286: Print a warning if runner is incompatible with KRunner (authored by davidre). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28624?vs=79487&id=81486

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 82492. davidre added a comment. - Rebase without test REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78982&id=82492 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 82519. davidre added a comment. - fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=82492&id=82519 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D28208 AFFECTED

D29802: Require in-source build

davidre requested changes to this revision. davidre added a comment. This revision now requires changes to proceed. I don't think we want to require in source builds REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, da

D29802: Require out-of-source builds

davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre, kde

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

davidre added a comment. Ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29463 To: Zren, #kirigami, mart Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

davidre added a comment. This caused https://bugs.kde.org/show_bug.cgi?id=423003. I removed excluding the virtual method from the build in https://invent.kde.org/frameworks/krunner/commit/8f7ce559b84ee0c21de0256e6591793e4b95f411 REPOSITORY R308 KRunner REVISION DETAIL https://phabric

Re: Breakage in Breeze Icons

I fixed the build now. There was a symlink to a removed file which cmake -E copy_directory didn't like. Regards, David

Re: KF6 meeting notes 2021-12-07

Am Dienstag, 7. Dezember 2021, 18:04:19 CET schrieb Volker Krause: https://phabricator.kde.org/T11587 - there are bigger plans to rework color scheming, this needs more coordination with the effort to down-tier this for KF6 - would likely mean only storing the color scheme name in kdeglobals ra

KWayland 5.94 respin request

Please include https://invent.kde.org/frameworks/kwayland/-/commit/2e94a425120971ec535278629e216f5e632fe9bc It fixes a crash with a newly added function Thanks, David

Re: Challenge: adding new method overloads when existing consumers use {} with args

Am Samstag, 23. Juli 2022, 17:20:08 CEST schrieb Friedrich W. H. Kossebau: > Hi, > > (cc: kde-frameworks-devel for heads-up, please reply to kde-devel only) > > given a class C with a method foo(A a): > --- 8< --- > class C > { > public: > void foo(A a); > }; > --- 8< ---

Re: Challenge: adding new method overloads when existing consumers use {} with args

Am Samstag, 23. Juli 2022, 17:20:08 CEST schrieb Friedrich W. H. Kossebau: > Hi, > > (cc: kde-frameworks-devel for heads-up, please reply to kde-devel only) Sorry replied wrong first :) > given a class C with a method foo(A a): > --- 8< --- > class C > { > public: > void foo(A a); > }; > --- 8< ---

Re: Splitting KGlobalAccel interface and runtime

Am Montag, 13. Februar 2023, 21:05:33 CET schrieb Nicolas Fella: > It wouldn't automatically solve the coinstallability problem of KF5 and > KF6, because a kglobalacceld provided by KF5-KGlobalAccel would still > conflict with a Plasma-provided kglobalacceld, but it's at least > conceptually less m

Re: kio-extras and the KF5/KF6 period

Am Donnerstag, 25. Mai 2023, 12:51:32 CEST schrieb Nicolas Fella: > Hi, > > Am 17.05.23 um 00:02 schrieb Albert Astals Cid: > > kio-extras provides plugins for kio. > > > > So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6 > > kio- extras. > > This is also the case in mor

Re: kio-extras and the KF5/KF6 period

Am Mittwoch, 7. Juni 2023, 13:00:13 CEST schrieb Luigi Toscano: > I think this is a different case: plasma-integration is part of plasma, and > afaik the maser branch of all repositories which are part of plasma are > Qt6-only already. Note that plasma-integration is our Qt Platform Theme and is i

Re: kio-extras and the KF5/KF6 period

Am Mittwoch, 17. Mai 2023, 00:02:18 CEST schrieb Albert Astals Cid: > kio-extras provides plugins for kio. > > So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6 > kio- extras. > > If we're going to support a period on which we ship both Kf5 and KF6 based > applications we

Re: kio-extras and the KF5/KF6 period

Am Mittwoch, 21. Juni 2023, 12:31:47 CEST schrieb Ben Cooksley: > It sounds like we are approaching (or have already hit) a "crossroads" > where it is time for the Qt 5 codebase to enter a stable release only > phase, with master becoming Qt 6 exclusive. > Splitting the code into separate Qt 5 / Qt

Re: kio-extras and the KF5/KF6 period

Am Dienstag, 20. Juni 2023, 14:52:44 CEST schrieb David Redondo: > Harald and I prototyped another solution to build a Qt > 5 and Qt 6 version out of the same repo and employed it on > plasma-integration: https://invent.kde.org/plasma/plasma-integration/-/ > merge_requests/91 &g

Re: Frameworks / Plasma/ Gear Release Schedule Plan

Am Dienstag, 12. September 2023, 21:42:37 CEST schrieb christ...@cullmann.io: > Hi, > > i prepared some merge request for the switch in the meta data: > > https://invent.kde.org/sysadmin/repo-metadata/-/merge_requests/185 > > A question about the CMake changes: > > Is there some preferred way t

Re: Collection of packaging notes

Am Freitag, 10. November 2023, 12:36:09 CET schrieb Jonathan Riddell: > On Fri, 10 Nov 2023 at 10:55, Christophe Marin wrote: > > > - The libksysguard libraries soversion weren't bumped. It's not only a > > problem for > > building plasma 5 and plasma 6. KSysguard is also an optional dependency

D22827: Scrollview - Don't fill the parent with the view If the style sets a padding this is not respected if we set `anchors.fill: parent`.

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REPOSITORY R296 KDeclarative BRANCH scrollview (branched from master) REVISION DETAIL https://phabricator.kde.org/D22827 AFFECTED

D22827: Scrollview - Don't fill the parent with the view If the style sets a padding this is not respected if we set `anchors.fill: parent`.

davidre updated this revision to Diff 62791. davidre added a comment. Commit message REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22827?vs=62790&id=62791 BRANCH scrollview (branched from master) REVISION DETAIL https://phabricator.kde.org/D2282

D22827: Scrollview - Don't fill the parent with the view

davidre retitled this revision from "Scrollview - Don't fill the parent with the view If the style sets a padding this is not respected if we set `anchors.fill: parent`." to "Scrollview - Don't fill the parent with the view". davidre edited the summary of this revision. davidre edited the test pl

D22827: Scrollview - Don't fill the parent with the view

davidre edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22827: Scrollview - Don't fill the parent with the view

davidre added a comment. An alternative approach could be to set the respective `anchor.*margin` to `view.parent.*padding`. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22827: Scrollview - Don't fill the parent with the view

davidre edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart Cc: filipf, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

davidre added a comment. @kossebau also wrote In D22836#504355 , @kossebau wrote: > That as well, as also discussed on irc today. > > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test

D22827: Scrollview - Don't fill the parent with the view

davidre added a comment. So the alternative approach would be something like this: diff --git a/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml b/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml index 8ef57a2..443f063 100644 --- a/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml

D22827: Scrollview - Don't fill the parent with the view

This revision was automatically updated to reflect the committed changes. Closed by commit R296:e310144eb8e9: Scrollview - Don't fill the parent with the view (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22827?vs=62791&id=62917 R

D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY BUG:411163 REPOSITORY R266 Breeze Icons BRANCH krita (branched from master) REVISION DETAIL https://phabricator

D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita

This revision was automatically updated to reflect the committed changes. Closed by commit R266:34ae5675f36b: Krita has split from Calligra and now uses Krita name instead of calligrakrita (authored by davidre). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 AFFEC

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre edited the summary of this revision. davidre edited the test plan for this revision. davidre added reviewers: Frameworks, VDG. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a comment. I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. F7538956: Screenshot_20191007_163458.png But the difference is that in widgets the scrollbar doesn't overlap the contents. REPOSITORY R276 KItemView

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre updated this revision to Diff 67480. davidre edited the summary of this revision. davidre added a comment. Set categoryspacing to 0 REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?vs=67408&id=67480 BRANCH newcategorystyle (branched from m

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre edited the test plan for this revision. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added reviewers: Konversation, KEXI, KDE Edu, KDE PIM, KPublicTransport. davidre added a comment. Looking at lxr other users include (not exhaustive, I may have missed some) Konversation F7546131: Screenshot_20191008_105439.png Kexi (don't hav

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a reviewer: Amarok. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre updated this revision to Diff 67529. davidre added a comment. Make code more expressive and add comments REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?vs=67480&id=67529 BRANCH newcategorystyle (branched from master) REVISION DETAIL h

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre marked an inline comment as done. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a comment. In D24453#544251 , @ngraham wrote: > +1. Can you do the same thing for the similar header that's seen in System Settings' icon view? > > F7556761: Screenshot_20191009_085522.png

D24736: Grab the keyboard when KeySequenceItem is recording

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise assigning a key combination which is currently bound to a global shortcut action will trigger the global sho

D24736: Grab the keyboard when KeySequenceItem is recording

davidre added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

davidre updated this revision to Diff 68143. davidre added a comment. - Make helper a qquickitem instead REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24736?vs=68142&id=68143 BRANCH grabkeyboard (branched from master) REVISION DETAIL https://pha

D24736: Grab the keyboard when KeySequenceItem is recording

davidre updated this revision to Diff 68144. davidre added a comment. Whitespace REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24736?vs=68143&id=68144 BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

This revision was automatically updated to reflect the committed changes. Closed by commit R276:974a3ad18c05: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer (authored by davidre). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. I think you have also to check the the kcm as i also saw some `nodisplay` there. Also it seems kglobalaccel uses nodisplay when a component is disabled. https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n144 REPOSITORY R268 KGloba

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. For reference here is the relevant part in the kcm https://cgit.kde.org/plasma-desktop.git/tree/kcms/keys/kglobalshortcutseditor.cpp#n176 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc:

D24736: Grab the keyboard when KeySequenceItem is recording

davidre added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

This revision was automatically updated to reflect the committed changes. Closed by commit R296:7ede04501eda: Grab the keyboard when KeySequenceItem is recording (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24736?vs=68144&id=68960

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

davidre added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:36 > m_serviceStorageId(serviceStorageId), > > m_desktopFile(QStandardPaths::locate(QStandardPaths::GenericDataLocation, > QStringLiteral("kglobalaccel/") + serviceStorageId)) > { Related to thi

D25307: kwriteconfig: add delete option

davidre added a comment. I don't think deleting a entry from a config file makes sense. If you delete an entry you will get the default value on the next read. For shortcuts it's a bit more complicated. What shortcuts had you in mind to delete? REPOSITORY R237 KConfig REVISION DETAIL

D25307: kwriteconfig: add delete option

davidre added a comment. In D25307#562613 , @esjeon wrote: > > What shortcuts had you in mind to delete? > > My specific interest is deleting shortcuts of removed KWin scripts. ( e.g. https://github.com/esjeon/krohnkite/issues/31 ) Such short

D25307: kwriteconfig: add delete option

davidre added a comment. In D25307#562652 , @esjeon wrote: > Also, I don't see anything wrong with adding this, since it merely exposes `deleteEntry` method already in the API. Some projects do rely on it, so why should it be kept away from actu

D25546: Deprecate KRecursiveFilterProxyModel

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY It is not needed since Qt 5.10 REPOSITORY R275 KItemModels BRANCH deprecate (branched from master) REVISION DETAI

D25546: Deprecate KRecursiveFilterProxyModel

davidre added a task: T12269: Remove KRecursiveFilterProxyModel. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, ngraham, bruns, kpiwowarski, asturmlechner,

D25546: Deprecate KRecursiveFilterProxyModel

davidre added reviewers: kossebau, dfaure. davidre added a project: KF6. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, ngraham, bruns, kpiwowarski, asturm

D25546: Deprecate KRecursiveFilterProxyModel

davidre updated this revision to Diff 70426. davidre marked 4 inline comments as done. davidre added a comment. address comments REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25546?vs=70348&id=70426 BRANCH deprecate (branched from master) REVISION

D25546: Deprecate KRecursiveFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R275:68f3b292ca03: Deprecate KRecursiveFilterProxyModel (authored by davidre). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25546?vs=70426&id=70479 REVISION DETAI

D25626: Fix EcmGenerateExportHeader tests on windows

davidre created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY -we errors on warning . C4996 warns on deprecated declarations. TEST PLAN Tests

D25626: Fix EcmGenerateExportHeader tests on windows

davidre added reviewers: kossebau, Windows, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25626 To: davidre, kossebau, #windows, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on Windows

davidre retitled this revision from "Fix EcmGenerateExportHeader tests on windows" to "Fix EcmGenerateExportHeader tests on Windows". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25626 To: davidre, kossebau, #windows, #frameworks Cc: kde-frameworks-devel,

D25626: Fix EcmGenerateExportHeader tests on Windows

davidre added a comment. In D25626#569714 , @kossebau wrote: > Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the da

D25626: Fix EcmGenerateExportHeader tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R240:bfdcec82d926: Fix EcmGenerateExportHeader tests on Windows (authored by davidre). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25626?vs=70610&id=70615

  1   2   3   >