D28861: Sonnet add Malayalam trigram

2020-10-03 Thread Carl Schwan
ognarb added a subscriber: sandsmark. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28861 To: aiswaryak, #frameworks Cc: sandsmark, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carl Schwan
ognarb added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carl Schwan
ognarb added a comment. Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar. I also saw some alignment issues with the method args: F8227657: image.

D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. LGTM REPOSITORY R264 KApiDox BRANCH cblack/aether (branched from master) REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack,

D28811: WIP: Use CSS grid to improve layout

2020-04-13 Thread Carl Schwan
ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R264 KApiDox BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED F

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb updated this revision to Diff 80155. ognarb added a comment. - Add drawer on mobile (with JS) - Fix some layout issues REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80057&id=80155 BRANCH flex-grid REVISION DETAIL https://phabricator

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb updated this revision to Diff 80156. ognarb added a comment. Add NoScript support REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80155&id=80156 BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED FILES src/k

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added reviewers: cblack, ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngrah

D28811: Add drawer on mobile and clean code

2020-04-14 Thread Carl Schwan
ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to "Add drawer on mobile and clean code". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. In D28811#648700 , @ochurlaud wrote: > I really dislike how you close brackets in css : it's more dense and harder to read. > > You indent sometimes with 1,2 or 3 spaces: it sh

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb added a comment. POC of sharing this code with the wikis: https://wikisandbox.kde.org/Welcome_to_KDE_TechBase REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gen

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb updated this revision to Diff 80228. ognarb added a comment. This revision is now accepted and ready to land. - Use version from cdn REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80156&id=80228 BRANCH flex-grid REVISION DETAIL https:/

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb updated this revision to Diff 80229. ognarb added a comment. - Fix typo in path - Add information about there to find the source of the css files REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80228&id=80229 BRANCH flex-grid REVISION D

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb added a comment. I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. And all tree wikis are using it. @ochurlaud should I create a sysadmin request for you to get access to the repo in

D29049: add telephant icon

2020-04-21 Thread Carl Schwan
ognarb added a reviewer: muesli. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. Good idea to improve the default HTML file. Improvement ideas: - Don't include `

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb added a comment. In D29084#654489 , @gszymaszek wrote: > In D29084#654484 , @ognarb wrote: > > > - Don't include `

D28811: Add drawer on mobile and clean code

2020-04-23 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28811?vs=80229&id=81051#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST

D29511: Label: Add ping-pong logic

2020-05-07 Thread Carl Schwan
ognarb requested changes to this revision. ognarb added a comment. This revision now requires changes to proceed. I'm not sure it is a good idea, but at least for me it break the clock in my panel. F8294594: vokoscreenNG-2020-05-07_17-49-49.mkv REP

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 and also +1 for removing python2 support REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochur

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Carl Schwan
ognarb added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallba

D29802: Require in-source build

2020-05-16 Thread Carl Schwan
ognarb accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb Cc: kde-frameworks-devel, LeGast00n,

Re : KApiDox move from dedicated server to Jenkins

2021-09-10 Thread Carl Schwan
Le vendredi 10 septembre 2021 à 7:23 PM, Frederik Schwarzer a écrit : > Hi, Hi :D > we have been working on getting KApiDox to run on Jenkins. This work has > been taken way longer than I expected but has now reached a state close > to finished. :) > > So I would like to invite you to check ht

Re: QML API docs for C++ wrapper types?

2021-09-19 Thread Carl Schwan
Le vendredi 17 septembre 2021 à 3:23 PM, Volker Krause a écrit : > Hi, > do we have an example somewhere how to do API docs markup properly for C++ > wrappers for QML APIs? I don't think we have and it's currently with Doxygen a bit hard to do something similar to the Qt documentation with a se

Respin request Kirigami

2021-10-04 Thread Carl Schwan
Hello, Please include https://invent.kde.org/frameworks/kirigami/-/commit/e7ffa04038307efef10c1682042e795d4a32a935 This fixes some nasty bugs for the Kirigami settings component. Carl Schwan https://carlschwan.eu

Re: Respin request Kirigami

2021-10-11 Thread Carl Schwan
Le lundi 11 octobre 2021 à 11:43 AM, David Faure a écrit : > On lundi 4 octobre 2021 12:39:35 CEST Carl Schwan wrote: > > > Please include > > https://invent.kde.org/frameworks/kirigami/-/commit/e7ffa04038307efef10c168 > > 2042e795d4a32a935 > > > > This fi

Re: Respin request Kirigami

2021-10-11 Thread Carl Schwan
Le lundi 11 octobre 2021 à 12:56 PM, David Faure a écrit : > On lundi 11 octobre 2021 12:46:04 CEST Carl Schwan wrote: > > > I don't think it is so urgent that we need a 5.87.1 version of > > Kirigami. So it can't wait a month. > > Do you mean "it can

Re : Re: KF6 meeting notes 2021-12-07

2021-12-08 Thread Carl Schwan
Le mercredi 8 décembre 2021 à 11:26 AM, David Redondo a écrit : > Am Dienstag, 7. Dezember 2021, 18:04:19 CET schrieb Volker Krause: > > > https://phabricator.kde.org/T11587 > > > > - there are bigger plans to rework color scheming, this needs more > > coordination with the effort to down-

Re: Breeze and ECM are incompatible for installing icons

2023-11-03 Thread Carl Schwan
On Friday, November 3, 2023 12:46:20 AM CET Albert Astals Cid wrote: > El dijous, 2 de novembre de 2023, a les 14:36:16 (CET), David Jarvie va > > escriure: > > Breeze installs its icons in a different directory structure from other > > icon themes, with the result that the ECM cmake command ecm_i

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Header look like http://docs.carlschwan.eu/ Screenshot comming TEST PLAN Wasn't able

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb added reviewers: VDG, Documentation. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-06 Thread Carl Schwan
ognarb added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? I only had a png version in my hard drive, but if it's a problem I can convert the png in a jpg. In D19557#426057

D19557: Update css

2019-03-07 Thread Carl Schwan
ognarb updated this revision to Diff 53359. ognarb edited the test plan for this revision. ognarb added a comment. Change to jpg and remove now useless files REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53251&id=53359 BRANCH master REVISION

D19557: Update css

2019-03-07 Thread Carl Schwan
ognarb updated this revision to Diff 53367. ognarb added a comment. Add breeze like style for note/info/warning/tip admonitions and make image responsive REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53359&id=53367 BRANCH master REVISION DE

D19557: Update css

2019-03-07 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19620: Use a searchbar similar to the one from okular

2019-03-08 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Improve consistency between different KDE apps. It's not perfect (close button isn't aligned). Screenshot commin

D19620: Use a searchbar similar to the one from okular

2019-03-08 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added reviewers: VDG, Frameworks. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

2019-03-08 Thread Carl Schwan
ognarb updated this revision to Diff 53469. ognarb added a comment. Improve display inline media REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53367&id=53469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb retitled this revision from "Use a searchbar similar to the one from okular" to "Use a searchbar similar to the one in okular". REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. Need to remove label and add a placeholder text and clearButton REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngra

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb updated this revision to Diff 53488. ognarb edited the summary of this revision. ognarb added a comment. This revision is now accepted and ready to land. Use placeholder text and clearButton REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53468

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53505. ognarb added a comment. Add icons REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53488&id=53505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES src/ui/findbar/khtmlf

D19620: Use a searchbar similar to the one in okular

2019-03-09 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53521. ognarb added a comment. Use correct breeze color for important and warning REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53469&id=53521 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb added a comment. @aacid it is ready to land? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53541. ognarb added a comment. Use png instead of jpg REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53521&id=53541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES comm

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53542. ognarb added a comment. Change png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53541&id=53542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES common/en/

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb added a comment. In D19557#428086 , @bruns wrote: > Is it intentional the PNG is 129x129 while the JPEG is 128x128? I have no idea why 129x129. I used `convert` to convert the svg to png, just like I did with the jpg. But I will in

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53544. ognarb added a comment. Use a 128x128 png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53542&id=53544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES com

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb added a comment. Lol 128x128 png image 6kb, 129x129 png image 2kb REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, ska

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53545. ognarb added a comment. Use inkscape to generate png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53544&id=53545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53546. ognarb added a comment. Apply optipng. Thanks @bruns I learned something new :D. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53545&id=53546 BRANCH master REVISION DETAIL https://phabricator.kde

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb updated this revision to Diff 53598. ognarb added a comment. - Add deleted image - Rename top-kde.png to kde.png - Fix strange margin issues for some elements @rooty The font can be changed in the khelpcenter settings. But it's strange that it doesn't use Plasma settings per de

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb updated this revision to Diff 53603. ognarb added a comment. Don't change image size REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53598&id=53603 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES com

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb added a comment. In D19557#428614 , @ltoscano wrote: > No, wait a minute. What happens with pages which are not regenerated? They use the old link for the image, also the jpg version instead of the png. I tested with new page and o

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb added a comment. In D19557#428618 , @ltoscano wrote: > In D19557#428617 , @ognarb wrote: > > > They use the old link for the image, also the jpg version instead of the png. I tested with new p

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb retitled this revision from "Update css" to "Update design to look more similar to kde.org". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #docu

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb updated this revision to Diff 53616. ognarb added a comment. Don't change image link and remove kde.png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53603&id=53616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 A

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R238:a67daca8199c: Update design to look more similar to kde.org (authored by ognarb). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53616&id=53617 REVISION

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb added a comment. In D19557#428634 , @ltoscano wrote: > Thank you! And sorry for the ping-pong. No problems ;) Thanks for the review. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb updated this revision to Diff 53906. ognarb added a comment. Remove icon to option button REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53505&id=53906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES sr

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ognarb requested review of this revision. REVISION SUMMARY See https://hig.kde.org/style/writing/placeholder.html Also change Find -> Search in Search and rep

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb updated this revision to Diff 53922. ognarb added a comment. Use proper Unicode ellipsis REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19771?vs=53919&id=53922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19771 AFFECTED FILES

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms. So the ch

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb updated this revision to Diff 53928. ognarb added a comment. Use Unicode ellipsis REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53906&id=53928 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES src/ui/fin

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham

D19771: Use placeholder instead of label

2019-03-16 Thread Carl Schwan
ognarb added a comment. > I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think. The advantage of using the unicode ellipsis character, is that thi

D19895: Use https for links in the UI and documentation

2019-03-19 Thread Carl Schwan
ognarb added a comment. I made sure that all the links are still working. So +1 INLINE COMMENTS > kproxydlg.ui:45 > Automatic detection is performed using the Web Proxy Auto-Discovery > Protocol (WPAD).

> -NOTE: This option might not work properly or not work at > all in s


D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

2019-05-14 Thread Carl Schwan
ognarb added a comment. Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg Cc: ognarb, kde-frameworks-de

D19771: Use placeholder instead of label

2019-05-23 Thread Carl Schwan
ognarb added a comment. Hi, I try to find time to look into it this weekend ;). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson, micha

D19771: Use placeholder instead of label

2019-06-04 Thread Carl Schwan
ognarb abandoned this revision. ognarb added a comment. I don't have time and the motivation for this revision anymore. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-dev

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Inspired from application-edu and cantor icon TEST PLAN Screenshot comming REPOSITORY R266 Breeze Icons BRANCH kb

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb updated this revision to Diff 59131. ognarb added a comment. Add shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59123&id=59131 BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 AFFECTED FILES icons/apps/48

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb added a comment. In D21574#474171 , @ndavis wrote: > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons. Sorry it arc who also uploaded the png that I created for the review, I will fix it. REPO

D21574: Update KBruch icon

2019-06-05 Thread Carl Schwan
ognarb updated this revision to Diff 59187. ognarb added a comment. - Optimize icon with scour-icon - Copy icon to breeze-dark - Remove png REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59131&id=59187 BRANCH kbruch REVISION DETAIL h

D21574: Update KBruch icon

2019-06-05 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

2019-06-05 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59187&id=59189 REVISION DETAIL https://phabric

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES icons-dark/apps/48/kf

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb updated this revision to Diff 59372. ognarb added a comment. Crop shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59371&id=59372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES icons-dark/a

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb updated this revision to Diff 59706. ognarb added a comment. Still works in progress (need to add the gradiend) but some improvement REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59372&id=59706 BRANCH master REVISION DETAIL https

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb updated this revision to Diff 59707. ognarb added a comment. Change color of some points REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59706&id=59707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILE

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb updated this revision to Diff 59720. ognarb added a comment. Use more round corner. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59707&id=59720 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES i

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

  1   2   >