D28739: Close the database connection to prevent file descriptor leak

akandaurov created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. akandaurov requested review of this revision. REVISION SUMMARY The connection to the database doesn't get closed, which leads to a leakage of file descriptors

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. loadMimeTypeIcon isn't deprecated, so what's the reason? Porting away from kiconthemes? Should we actually deprecate it? REPOSITORY R241 KIO BRANCH rena REVISION DETAIL https://phab

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The new code structure screams for killing the bool and just extracting the code (all of slotReparseSlaveConfiguration) to a different method, called directly from emitReparseSlaveConfigura

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

dfaure added a comment. In D28478#645019 , @ahmadsamir wrote: > hmm... first this is a copy-paste "error" on my part, I personally never use & when the RHS is a temporary (I don't see the point). The point is to avoid a copy ;-) If

D28734: Port to Aether Bootstrap 4

ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. OK for me REPOSITORY R264 KApiDox BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kd

D28271: [KFontChooser] More code cleanup

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel

D28679: [KPropertiesDialog] Disable changing remote dir icons

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kpropertiesdialog.cpp:1285 > +// exclude remote dirs as changing the icon has no effect (bug > 205954) > +if (item.isLocalFile()|| item.url().scheme() =

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

ahmadsamir added a comment. In D25707#645676 , @dfaure wrote: > loadMimeTypeIcon isn't deprecated, so what's the reason? Porting away from kiconthemes? Should we actually deprecate it? It's been going on for a while https://phabricator.kd

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

dfaure added a comment. OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. I remember wondering the same thing at one point. REPOSITORY R241 KIO BRANCH rena REVISION DETAIL https://p

D28739: Close the database connection to prevent file descriptor leak

akandaurov added a reviewer: ivan. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added inline comments. INLINE COMMENTS > kfileitem.h:349 > + * > + * Initialy only implemented for trash:/ > + * typo: Initially > trashimpl.cpp:1099 > + > +info = QFileInfo(trashPath); > +modified = info.lastModified(); Reusing info is more expensive (and le

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added a comment. In D28478#645682 , @dfaure wrote: > In D28478#645019 , @ahmadsamir wrote: > > > hmm... first this is a copy-paste "error" on my part, I personally never use & when the RH

D28271: [KFontChooser] More code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R236:11589f5e4166: [KFontChooser] More code cleanup (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28271?vs=78986&id=79812 REVISION DET

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 79813. meven marked 4 inline comments as done. meven added a comment. Fix typo, avoid allocations, improve variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24773?vs=79804&id=79813 BRANCH arcpatch-D24773_1 RE

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

dfaure added a comment. Nice work. But can you give the reasoning for removing the comment column? For non-english speakers this might be the only thing that's actually readable? I'm also curious about the use of QStandardItemModel which I consider to be at best a class for unittesting p

D28679: [KPropertiesDialog] Disable changing remote dir icons

ahmadsamir updated this revision to Diff 79814. ahmadsamir added a comment. Rebase; fix coding style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28679?vs=79766&id=79814 BRANCH l-kprop (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D28679: [KPropertiesDialog] Disable changing remote dir icons

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a2335335ecfe: [KPropertiesDialog] Disable changing remote dir icons (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28679?vs=79814&id=79815 RE

Update on Status of Gitlab Migration

Good morning Community, I'm pleased to report that this week we reached a major milestone, with all the necessary technical components now being in place on our side for our migration to Gitlab to take place. This includes the replacement of the tooling that supports the anongit network, as well

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:24:45 + Build duration: 11 min and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:25:03 + Build duration: 13 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:25:27 + Build duration: 14 min and counting JUnit Tests Name: projectroot Fai

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

dfaure added a comment. In D28478#645702 , @ahmadsamir wrote: > I meant something like: > const int i = foo(); int is a very bad example for this reasoning. It's cheaper to copy an int than to use a reference. That's not the case for

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:25:16 + Build duration: 17 min and counting JUnit Tests Name: proje

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 09:23:56 + Build duration: 22 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:28:23 + Build duration: 26 min and counting BUILD ARTIFACTS abi-compatibility-r

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/45/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:27:07 + Build duration: 30 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:29:19 + Build duration: 29 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:28:23 + Build duration: 32 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:24:01 + Build duration: 37 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 536 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/536/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:27:07 + Build duration: 35 min and counting BUILD ARTIFACTS acc/KF5KIO-5.70.0.xmllog

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:28:46 + Build duration: 34 min and counting JUnit Tests Name: projectroot Fail

D28739: Close the database connection to prevent file descriptor leak

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Nice patch INLINE COMMENTS > FileItemLinkingPluginActionLoader.cpp:88 > + > +{ > auto database = QSqlDatabase::addDatabase( Do you really need to have block opened

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 124 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/124/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:29:38 + Build duration: 34 min and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 128 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/128/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:29:44 + Build duration: 35 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » ktextwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:29:18 + Build duration: 37 min and counting JUnit Tests Name: projectr

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added a comment. In D28478#645717 , @dfaure wrote: > In D28478#645702 , @ahmadsamir wrote: > > > I meant something like: > > const int i = foo(); > > > int is a very bad example f

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven retitled this revision from "Add a QString Solid::Device::DisplayName, used in Fstab Device for network mounts" to "Add a QString Solid::Device::displayName, used in Fstab Device for network mounts". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven,

D28590: Add a QString Solid::Device::DisplayName, used in Fstab Device for network mounts

meven retitled this revision from "Add a QString Solid::Device::label, used in Fstab Device for network mounts" to "Add a QString Solid::Device::DisplayName, used in Fstab Device for network mounts". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frame

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/89/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:31:27 + Build duration: 38 min and counting BUILD ARTIFACTS abi-compatibility-res

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:29:11 + Build duration: 43 min and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 129 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 10:05:17 + Build duration: 6 min 52 sec and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:29:38 + Build duration: 44 min and counting JUnit Tests Name: projectroot.

Notice of upcoming changes to the behaviour of the anongit network

Hi all, As part of the preparations for the move to Gitlab, and the rewrite of our anongit tooling, one of the things we have looked into is how the anongit network in general operates. As part of this, it has been observed that the git:// protocol is unencrypted, and thus vulnerable to intercept

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:24:46 + Build duration: 56 min and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:31:28 + Build duration: 53 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:31:22 + Build duration: 53 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/37/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:27:07 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS acc/KF5KIO-5.70.0.xml

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/46/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:57:57 + Build duration: 33 min and counting JUnit Tests Name: projectroot Faile

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:28:23 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:29:18 + Build duration: 1 hr 7 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:29:12 + Build duration: 1 hr 14 min and counting BUILD ARTIFACTS abi-compatib

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > To help assist with this, it would be appreciated if all holders of a > KDE Developer account could please login on our Gitlab instance (at > https://invent.kde.org/) and ensure they are listed as a 'Developer' > of the KDE group. You can do

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. I thought that adding the "comment" as a tooltip makes sure it's always available if the dialog is shown with the flag for the comment column unset... but looking on lxr.kde all the usage of KMimeTypeChooserDialog always

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:31:27 + Build duration: 1 hr 18 min and counting BUILD ARTIFACTS abi-compatibility

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This allows to simplify code from KDialogJobUiDelegate *del

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

broulik added a comment. +1 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Requires: D28741 TEST PLAN

D28743: Port kruntest to ApplicationLauncherJob

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY NO_CHANGELOG TEST PLAN The "run(doesnotexist, no url)" button s

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

dfaure added a comment. In D28675#645733 , @ahmadsamir wrote: > A tooltip isn't good enough here? I don't know. I don't claim to be a UI expert. But for instance your lineedit could filter on the comment as well, to help the user locat

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > Should anyone have any questions on the above, please let us know. > Does the migration also mean that `git.kde.org` push URL will be retired and would need to be remapped to `invent.kde.org`? In that case, it would be good to have a grace

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

dfaure added a comment. CI doesn't like this commit. https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/4/testReport/junit/projectroot/autotests/ktextwidgets_kfindtest/ FAIL! : TestKFind::testStaticFindRegexp(whole words ok) Compared values are not the

D20749: autotests: don't fail appstream test because of anything on stderr

dfaure added a comment. Similar to this... is it expected that a glib error makes the test fail? Is the error severe or harmless? CMake Error at /home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 SUSEQt5.12/autotests/kpackagetoolappstreamtest.cmake:45 (message): appstream data see

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

ahmadsamir added a comment. I'll look into it. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D27097 To: ahmadsamir, #frameworks, mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 79823. ahmadsamir added a comment. Handle the case where KFontChooser::FixedFontsOnly is set, the fixedOnlyCheckBox should be shown as "checked" from the get go. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D28406: Fix sonnet autodetect test failure

dfaure commandeered this revision. dfaure edited reviewers, added: waqar; removed: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R246:78450298149e: Fix sonnet autodetect test failure (authored by waqar, committed by dfaure). CHANGED PRIOR TO COMMIT

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 57 sec and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 2 min 1 sec and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 90 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/90/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.14 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.14/21/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 1 min 57 sec and counting JUnit Tests Name:

D28406: Fix sonnet autodetect test failure

dfaure added a comment. I pushed it with my changes included. The test is fixed: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/sonnet/job/kf5-qt5%20SUSEQt5.12/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaur

D28406: Fix sonnet autodetect test failure

waqar added a comment. In D28406#644383 , @dfaure wrote: > @waqar ping? What do you think about my suggestion? If you agree, can you update the patch? Sorry I have been really busy at work, and overlooked the last email. I did plan to wo

D28739: Close the database connection to prevent file descriptor leak

akandaurov updated this revision to Diff 79827. akandaurov added a comment. Added indentation. The block is suggested by the Qt Documentation . Without it, a warning will be thrown: QSqlDatabasePrivate::removeDatabase: connection

D28745: Skipping catching of thumbnails on encrytped filesystems

marcingu created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY When generating thumbnails for directory, don't cache the previews for files stored on encrypted fi

D28746: Show previews on encrypted filesystems

marcingu created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY Instead of skipping generating previews on encrypted filesystems, do create them but don't cache. BUG: 411919 REPO

D28746: Show previews on encrypted filesystems

marcingu added a dependent revision: D28745: Skipping catching of thumbnails on encrytped filesystems. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28745: Skipping catching of thumbnails on encrytped filesystems

marcingu added a dependency: D28746: Show previews on encrypted filesystems. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D28739: Close the database connection to prevent file descriptor leak

akandaurov marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spo

D28737: Add sim card device icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:95ebf0c1d3ea: Add sim card device icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28737?vs=79800&id=79839 REVISION DETAIL https:/

D28726: [KJS] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28726 To: ahmadsamir, #frameworks, porten, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB

D28739: Close the database connection to prevent file descriptor leak

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Too bad we have so many lines to change. Could you maybe add some context to your commit comment like `activities: Close the database connection to prevent file descriptor leak` LGTM

D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov retitled this revision from "Close the database connection to prevent file descriptor leak" to "activities: Close the database connection to prevent file descriptor leak". REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D28743: Port kruntest to ApplicationLauncherJob

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added inline comments. INLINE COMMENTS > kdialogjobuidelegate.h:51 > + */ > +KDialogJobUiDelegate(KJobUiDelegate::Flags flags); // KF6 TODO merge > with default constructor, using AutoHandlingDisabled as default value > + Why no explicit? REPOSITORY R288 KJobWidgets BRANCH

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kdialogjobuidelegate.h:51 > Why no explicit? good point REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmu

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 1 min 38 sec and counting JUnit Tests Name: pro

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure updated this revision to Diff 79840. dfaure marked an inline comment as done. dfaure added a comment. explicit REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28742?vs=79820&id=79840 BRANCH master REVISION DETAIL https://phabricator.kde.org/

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 181 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/181/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 3 min 10 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 13:50:17 + Build duration: 1 min 29 sec and counting JUnit Tests Name: pro

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS abi-compatib

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Builds REPOSITORY R289 KNotifications BRANCH master REVISION DETAI

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 182 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/182/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 13:51:49 + Build duration: 3 min 9 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 13:51:54 + Build duration: 2 min 51 sec and counting BUILD ARTIFACTS abi-compat

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kfontchooser.cpp:393 > q->setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont), > usingFixed); > +onlyFixedCheckbox->setChecked(usingFixed); > } else { would `true` be more readable? (sa

D28755: Breeze Icons cannot be built from read-only source location

marten created this revision. marten added a reviewer: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY In the situation, for example, where a master source tree may be shared among a number o

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, b

  1   2   >