D27839: Properly name the content of the kcmcontrols project

2020-03-06 Thread Méven Car
meven accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-06 Thread Méven Car
meven updated this revision to Diff 77064. meven marked 2 inline comments as done. meven added a comment. Fix comment and formatting REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77006&id=77064 BRANCH arcpatch-D27463_2 REVISION DETAIL https:

D27882: Move KProcessRunner into it's own file

2020-03-06 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Just for readability, krun.cpp was too long. There are no code changes TEST PLAN N/A REPOSITORY

D27883: Register spawned applications as an independent cgroups

2020-03-06 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Having each application in it's own scope brings numerous advantages: - PIDs are very yesteryear, a m

D27112: Fix errors in the QRegularExpression porting commit

2020-03-06 Thread Ahmad Samir
ahmadsamir added a comment. Can I land this? I keep getting side tracked and I haven't written those unit tests, but until then I hate leaving this broken. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kd

D27112: Fix errors in the QRegularExpression porting commit

2020-03-06 Thread David Rosca
drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_

D27355: POC: Make kstatusnotifieritem available without dbus

2020-03-06 Thread Hannah von Reth
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R289:e369e43b807e: Make kstatusnotifieritem available without dbus (authored by vonreth). REPOSITORY R289 KNotifications

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 84 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/84/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 09:42:42 + Build duration: 59 sec and counting CONSOLE OUTPUT [...trunc

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-03-06 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-06 Thread Kevin Ottens
ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, please fix the typo in the docs before pushing though INLINE COMMENTS > README.dox:372 > > +Since 5.68, if present the value attribute will be used used as the > choice value written

D27872: sftp: fix partial transfer resuming when copying to local

2020-03-06 Thread Harald Sitter
sitter updated this revision to Diff 77076. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27872?vs=77037&id=77076 BRANCH sftp-resume-to-local REVISION DETAIL https://phabricator.kde.org/D27872 AFFECTED FILES sftp/kio_s

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-06 Thread Méven Car
meven updated this revision to Diff 77077. meven added a comment. Fix typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77064&id=77077 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES autotests/k

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-06 Thread Kevin Ottens
ervin accepted this revision. REPOSITORY R237 KConfig BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27873: sftp: do not show creation time when we do not know it

2020-03-06 Thread Harald Sitter
sitter updated this revision to Diff 77080. sitter added a comment. use flaggy REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77039&id=77080 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sf

D27887: Fix config include

2020-03-06 Thread Hannah von Reth
vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27887 AFFECTED FILES src/kstatusnotifi

D27887: Fix config include

2020-03-06 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27887 To: vonreth, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, G

D27887: Fix config include

2020-03-06 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R289:3d455200c586: Fix config include (authored by vonreth). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27887?vs=77081&id=77083 REVISION DETAIL https://phab

KDE CI: Frameworks » knotifications » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Fixed!

2020-03-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 10:56:39 + Build duration: 1 min 46 sec and counting

D27357: Fix infinite recursion in xscreensaver plugin

2020-03-06 Thread Aleksei Nikiforov
alnikiforov added a comment. Could you please merge this change? Or is something stopping from merging it? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2

D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Hannah von Reth
vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 AFFECTED FILES src/kstatusnotifi

D27112: Fix errors in the QRegularExpression porting commit

2020-03-06 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R269:408bdaa752fa: Fix errors in the QRegularExpression porting commit (authored by ahmadsamir). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27112?vs=77096&id=77097

D27112: Fix errors in the QRegularExpression porting commit

2020-03-06 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77096. ahmadsamir added a comment. Rebase REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27112?vs=74880&id=77096 BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27112 AFFECTED

D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Hannah von Reth
vonreth added reviewers: broulik, bcooksley, jjazeix, cullmann. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

2020-03-06 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Add KF6 TODO about removing KURIFilterModule::load(), it's been redundant for a long time (circa 2014). T

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

2020-03-06 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kcms-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27894 To: ahmadsamir, #frameworks, dfaure, meven, davidedmundson Cc: kde-frameworks-devel,

D27357: Fix infinite recursion in xscreensaver plugin

2020-03-06 Thread Kai Uwe Broulik
broulik added a comment. Sorry, I just returned from vacation. I'll merge this on Monday (since Frameworks tagging is tomorrow) so we'll get another month worth of testing. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, brou

D27894: [src/kcms/*] Replace foreach (deprecated) with range/index-based for

2020-03-06 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d617bb704d1f: [src/kcms/*] Replace foreach (deprecated) with range/index-based for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27894?vs=770

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 316 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/316/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 13:04:21 + Build duration: 8 min 47 sec and counting JUnit Tests Name: projectro

D26969: fix type namespace requirement

2020-03-06 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. This is rather horrible, but at the same time makes a lot of sense. One minor comment, but then, ship it I guess. INLINE COMMENTS > DBusHelperProxy.cpp:273 > +Q

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

2020-03-06 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27898 AFFECT

D27900: smb: fix wsdiscovery unknown device fallback string

2020-03-06 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY wasn't using xi18n so wasn't parsed as markup but rather used verba

D27901: smb: do not leak pbsd resolvers

2020-03-06 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY parent them to the discoverer. discoverer lives on the stack and is un

D27902: smb: figure out the best host to use for the UDS_URL

2020-03-06 Thread Harald Sitter
sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly awkwar

D27800: smb: split module into two targets of which one is a static lib

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:d101d916e324: smb: split module into two targets of which one is a static lib (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27800?vs=76829

D27802: smb: fix ipv6 support

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:bb83a071e0da: smb: fix ipv6 support (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27802?vs=76915&id=77120 REVISION DETAIL https://phabri

D27835: sftp: fix free space query for urls with empty path

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:5cfd852a975e: sftp: fix free space query for urls with empty path (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27835?vs=76940&id=77117#toc REPOSITORY R320 KIO Extras

D27801: smb: add a unit test for smburl

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:d8d92670372a: smb: add a unit test for smburl (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76935&id=77119 REVISION DETAIL htt

D27901: smb: do not leak pbsd resolvers

2020-03-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-resolver-leak REVISION DETAIL https://phabricator.kde.org/D27901 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27883: Register spawned applications as an independent cgroups

2020-03-06 Thread Nathaniel Graham
ngraham added a task: T12678: Scope applications into transient services . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27883 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27900: smb: fix wsdiscovery unknown device fallback string

2020-03-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-unknowndevice REVISION DETAIL https://phabricator.kde.org/D27900 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27900: smb: fix wsdiscovery unknown device fallback string

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:6557c6b4793d: smb: fix wsdiscovery unknown device fallback string (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27900?vs=77112&id=77127 R

D27901: smb: do not leak pbsd resolvers

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:1eacae5267e3: smb: do not leak pbsd resolvers (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27901?vs=77113&id=77126 REVISION DETAIL htt

D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-06 Thread Harald Sitter
sitter added a comment. In D27871#622933 , @bruns wrote: > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff the file where opened with O_NONBLOCK. All other seek errors are fatal."). I do

D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-06 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > You should save errno immediately after QT_LSEEK, otherwise any function may > overwrite it. See `man 3 errno`: > > > A common mistake is to do > > > > if (somecall() == -1) { > > printf("somecall() fail

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-06 Thread Volker Krause
vkrause updated this revision to Diff 77128. vkrause added a comment. Alternative implementation for the barcode dimension API. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=76661&id=77128 BRANCH pending REVISION DETAIL https://phabricator.kd

D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Ben Cooksley
bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-fr

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-06 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. thanks. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michael

D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Johnny Jazeix
jjazeix accepted this revision. jjazeix added a comment. same, good and cleaner. Thank you! REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-frameworks-devel, LeGast00n, cblack, G

D27873: sftp: do not show creation time when we do not know it

2020-03-06 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please correct the comment in the code - it depends on the server SFTP implementation. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter

D27872: sftp: fix partial transfer resuming when copying to local

2020-03-06 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1935 > > -if (bMarkPartial && bPartExists && copyFile.size() > 0) { > +if (bMarkPartial && bPartExists && partFile.size() > 0) { >

D27660: Add Inno Setup syntax, including embedded Pascal scripting

2020-03-06 Thread Michael Hansen
zrax updated this revision to Diff 77133. zrax added a comment. Relicense as MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27660?vs=76398&id=77133 BRANCH innosetup (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-06 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > sitter wrote in kio_sftp.cpp:1687 > Which call between the seek and the debug do you take offense here exactly? qCDebug(), operator<< REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27871 To: sitter, ngraham, feverfew

D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-06 Thread Stefan Brüns
bruns added a comment. In D27871#623542 , @sitter wrote: > In D27871#622933 , @bruns wrote: > > > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff th

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

2020-03-06 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27898 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, G

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2020-03-06 Thread David Faure
dfaure added a comment. Or upload a patch :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik, #frameworks, dfaure, michaelh, mlaurent Cc: ngraham, kde-frameworks-devel, juansimon, LeGast00n, cblack, GB_2, michaelh, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kfilefiltercombo.cpp:156 > +if (!type.isValid()) { > +qCDebug(KIO_KFILEWIDGETS_KFILEFILTERCOMBO) << *it << "is not a > valid mimeType"; > +continue; IMHO it's a programmer error so it should be a qCWarning (visible

D27898: [autotests/*] Port foreach (deprecated) to range-based for loop

2020-03-06 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e9f2cf0685df: [autotests/*] Port foreach (deprecated) to range-based for loop (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27898?vs=77108&id

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77139. ahmadsamir added a comment. Rebase. Per dfaure's recommendation use qCWarning instead of qCDebug, the former is visible by default, which makes sense for a programmer error (feeding the open file dialog invalid mimeTypes). REPOSITORY R241 KIO

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 317 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/317/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 21:36:31 + Build duration: 8 min 55 sec and counting JUnit Tests Name: projectro

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis
ndavis updated this revision to Diff 77142. ndavis added a comment. - Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26595?vs=73316&id=77142 BRANCH arcpatch-D26595 (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: ndavis, #vdg, cblack Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27614: build: fix the build where install prefix is not user-writable

2020-03-06 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:17 > +add_custom_target(breeze-generate-24px-versions-dark ALL > +COMMAND ${BASH_EXE} ${CMAKE_SOURCE_DIR}/generate-24px-versions.sh > ${CMAKE_CURRENT_BINARY_DIR}/generated/ > WORKING_DIRECTORY ${CMAKE_CURRENT_SOU

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL https://phabricator.kde.org/D27865 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik Cc: kde-frameworks-devel, LeG

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-06 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH l-kconfiggui (branched from master) REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport Cc: kde-fra

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 160 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/160/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 22:58:37 + Build duration: 3 min 25 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 154 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/154/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 22:58:37 + Build duration: 4 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 101 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 06 Mar 2020 22:58:44 + Build duration: 5 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 268 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/268/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 06 Mar 2020 22:58:36 + Build duration: 5 min 18 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 57 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/57/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 22:59:51 + Build duration: 11 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 113 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/113/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:00:51 + Build duration: 14 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/82/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:01:29 + Build duration: 15 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/61/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:01:38 + Build duration: 18 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:01:59 + Build duration: 17 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 9 - Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/9/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 22:59:42 + Build duration: 25 min and counting JUnit Tests Name: pr

KIO: try to assign an icon to action submenus

2020-03-06 Thread Chloe Kudryavtsev
Currently, action submenus (X-KDE-Submenu) have no icons. This patch makes it inherit the icon of the first action. There will always be at least one action, since empty submenus are eliminated earlier in the function. If the icon of the first action is empty, it will gracefully revert to old behav

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 318 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/318/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:04:04 + Build duration: 31 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 57 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/57/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:05:26 + Build duration: 36 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:05:56 + Build duration: 38 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 67 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/67/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 22:58:45 + Build duration: 48 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 119 - Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/119/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:00:52 + Build duration: 51 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Fixed!

2020-03-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.14/7/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:03:35 + Build duration: 52 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:07:12 + Build duration: 50 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Fixed!

2020-03-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:07:21 + Build duration: 50 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Mar 2020 23:08:55 + Build duration: 56 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.13 - Build # 67 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.13/67/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:08:55 + Build duration: 1 hr 2 min and counting CONSOLE OUTPUT Started by an SCM ch

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.13 - Build # 72 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:08:44 + Build duration: 1 hr 2 min and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » prison » kf5-qt5 SUSEQt5.13 - Build # 44 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20SUSEQt5.13/44/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:08:27 + Build duration: 1 hr 2 min and counting CONSOLE OUTPUT Started by an SCM c

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 115 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/115/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:08:37 + Build duration: 1 hr 2 min and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:06:43 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 125 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/125/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:09:20 + Build duration: 1 hr 3 min and counting CONSOLE OUTPUT Start

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.14 - Build # 27 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.14/27/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:06:37 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwindowsystem » kf5-qt5 WindowsMSVCQt5.14 - Build # 10 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20WindowsMSVCQt5.14/10/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:07:26 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 23 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/23/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:06:25 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT Sta

KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.13 - Build # 45 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.13/45/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:09:27 + Build duration: 1 hr 3 min and counting CONSOLE OUTPUT Started by an

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.14/8/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:07:02 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT Start

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20WindowsMSVCQt5.14/8/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:07:42 + Build duration: 1 hr 4 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » krunner » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20WindowsMSVCQt5.14/8/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:06:16 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT Start

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 191 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/191/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:08:21 + Build duration: 1 hr 3 min and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 SUSEQt5.13 - Build # 38 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 06 Mar 2020 23:08:10 + Build duration: 1 hr 3 min and counting CONSOLE OUTPUT Started by a

KDE CI: Frameworks » kross » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kross/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 06 Mar 2020 23:06:10 + Build duration: 1 hr 5 min and counting CONSOLE OUTPUT Started

  1   2   >