D12130: Use the more user-friendly string "File format" in the open/save dialogs

alexeymin accepted this revision. alexeymin added a comment. +1, looks better REPOSITORY R241 KIO BRANCH file-format-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin Cc: alexeymin, abetts, bruns, michaelh,

D12120: Check if the application androiddeployqt package has a main() symbol

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Just tested that my 64bit host nm can also consume 32bit ARM binaries, seems to work, so not using the corresponding toolchain nm is probably fine here. REPOSITORY R240 Extra CMake Modu

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. Given the other reviews (which just drop this function), this one should be abandoned. tcberner@? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov,

D12135: Allow disabling of CoW to fail when not supported by filesystem

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Accepted as "doesn't hurt the non-Linux crowd, since they all live in the #ifndef Q_OS_LINUX branch" REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https:/

D12136: Avoid hardcoding of filesystems supporting CoW

adridg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH disble_cow_unconditionally REVISION DETAIL https://phabricator.kde.org/D12136 To: bruns, #baloo, adridg Cc: #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngr

D12130: Use the more user-friendly string "File format" in the open/save dialogs

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. > BUG: 79904 @bruns @alexeymin I'm not sure you have reviewed this change properly? This bug is about "MacOS styled menus and remote X sessions". If you "Accept" a revision, to

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 65 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/65/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 12 Apr 2018 08:58:30 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/15/ Project: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 12 Apr 2018 09:00:19 + Build duration: 39 sec and counting CONSOLE OU

Windows CI KO until further notice

Hi all, Due to a regression of unknown origin which results in meinproc being unusable, all Windows builds which are dependent on kdoctools are currently KO on Windows. This breakage was introduced sometime shortly after the new builders became operational (but was working at that time). Until s

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/16/ Project: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 12 Apr 2018 09:37:39 + Build duration: 2 min 8 sec and counting JUnit

D12120: Check if the application androiddeployqt package has a main() symbol

This revision was automatically updated to reflect the committed changes. Closed by commit R240:8e2ce83987d2: Check if the application androiddeployqt package has a main() symbol (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 66 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/66/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 12 Apr 2018 09:38:50 + Build duration: 9 min 57 sec and counting

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

broulik added inline comments. INLINE COMMENTS > udisksdevicebackend.cpp:147 > +if (size.isValid() && size.toInt() != 0) { > +m_propertyCache.insert(QStringLiteral("Size"), size); > +} So when size is unknown it will always query it as you will

D12123: [UDisks] Optimize several property checks

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > udisksdevice.cpp:840 > { > -return propertyExists("MountPoints") && > !qdbus_cast(prop("MountPoints")).isEmpty(); > +QVariant mountPoints = prop(QStringLiter

D12127: Do not query properties when no interfaces are left

broulik added a comment. Lgtm. But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12127 To: bruns, #frameworks Cc: broulik, michaelh, ngraham, bruns

D12144: Fix kpackage autotests - add donation url to test data

joselema created this revision. joselema added reviewers: apol, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, Right now the unit tests from kpackage master br

D12144: Fix kpackage autotests - add donation url to test data

joselema added a subscriber: rikmills. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D12144 To: joselema, apol, aacid Cc: rikmills, #frameworks, michaelh, ngraham, bruns

D12145: autotests: Do not use QScopedPointer for plugins

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. TEST PLAN make && make test REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from

D12028: taglibextractortest: Add test for files with empty metadata

michaelh added inline comments. INLINE COMMENTS > bruns wrote in taglibextractortest.cpp:231 > What he likely meant: > `TagLibExtractor plugin{this};` > instead of > `QScopedPointer plugin(new TagLibExtractor(this));` Well,... In that case: D12145 REPOSITORY

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 31968. michaelh added a comment. - Simple plugin variable REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12028?vs=31934&id=31968 BRANCH nometa (branched from master) REVISION DETAIL https://phabricator.kde.

D12028: taglibextractortest: Add test for files with empty metadata

michaelh marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: bruns, astippich, ashaposhnikov, michaelh, spoorun, ngraham, alexeymin

D12124: Avoid creating duplicate property entries in the cache

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Wouldn't make a big difference, would it? > If there are multiple items for key in the map, the value of the most recently inserted one is returned. It's not like we actually che

D12126: Invalidate property cache when an interface is removed

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH invalidate_on_lost_interface REVISION DETAIL https://phabricator.kde.org/D12126 To: bruns, #frameworks, broulik Cc: michaelh, ngraham, bruns

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 31972. michaelh added a comment. - (Prematurely) rebased on origin/master From now on `-DBUILD_EXPERIMENTAL=on` is needed to build - Remove unnecessary includes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=

D12144: Fix kpackage autotests - add donation url to test data

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D12144 To: joselema, apol, aacid Cc: rikmills, #frameworks, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch improves the grid spacing in icons-on-top mode by making it looser for small icons (which gi

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: michaelh, ngraham, bruns

D11745: databasesanitizer: Use flags for filtering

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, alexeymin

D11753: baloodb: Add clean command

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

alexeymin added a comment. New version looks much better, no doubt. The only thing you may be asked about here is magical number 120, what is it? Some minimum width for item? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc:

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. Yes, I'm afraid it's a magic number: the minimum width of each cell. I'm open to better approaches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D12145: autotests: Do not use QScopedPointer for plugins

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for having done it everywhere. I had missed that "detail". REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kd

D12028: taglibextractortest: Add test for files with empty metadata

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH nometa (branched from master) REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: brun

D12145: autotests: Do not use QScopedPointer for plugins

alexeymin added a comment. Just curious, why is this needed? To avoid dynamic memory allocations? REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D12145 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: alexeym

D12145: autotests: Do not use QScopedPointer for plugins

michaelh added a comment. In D12145#245023 , @alexeymin wrote: > Just curious, why is this needed? To avoid dynamic memory allocations? see D12028 . As I had copied that line, my conclusion was all or

D12145: autotests: Do not use QScopedPointer for plugins

mgallien added a comment. In D12145#245023 , @alexeymin wrote: > Just curious, why is this needed? To avoid dynamic memory allocations? I asked on new code to avoid using an extractor allocated on heap instead of on stack. @michaelh just

D12028: taglibextractortest: Add test for files with empty metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:fd378a11e424: taglibextractortest: Add test for files with empty metadata (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12028?vs=3196

KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/30/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 Date of build: Thu, 12 Apr 2018 16:02:07 + Build duration: 1 min 21 sec and counting JUnit Tes

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 12 Apr 2018 16:02:07 + Build duration: 1 min 42 sec and counting JUnit

KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.9 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.9 Date of build: Thu, 12 Apr 2018 16:02:07 + Build duration: 5 min 5 sec and counting JUnit Tests

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12150: Make it possible to build several apk out of a project

apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Refactor the apk-generating code into a separate function, in views of eventually even make it a

D12150: Make it possible to build several apk out of a project

apol updated this revision to Diff 31977. apol added a comment. Polish REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12150?vs=31976&id=31977 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12150 AFFECTED FILES toolchain/Andr

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. FWIW I wrestled with the issue prior to submitting the patch, but couldn't come up with anything better. The issue here that we really do need a minimum width of //at least// 110px or else there's simply never enough room for titles with small icons, but there's a la

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D12145: autotests: Do not use QScopedPointer for plugins

bruns added a comment. The first question is - why should we use pointers at all (raw, std::unique_ptr, QScopedPointer, ...) for objects **with local only scope**. The typical answer is Inheritance, see e.g. http://doc.qt.io/qt-5/qscopedpointer.html#details A `Base` pointer can be used

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a comment. May I have another accept/review (for the stack) from #Frameworks or #Baloo ? REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https://phabricator.kde

D12028: taglibextractortest: Add test for files with empty metadata

bruns added a comment. Untested, but looks good to me otherwise. INLINE COMMENTS > taglibextractortest.cpp:42 > > +const QStringList TagLibExtractorTest::propertyEnumNames(const > QList& keys) const > +{ Nitpick - needs some indentation REPOSITORY R286 KFileMetaData REVISION DETAIL

D11452: sanitizer: Improve device listing

bruns added a subscriber: ngraham. bruns added a comment. Looks good to me so far. If there are any issues, we can fix it up later IMHO. @ngraham as you reviewed other parts of the stack, can you do this one as well and accept? INLINE COMMENTS > databasesanitizer.cpp:257 > +<<

D12156: implement reading of rating tag

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY allows to read the rating stored in the m

D12124: Avoid creating duplicate property entries in the cache

bruns added a comment. In D12124#244924 , @broulik wrote: > Wouldn't make a big difference, would it? > > > If there are multiple items for key in the map, the value of the most recently inserted one is returned. > > It's not like we actu

D12156: implement reading of rating tag

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12028: taglibextractortest: Add test for files with empty metadata

michaelh reopened this revision. michaelh added a comment. This revision is now accepted and ready to land. Sample files are borked. https://build.kde.org/view/Frameworks/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/lastBuild/ REPOSITORY R286 KFileMetaData REVISION DETAIL https:

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns added inline comments. INLINE COMMENTS > broulik wrote in udisksdevicebackend.cpp:147 > So when size is unknown it will always query it as you will never have a Size > in the `m_propertyCache`? It uses the one from the Partition or Block Interface, see last paragraph from the Summary. It

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns added a reviewer: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns, #frameworks Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 31989. michaelh added a comment. - Recreate sample files and adapt tests for mp3, m4a, ogg, opus, flac recreate files with `$ ffmpeg -f lavfi -i anullsrc=channel_layout=stereo:sample_rate=44100 -t 1 test.` for mpc with kid3-qt remove all tags and add '

D12028: taglibextractortest: Add test for files with empty metadata

michaelh requested review of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: bruns, astippich, ashaposhnikov, michaelh, spoorun, ngraham, alexeymin

D11452: sanitizer: Improve device listing

ngraham added a comment. I'm afraid you guys' code writing abilities have far surpassed my code review abilities at this point! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx Cc: rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham planned changes to this revision. ngraham added a comment. Let's see if I can make this patch more intelligent, because the root of the issue is that the same text field is used for different things in different modes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.

D10719: Highlighting for OpenSCAD

julianstirling added a comment. Hi, This has been sitting idle for about 6 weeks. @dhaumann is everything OK with the current patch for integration Cheers Julian REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc:

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 31992. sharvey marked an inline comment as done. sharvey added a comment. - Remove unneeded resize code; ensure other columns fill to contents - Remove leftover commented-out code; restore variable declaration REPOSITORY R241 KIO CHANGES SINCE LAST UP

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. Rebased (I think). Had to manually resolve a conflict. Hopefully it'll land now. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, bro

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added inline comments. INLINE COMMENTS > kdiroperatordetailview.cpp:53 > > +<<< HEAD > void KDirOperatorDetailView::setModel(QAbstractItemModel *model) Uh-oh :) > kdiroperatordetailview.cpp:71 > +=== > +>>> Remove unneeded resize code; ensure other columns fill to content

D11452: sanitizer: Improve device listing

michaelh added a comment. Arrgh these deviceIds! Just realized this: When logged in as root on tty1 $ baloodb devices Listing database contents... + device:43 indexed-items:3658 fstype:tmpfs fsname:tmpfs mount:/run/user/0 + device:2049 indexed-items:2 fstype:ext4 fsname:/d

D11452: sanitizer: Improve device listing

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Yes, thats exactly what I meant - device ids are not stable ... But anyway, thats unrelated to this revision. REPOSITORY R293 Baloo BRANCH sanitize-devices (branched from master) REVIS

D12160: Rebase onto fresh master

ngraham added a comment. Oops, did you mean to create a new revision? Let's just focus on the existing one. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D12160: Rebase onto fresh master

sharvey created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 AFFECTED FILES src/filewidgets/kdirope

D12160: Rebase onto fresh master

sharvey added a comment. In D12160#245232 , @ngraham wrote: > Oops, did you mean to create a new revision? Let's just focus on the existing one. git and arc are hating me right now REPOSITORY R241 KIO REVISION DETAIL https://phabric

D12160: Rebase onto fresh master

ngraham added a comment. Join me in #plasma and we'll work this out. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 31996. michaelh added a comment. - Consider tmpfs as not mounted - Bring back major/minor print out REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=31972&id=31996 BRANCH sanitize-devices (branched from maste

D12160: Rebase onto fresh master

sharvey abandoned this revision. sharvey added a comment. Created by mistake. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:143 > +devInfo.fsInfo = dev; > +devInfo.mounted = true && (dev.filesystem != > QLatin1String("tmpfs")); > +qDebug() << "filesystem" << dev.filesystem; Better safe than sorry h

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:144 > +devInfo.mounted = true && (dev.filesystem != > QLatin1String("tmpfs")); > +qDebug() << "filesystem" << dev.filesystem; > +result[id] = devInfo; Will be removed downstre

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 32002. sharvey added a comment. - Repairing merge error REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31992&id=32002 BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 AFFECTED FILES

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey marked 2 inline comments as done. sharvey added a comment. Merge errors tracked down and eradicated. INLINE COMMENTS > ngraham wrote in kdiroperatordetailview.cpp:53 > Uh-oh :) What is that? (finding it and killing it) REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL

D12028: taglibextractortest: Add test for files with empty metadata

bruns added inline comments. INLINE COMMENTS > taglibextractortest.cpp:300 > +} > +QCOMPARE(resultKeys, expectedKeys); > +} Unfortunately QCOMPARE does not do a deep compare if sizes mismatch. To get a better output in case the test fails, you can do something like: auto excessKeys()

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham accepted this revision. ngraham added a comment. Works, thanks! REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns requested review of this revision. bruns added a comment. Make it obvious this should have some more review ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh

D12127: Do not query properties when no interfaces are left

bruns added a comment. In D12127#244859 , @broulik wrote: > Lgtm. > But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug Yes, D12126 REPOSITO

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32005. michaelh added a comment. - Hopefully get the enum right this time - Use struct for summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=31811&id=32005 BRANCH sanitize-enums (branched from master)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 192 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/192/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 12 Apr 2018 19:43:18 + Build duration: 5 min 1 sec and counting JUnit Tests Name: (

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/62/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 12 Apr 2018 19:43:18 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 213 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/213/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 12 Apr 2018 19:43:18 + Build duration: 25 min and counting JUnit Tests Name: (root) Fai

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 32009. michaelh added a comment. - Optimize failure messages REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12028?vs=31989&id=32009 BRANCH nometa REVISION DETAIL https://phabricator.kde.org/D12028 AFFECTED

D11745: databasesanitizer: Use flags for filtering

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:32 > #include > +#include > double QDebug REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, s

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

kossebau created this revision. kossebau added a reviewer: ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY The existing toString/toSymbolString methods use KLocalizedStri

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32014. michaelh added a comment. Single qDebug REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32005&id=32014 BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.org/D11745

D11745: databasesanitizer: Use flags for filtering

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, ngraham, smithjd, ashaposhnikov, michael

D11285: Introduce sanitizer class

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, bruns, alexeymin

D11287: Introduce baloodb CLI tool

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, bruns, alexeymin

D11392: sanitizer: Move implementation into Baloo namespace

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11392 To: michaelh, #baloo, #frameworks, kossebau Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11452: sanitizer: Improve device listing

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo BRANCH sanitize-devices (branched from master) REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks, bruns Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun,

D11657: Do not export databasesanitizer by default

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11657 To: michaelh, #baloo, davidedmundson Cc: smithjd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11745: databasesanitizer: Use flags for filtering

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, al

D12044: baloodb: Improve interface

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo BRANCH sanitize-improve-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #baloo, ngraham Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alex

D11753: baloodb: Add clean command

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

cfeck added inline comments. INLINE COMMENTS > kdiroperator.cpp:2590 > +// Set a minimum width to make enough room for a label when the > icons are tiny > +const QSize itemSize = QSize(qMax(120, width), height); > +view->setGridSize(itemSize); If you need a minimum width

  1   2   >