[sysadmin/repo-metadata] projects/frameworks/purpose: Move Purpose to Frameworks as requested.

2018-01-15 Thread Ben Cooksley
Git commit 06f17d58470907d4389a8b0274b2b487293ce3ff by Ben Cooksley. Committed on 15/01/2018 at 08:27. Pushed by bcooksley into branch 'master'. Move Purpose to Frameworks as requested. Fixes T7755 CCMAIL: kde-frameworks-devel@kde.org R +0-0projects/frameworks/purpose/i18n.json [from:

D9823: Optimize: use QMetaObject::invokeMethod with functor

2018-01-15 Thread Milian Wolff
mwolff updated this revision to Diff 25366. mwolff added a comment. thanks dfaure ;-) REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9823?vs=25172&id=25366 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9823 AFFECTED FILES src/lib/i

D9823: Optimize: use QMetaObject::invokeMethod with functor

2018-01-15 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol, mpyne Cc: mpyne, #frameworks

D9820: Verify that the file was opened

2018-01-15 Thread David Faure
dfaure accepted this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9820 To: mwolff, dfaure, apol Cc: #frameworks

D9821: Use QSignalSpy::wait instead of QTest::wait where possible

2018-01-15 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kdirwatch_unittest.cpp:256 > // Give time for KDirWatch to notify us > while (spyDirty.count() < expected) { > if (++numTries > s_maxTries) { but then the whole while loop could be removed too, it served the same purpose as what

D9822: Add benchmarks for KDirWatch

2018-01-15 Thread David Faure
dfaure added a comment. "The third one touches all files in the tree and measure how long it takes until all dirty signals arrive. If you subtract that measurement from the third benchmark" Did you mean, if you subtract the first benchmark from the third benchmark? "That measurement"

D9821: Use QSignalSpy::wait instead of QTest::wait where possible

2018-01-15 Thread Milian Wolff
mwolff added inline comments. INLINE COMMENTS > dfaure wrote in kdirwatch_unittest.cpp:256 > but then the whole while loop could be removed too, it served the same > purpose as what QSignalSpy::wait does. no, since wait waits for one signal, this loop waits for up to `expected` signals. We cou

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-15 Thread Milian Wolff
mwolff added a comment. 150KB is not a lot of memory REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9824 To: mwolff, dfaure, rjvbb, #kdevelop Cc: #frameworks

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-15 Thread Jaime Torres Amate
jtamate added a comment. Yes, you are right, it doesn't pass the unittests with this tentative patch. Some local changes should have triggered the heavy load, because now I'm not able to reproduce them. But there is a problem somewhere (I'll investigate further) because today, every

D9822: Add benchmarks for KDirWatch

2018-01-15 Thread Milian Wolff
mwolff updated this revision to Diff 25367. mwolff edited the summary of this revision. mwolff added a comment. fixup commit message REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9822?vs=25169&id=25367 REVISION DETAIL https://phabricator.kde.org/D98

D9822: Add benchmarks for KDirWatch

2018-01-15 Thread Milian Wolff
mwolff updated this revision to Diff 25368. mwolff edited the summary of this revision. mwolff added a comment. format results on phab REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9822?vs=25367&id=25368 REVISION DETAIL https://phabricator.kde.org/D

D9812: [Icon Item] Treat sources starting with a slash as local file

2018-01-15 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9812 To: broulik, #plasma, hein, mwolff, davidedmundson Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9812: [Icon Item] Treat sources starting with a slash as local file

2018-01-15 Thread Marco Martin
mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9812 To: broulik, #plasma, hein, mwolff, davidedmundson, mart Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D9812: [Icon Item] Treat sources starting with a slash as local file

2018-01-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:639e8684e3b3: [Icon Item] Treat sources starting with a slash as local file (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/46/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 09:23:28 + Build duration: 4 min 48 sec and counting JUnit

D9785: [ConfigModel] Set QML context on ConfigModule

2018-01-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:94b91f723a23: [ConfigModel] Set QML context on ConfigModule (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9785?vs=25067&i

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 09:23:28 + Build duration: 16 min and counting JUnit Tes

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 66 - Still unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/66/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 09:03:20 + Build duration: 38 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 09:39:32 + Build duration: 3 min 34 sec and counting JUn

D9784: [ConfigModule] Re-use QML context and engine if any

2018-01-15 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. https://cgit.kde.org/kdeclarative.git/commit/?id=84a370ce2c3ac48be9e8745a93cd347bba463323 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9784 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenB

D9770: Optimization of byteSize(double size)

2018-01-15 Thread Milian Wolff
mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. - do not ever profile a debug build, the results are completely bogus - do not use callgrind, use perf that said, I'm OK with this patch but the commit message should not talk about p

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 47 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/47/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 09:33:19 + Build duration: 18 min and counting JUnit Tests

D9821: Use QSignalSpy::wait instead of QTest::wait where possible

2018-01-15 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Oh, right. I see. Still very strange that QTRY_COMPARE_WITH_TIMEOUT behaves differently (if more signals are coming in than expected, the current (old) code could have caught them too, duri

D4361: [Containment] Move contains() check inside NDEBUG

2018-01-15 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4361 To: broulik, #plasma Cc: bshah, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9 - Build # 12 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 09:03:58 + Build duration: 1 hr 6 min and counting

D9770: Code de-duplication in byteSize(double size)

2018-01-15 Thread Jaime Torres Amate
jtamate retitled this revision from "Optimization of byteSize(double size)" to "Code de-duplication in byteSize(double size)". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R288 KJobWidgets BRANCH performance (branched from master) R

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-15 Thread Jaime Torres Amate
jtamate abandoned this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-15 Thread Mark Gaiser
markg added inline comments. INLINE COMMENTS > dfaure wrote in kdirwatch.cpp:721 > .insert(e->wd, e) is a hair faster, says Effective STL Item 24 :) m_inotify_wd_to_entry is a QHash, not a std::unordered_map ;) Not sure if the same rules from that book apply to Qt (i doubt it). REPOSITORY R24

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 10:14:04 + Build duration: 5 min 20 sec and counting JUnit Tests N

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs
sars created this revision. sars added reviewers: Frameworks, mlaurent. Restricted Application added a project: Frameworks. sars requested review of this revision. REVISION SUMMARY The conversion to new style connect introduced a bug. The old connect properly used the base class signal while th

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 10:19:26 + Build duration: 5 min 4 sec and counting JUnit Tests Na

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. indeed good catch REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-15 Thread David Faure
dfaure added a comment. I'm 100% sure the same rules applies, because the "limitations" of operator[] come from C++ and therefore apply to all associative containers. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9824 To: mwolff, dfaure, rjvbb, #kdevelop Cc: m

[kio] src/core: Revert "Don't stat(/etc/localtime) between read() and write() copying files"

2018-01-15 Thread Fabian Vogt
Git commit 16b21e7223f5bc070dcfd540ede55e5837ccc097 by Fabian Vogt. Committed on 15/01/2018 at 11:31. Pushed by fvogt into branch 'master'. Revert "Don't stat(/etc/localtime) between read() and write() copying files" This reverts commit f7e00b40a6d35fbfe536cdb99d6f22b643676e5e. This results in c

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-15 Thread Fabian Vogt
fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. Reverted in master as this broke various important ioslaves, like desktop and trash. I believe the issue is that the timeout fires immediately after construction, without being configure

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs
sars closed this revision. sars added a comment. For some reason this review was not closed automatically by the commit. Closing manually. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Luigi Toscano
ltoscano reopened this revision. ltoscano added a comment. This revision is now accepted and ready to land. Give it some time. Right now Phabricator is only observing the repositories, not handling them, and this means that an update can land with some delay. REPOSITORY R236 KWidgetsAddons

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs
This revision was automatically updated to reflect the committed changes. Closed by commit R236:ee34537ff55c: KMultiTabBar: Fix regression in conversion to new style connect() (authored by sars). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9884?vs=25

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 86 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/86/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 11:33:41 + Build duration: 29 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 09:23:28 + Build duration: 2 hr 45 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 86 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/86/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 11:33:41 + Build duration: 45 min and counting JUnit Tests Name: (root) Failed:

D9887: [baloo-widgets] Display releaseYear w/o decimal grouping

2018-01-15 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Frameworks, Dolphin. michaelh added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Display release year as e.g. "2010" instead of "2.010" TEST PLAN Visual inspection REPOSITORY R824 Baloo Widgets

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 10:14:04 + Build duration: 2 hr 13 min and counting JUnit Tests

D9887: [baloo-widgets] Display releaseYear w/o decimal grouping

2018-01-15 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH releaseYear (branched from master) REVISION DETAIL https://phabricator.kde.org/D9887 To: michaelh, #frameworks, #dolphin, broulik Cc: elvisangelaccio, ngraham

D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

2018-01-15 Thread Milian Wolff
mwolff created this revision. mwolff added reviewers: dfaure, mpyne. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY I quite frankly don't understand how this code can ever work.

D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

2018-01-15 Thread Milian Wolff
mwolff edited the summary of this revision. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D9888 To: mwolff, dfaure, mpyne Cc: #frameworks

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-15 Thread Jaime Torres Amate
jtamate updated this revision to Diff 25391. jtamate added a comment. I'm sorry for the inconvenience. I'm going to divide the patch in two, the first part only changes lastTimeout and should be safe. nextTimeout part needs more thinking (if can be done). REPOSITORY R241 KIO CHANGES SI

D9712: balooctl status: produce parseable output

2018-01-15 Thread Michael Heidelbach
michaelh added a reviewer: smithjd. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9712 To: michaelh, #frameworks, vhanda, smithjd Cc: elvisangelaccio, lueck, dfaure, ngraham

D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

2018-01-15 Thread Milian Wolff
mwolff added a comment. FTR: [13:35] how the hell can kdesu ever work? https://phabricator.kde.org/D9888 WTF [13:35] does anyone know if I'm missing something? [13:35] googling for these macros doesn't show me anything obvious either [13:53] milian: dead code I'd say. n

D9888: Make kdesu work when PWD is /usr/bin

2018-01-15 Thread Milian Wolff
mwolff updated this revision to Diff 25395. mwolff retitled this revision from "Let kdesu work when __PATH_SU or __PATH_SUDO are not defined" to "Make kdesu work when PWD is /usr/bin". mwolff edited the summary of this revision. mwolff added a subscriber: sitter. mwolff added a comment. cleanu

D9888: Make kdesu work when PWD is /usr/bin

2018-01-15 Thread Harald Sitter
sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > suprocess.cpp:122 > > -QByteArray command; > -if (d->superUserCommand == QLatin1String("sudo")) { > -command = __PATH_SUDO; > -} else { > -

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 67 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/67/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 11:33:41 + Build duration: 1 hr 50 min and counting JUnit Tests Name: (r

D9887: [baloo-widgets] Display releaseYear w/o decimal grouping

2018-01-15 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R824:1dd9509a29f1: [baloo-widgets] Display releaseYear w/o decimal grouping (authored by michaelh). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9887?vs=25390&id

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 12:09:31 + Build duration: 1 hr 51 min and counting

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Dominik Haumann
dhaumann added subscribers: dfaure, dhaumann. dhaumann added a comment. @dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, we should at least announce this bug on kde-distro-packag...@kde.org, since this breaks Kate. Second question: How did this happen in the f

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 12:28:15 + Build duration: 1 hr 48 min and counting JUnit Tests

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

2018-01-15 Thread David Faure
dfaure added a comment. ping? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8908 To: dfaure, cfeck, dvratil Cc: anthonyfieroni, #frameworks, #kde_pim

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread David Faure
dfaure added a comment. Done, kwidgetaddons-5.42.1 is out: https://download.kde.org/stable/frameworks/5.42/ REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent Cc: dhaumann, dfaure, ltoscano

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:51:45 + Build duration: 9 min 39 sec and counting JUnit Tests Name: (

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:51:51 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:52:49 + Build duration: 18 min and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:53:53 + Build duration: 19 min and counting JUnit Tests Name: (

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:54:26 + Build duration: 23 min and counting JUnit Tests Name: (

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:54:49 + Build duration: 25 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/13/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:54:54 + Build duration: 27 min and counting JUnit Tests Name: (

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:55:42 + Build duration: 30 min and counting JUnit Tes

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 18 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/18/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:51:45 + Build duration: 44 min and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 12 - Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/12/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 14:55:17 + Build duration: 40 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 15:03:09 + Build duration: 33 min and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 15:01:25 + Build duration: 32 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 35 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/35/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:51:51 + Build duration: 48 min and counting JUnit Tests N

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:52:49 + Build duration: 54 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:54:26 + Build duration: 53 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kpty kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks kpty kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:54:44 + Build duration: 54 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 14 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/14/ Project: Frameworks krunner kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:54:49 + Build duration: 55 min and counting JUnit Tests Name: (root

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.7 - Build # 12 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks kservice kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:54:54 + Build duration: 57 min and counting JUnit Tests Name: (ro

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

2018-01-15 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Otherwise all is good. +2 with the QVERIFY(...) INLINE COMMENTS > kdatecomboboxtest.cpp:182 > +combo->activateWindow(); > +QTest::qWaitForWindowActive(combo.data()); > + QVERIF

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 - Build # 28 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/28/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 15 Jan 2018 14:53:18 + Build duration: 1 hr 10 min and counting J

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 48 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/48/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:55:42 + Build duration: 1 hr 8 min and counting JUnit T

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 33 - Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/33/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 14:54:59 + Build duration: 1 hr 9 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 36 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/36/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 15:40:11 + Build duration: 28 min and counting JUnit Tests N

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 19 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/19/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 15:36:21 + Build duration: 34 min and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Mon, 15 Jan 2018 16:19:01 + Build duration: 9 min 57 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Jan 2018 16:19:01 + Build duration: 23 min and counting JUnit Tests Name: (root) F

Re: KHolidays as Framework (redux)

2018-01-15 Thread Allen Winter
I'm wrong. the changes are BC since I'm just moving static functions around. Moving KHolidays anytime you want is fine with me. On Sunday, January 14, 2018 2:02:48 PM EST Volker Krause wrote: > On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > > @Volker: Is there a need to rush releas

D9808: fix incorrect emission of signals by kLineEdit

2018-01-15 Thread Dan Weatherill
dweatherill added a comment. I don't have commit access but please let me know if anything else is needed before it can be merged. (for submission) Name: Dan Weatherill email: dan.weather...@cantab.net REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:51:51 + Build duration: 2 hr 14 min and counting JUnit Te

KDE CI: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.9 - Build # 16 - Fixed!

2018-01-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.9/16/ Project: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 15 Jan 2018 14:54:36 + Build duration: 2 hr 12 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:52:49 + Build duration: 2 hr 27 min and counting JU

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:53:53 + Build duration: 2 hr 31 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:54:26 + Build duration: 2 hr 37 min and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:54:44 + Build duration: 2 hr 39 min and counting JUnit Tests Name: (

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:54:49 + Build duration: 2 hr 40 min and counting JUnit Tests N

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:54:54 + Build duration: 2 hr 42 min and counting JUnit Tests

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 5 - Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:55:02 + Build duration: 2 hr 48 min and counting JUnit Tes

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/68/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:53:47 + Build duration: 2 hr 53 min and counting JUnit Tests Name: (r

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

2018-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 14:55:12 + Build duration: 2 hr 55 min and counting JUnit Tests

D9894: [UDisks Device] Show loop device with their backing file name and icon

2018-01-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: VDG, davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Instead of showing generic "Loop Device" for everyth

D9895: [UDisks] Ignore non-user mounts

2018-01-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This gets rid of all those internal mou

D9894: [UDisks Device] Show loop device with their backing file name and icon

2018-01-15 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > udisksdevice.cpp:614 > +} > +return "drive-harddisk"; > +} else if (isSwap()) { return QStringLiteral("drive-harddisk"); REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9894 To: broulik, #vdg, davidedmund

  1   2   >