elvisangelaccio added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:145
> +KFilePlacesModel *currentModel = model;
> +if (currentModel == nullptr) {
> +currentModel = m_places;
`if (!currentModel)` ?
> kfileplacesmodel.h:69
> +/**
> +* @brief Construct a ne
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:34
>
> -configure_file(org.kde.kded5.service.in
> - ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kded5.service)
> -install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kded5.service
> -DESTINATION ${KDE_INSTALL_DBUSSERVICE
kossebau created this revision.
kossebau added reviewers: dfaure, mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R244 KCoreAddons
BRANCH
setautomocmacronamesalsoforownbuild
REVISION DETAIL
https://phabricator.
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
setautomocmacronamesalsoforownbuild
REVISION DETAIL
https://phabricator.kde.org/D9489
To: kossebau, dfaure, mlaurent
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:6e1f17922f3d: Extend CMAKE_AUTOMOC_MACRO_NAMES also for
own build (authored by kossebau).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9489?vs=24326&id=24327
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/11/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 15:09:38 +
Build duration:
2 min 25 sec and counting
JUnit Tes
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/24/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Sat, 23 Dec 2017 15:09:38 +
Build duration:
3 min 21 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks sonnet kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 15:44:48 +
Build duration:
54 sec and counting
CONSOLE OUTPUT
[...truncat
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 15:43:58 +
Build duration:
49 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks sonnet kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 15:44:48 +
Build duration:
1 min 0 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/15/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Sat, 23 Dec 2017 15:43:58 +
Build duration:
1 min 26 sec and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/15/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 15:43:58 +
Build duration:
5 min 21 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/14/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 15:46:53 +
Build duration:
4 min 52 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/37/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Sat, 23 Dec 2017 15:46:53 +
Build duration:
6 min 26 sec and counting
JUn
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/40/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 15:46:53 +
Build duration:
6 min 25 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 15:59:38 +
Build duration:
1 min 18 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/10/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 15:59:38 +
Build duration:
1 min 28 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/10/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Sat, 23 Dec 2017 15:59:38 +
Build duration:
5 min 43 sec and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20SUSEQt5.7/13/
Project:
Frameworks sonnet kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 16:45:18 +
Build duration:
1 min 8 sec and counting
JUnit Tests
Name: (ro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/7/
Project:
Frameworks sonnet kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 16:45:18 +
Build duration:
1 min 27 sec and counting
JUnit Tests
Na
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/8/
Project:
Frameworks sonnet kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 17:00:23 +
Build duration:
1 min 6 sec and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/9/
Project:
Frameworks sonnet kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 17:08:53 +
Build duration:
52 sec and counting
JUnit Tests
Name: (ro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/47/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sat, 23 Dec 2017 17:32:33 +
Build duration:
7 min 49 sec and counting
JUnit Tests
Name: (root
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/27/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 17:32:33 +
Build duration:
8 min 45 sec and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/48/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 17:32:33 +
Build duration:
23 min and counting
JUnit Tests
Name: (root) Failed
dfaure created this revision.
dfaure added reviewers: sandsmark, mlaurent.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
When AutoDetectLanguage is set, the same document can contain multiple
languages. In that case, Highlighter stores the language information
into the
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c9b412d40334: Fix a regression caused by changing
backspace key behavior (authored by safaalfulaij).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7660?vs=21916&
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/24/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 19:37:23 +
Build duration:
1 min 32 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/23/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Sat, 23 Dec 2017 19:37:23 +
Build duration:
1 min 50 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/68/
Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sat, 23 Dec 2017 19:37:23 +
Build duration:
6 min 3 sec and counting
CON
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 23 Dec 2017 19:37:23 +
Build duration:
12 min and counting
CONSOLE OUTPUT
habacker added a comment.
I can update the patch with this path if you want. It came from the service
template file
Exec=@CMAKE_INSTALL_PREFIX@/bin/kded5
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D9482
To: habacker, dfaure, kfunk
Cc: #frameworks
dfaure added a comment.
Indeed that was a bug in the .in files, arguably.
The executables get installed into KDE_INSTALL_BINDIR (says
kde-modules/KDEInstallDirs.cmake), so if we want the full path version of it,
it should be KDE_INSTALL_FULL_BINDIR.
REPOSITORY
R297 KDED
REVISION DETAIL
dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
A fallthroughContext="#stay" is always wrong if fallthrough="true" is set,
since in this case
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the highlighting indexer to search for
attribute="". Referencing an empty attribute
habacker updated this revision to Diff 24345.
habacker added a comment.
- use KDE_INSTALL_FULL_BINDIR instead of CMAKE_INSTALL_PREFIX
REPOSITORY
R297 KDED
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9482?vs=24312&id=24345
BRANCH
master
REVISION DETAIL
https://phabricator.
brauch added a comment.
After this was submitted master doesn't compile for me, and if I fix the
compile in the trivial way the test fails. Can you have another look?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, h
brauch reopened this revision.
brauch added inline comments.
INLINE COMMENTS
> katedocument_test.cpp:452
> auto view =
> static_cast(doc.createView(nullptr));
> +view.config()->setBackspaceRemoveComposed(true);
> doc.setText(QString::fromUtf8("व्यक्तियों"));
must be view->config .
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/49/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 24 Dec 2017 03:49:50 +
Build duration:
12 min and counting
JUnit Tests
Name: (root) Failed
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/48/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sun, 24 Dec 2017 03:49:50 +
Build duration:
13 min and counting
JUnit Tests
Name: (root) Fail
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/28/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 24 Dec 2017 03:49:50 +
Build duration:
21 min and counting
JUnit Tests
Name: (root)
safaalfulaij updated this revision to Diff 24349.
safaalfulaij added a comment.
Fix compilation issues
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7660?vs=24338&id=24349
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7660
AFFECTED F
42 matches
Mail list logo
