dfaure created this revision.
dfaure added reviewers: mdawson, apol, mpyne.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The CI has $HOME=/home/jenkins/ with a trailing slash, which leads to
FAIL! : KConfigTest::testPath() Compared values are not the same
Actual
dfaure abandoned this revision.
dfaure added a comment.
Well, on second thought, $HOME/foo leads to double slash in a shell (when
HOME has trailing slash), so the bug isn't kconfig but the expected value
(QDir::homePath() returns a cleaned up value).
REPOSITORY
R237 KConfig
REVISION DETAI
arojas created this revision.
arojas added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
recursiveFiltering has been renamed to recursiveFilteringEnabled in 5.10-rc2
https://github.com/qt/qtbas
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Well spotted.
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D9099
To: arojas, dfaure
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R275:8b5b30d90253: Update comment for new Qt 5.10 API
(authored by arojas).
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9099?vs=23252&id=23253
REVISION DETAIL
dfaure created this revision.
dfaure added reviewers: apol, davidedmundson, arichardson, bshah.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This code had a QHash and a separate ordered list of names in order
to use plugins in the right order. It's much simpler to just
dfaure added a comment.
This test seems to fail depending on how QtMultimedia was built. See failure
from the flaska CI, below. Can something be done to detect this?
2017-12-01 19:31:03,939 [output] * Start testing of
QtMultimediaExtractorTest *
2017-12-01 19:31:03,939
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:966
> QTest::newRow("Places - Trash") << m_places->index(2, 0)
> - << QStringLiteral("user-trash-full");
> + << QStringLiteral("user-trash");
> QT
On Thursday, 30 November 2017 21:21:18 CET Aleix Pol wrote:
> Hi,
> Recently I put together some CI for Android, where some frameworks are
> being checked to _build_ for Android + ARM.
>
> Now there's many frameworks that can't be built at the moment, you can
> see them listed here:
> https://phab
mgallien added a comment.
In https://phabricator.kde.org/D5417#174323, @dfaure wrote:
> This test seems to fail depending on how QtMultimedia was built. See
failure from the flaska CI, below. Can something be done to detect this?
The extractor is not working well. On Windows, it a
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Your call. But since that would also fix CI, I'm in favour.
REPOSITORY
R286 KFileMetaData
BRANCH
upstream
REVISION DETAIL
https://phabricator.kde.org/D8886
To: mgallien, #frameworks
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9102
AFFECTE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9102
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9066c232b403: [Icon Item] Emit validChanged only if it
actually changed (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D910
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This job will be used to rename multiple files. It basically reuses the code
from `Dolphin::RenameDialog`.
REPOSITORY
R241 KIO
BRANCH
master
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:27fc3329a862: Don't try to generate metadata.json if
there's no metadata.desktop (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9073?vs=23182&id=23261#toc
REPOSITORY
R290
apol added a comment.
Wouldn't it be easier to have this job in Dolphin? Or it needs to be in kio
to access private API?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9103
To: chinmoyr, #frameworks, dfaure
Cc: apol
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
It's interesting how the code ends up simpler. :)
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9100
To: dfaure, apol, davidedmundson, arichardson, bsha
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of using implicit casts, use the ones we need as suggested for KF5.
TEST PLAN
test
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Rather than doing a string comparison and doing it every time
TEST PLAN
OSD is still
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
strings
REVISION DETAIL
https://phabricator.kde.org/D9104
To: apol, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:a3c7bf02205f: Faster UDevManager::devicesFromQuery
(authored by davidedmundson).
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8495?vs=23086&id=23264
REVISION DETAI
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:8336ad60d9a5: Properly do strings in the kpackage
framework (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9104?vs=23262&id=23266
REVISION DET
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:2c513b931b43: Group some blocking dbus calls (authored by
apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9092?vs=23230&id=23267#toc
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UP
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8047e86b298: Reduce the amount of spurious property
changes on ColorScope (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D891
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9105
To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:cfcf8a61d552: [Dialog] Use KWindowSystem::isPlatformX11()
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9105?vs=23263&id=
graesslin added a comment.
There are a few unrelated changes, but otherwise looks good.
INLINE COMMENTS
> package.cpp:360
> //Nested loop, but in the medium case resolves to just one iteration
> -//qDebug() << "prefixes:" << prefixes.count() << prefixes;
> +// qDebug() << "prefix
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:7005889ba644: Compile with stricter compilation flags
(authored by mlaurent).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9049?vs=23199&id=23270
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in package.cpp:594
> Just curious: what does the modulo operator on a string?
It explicitly uses `QStringBuilder` for concatenation which `operator+` only
does if you define `QT_USE_QSTRINGBUILDER`
REPOSITORY
R290 KPackage
REV
chinmoyr added a comment.
In https://phabricator.kde.org/D9103#174381, @apol wrote:
> Wouldn't it be easier to have this job in Dolphin? Or it needs to be in kio
to access private API?
Adding undo support is easier if it's in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://
chinmoyr updated this revision to Diff 23272.
chinmoyr added a comment.
Emit both old and new url in fileRenamed. It will be useful when undoing.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23260&id=23272
BRANCH
master
REVISION DETAIL
https://p
chinmoyr added a dependent revision: D9107: Add undo support to BatchRenameJob.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9103
To: chinmoyr, #frameworks, dfaure
Cc: apol
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch makes undoing a batch rename possible.
Depends on https://phabricator.kde.org/D9103
REPOSITORY
R241 KIO
BRANCH
master
REVISION
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I'm OK with this being in KIO. One day we might want the same from the file
dialog, or krusader, etc.
INLINE COMMENTS
> batchrenamejobtest.cpp:20
> +
> +#include
> +
this is al
apol created this revision.
apol added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Follow the KF5 guidelines
TEST PLAN
Plasma shell starts
REPOSITORY
R242 Plasma Framewor
dfaure planned changes to this revision.
dfaure added inline comments.
INLINE COMMENTS
> kurifilter.cpp:665
> +QStringList res;
> +res.reserve(d->pluginList.size());
> +std::transform(d->pluginList.constBegin(), d->pluginList.constEnd(),
> res.begin(), [](const KUriFilterPlugin *plug
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9108
To: apol, #plasma, #frameworks, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:73fd5f771cc4: KUriFilter: simplify data structures, fix
memory leak (authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9100?vs=23254&id=23278#toc
REPOSITORY
R241 KIO
CHANG
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Good stuff.
INLINE COMMENTS
> fileundomanagertest.cpp:697
> +
> +createTestFile(srcList[0].path(), "foo");
> +createTestFile(srcList[1].path(), "foo");
use .at(0) to avoi
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b8b8a69fd1a3: Remove implicit string casting (authored by
apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9108?vs=23277&id=23279
REVISION
emateli added inline comments.
INLINE COMMENTS
> kurifilter.cpp:597
> +if (filters.isEmpty() || filters.contains(plugin->objectName())) {
> +if (plugin->filterUri(data)) {
> filtered = true;
Perhaps this can be merged with the if statement above.
REPOSITORY
chinmoyr updated this revision to Diff 23281.
chinmoyr marked 10 inline comments as done.
chinmoyr added a comment.
Made the required changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23272&id=23281
BRANCH
master
REVISION DETAIL
https://phabr
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Remove splitting + joining of a string just to remove the beginning of a
string.
Remove d
hein added inline comments.
INLINE COMMENTS
> packageurlinterceptor.cpp:166
> +const int firstSlash = relativePath.indexOf(QLatin1Char('/'));
> +const QString filename = firstSlash >= 0 && firstSlash <
> relativePath.size() ? relativePath.mid(firstSlash + 1) : relativePath;
> +
dfaure added inline comments.
INLINE COMMENTS
> emateli wrote in kurifilter.cpp:597
> Perhaps this can be merged with the if statement above.
It can, but I would certainly find it much less readable.
The heart of the method is to call filterUri.
The first if() is "should I call it?"
The nested i
apol updated this revision to Diff 23283.
apol added a comment.
Remove crazy check
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9109?vs=23282&id=23283
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9109
AFFECTED FILES
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9109
To: apol, #frameworks, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> batchrenamejob.cpp:56
> +// In this case nothing is substituted and all files have the same
> $newName.
> +// 4. Atleast two files have same e
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1f9b5ed657df: Performance (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9109?vs=23283&id=23285
REVISION DETAIL
https://pha
dfaure added a comment.
This looks correct, but did you find the KDE code that writes out this key?
A quick LXR search doesn't find anything relevant; do we use this feature at
all?
https://lxr.kde.org/search?_filestring=&_string=%22SortOrder%22&_casesensitive=1
REPOSITORY
R237 KCon
dfaure added a comment.
I don't get it. Which parts of this commit depend upon Qt 5.10? I only see
buff.birthTime_ being used.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7423
To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks
dfaure added a comment.
That would be the kitemviews framework.
But really, fixing QColumnView in Qt is the much preferred way to go.
It sure sounds harder right now, but think longer term...
In the past, any time we forked something from Qt, we ended up spending even
more time upstre
dfaure added inline comments.
INLINE COMMENTS
> kurlrequestertest.cpp:162
> +
> +// FIXME: this still doesn't emit any signal, but it works in practice
> when actually interacting with the widget?
> +req.comboBox()->setEditText("foobar");
Then use QTest::keyClick to send key events to t
ngraham added a comment.
Unless I'm misunderstanding everything, birthTime_ is only set to a nonzero
value as of
https://github.com/qt/qtbase/commit/d3393ce25833c0afd7f0fa6b85fd6f3bd7ad520a#diff-e061e747264146cf47a86b371e512348R363,
which only made it into Qt 5.10 and was not backported to 5
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I suppose `put()` should do the same, then?
INLINE COMMENTS
> file_unix.cpp:72
> + */
> +static QString blockDeviceByPath(const QString &filename)
> +{
Doesn't KMountPoint::curre
dfaure added reviewers: ossi, thiago.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8254
To: vova7890, #frameworks, dfaure, ossi, thiago
Cc: dfaure, ngraham, alexeymin, #frameworks
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Yes, emulating `cp -a` is on purpose.
A flag for a "deep copy" might be useful, but not changing the default
behaviour.
And I definitely hope this patch breaks jobtest ;-
dfaure added inline comments.
INLINE COMMENTS
> file.cpp:783
>
> if (QT_LSTAT(path.data(), &buff) == 0) {
>
... but we fill `buff` using `lstat()`, not using QFile, so it doesn't matter
what QFile does.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7423
To: n
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kjobtrackerinterface.h:88
> */
> -virtual void unregisterJob(KJob *job);
> +virtual void unregisterJob(KJob *job); // TODO KF6: should it become
On dimanche 22 octobre 2017 22:00:36 CET Mark Gaiser wrote:
> Yes, the build and install were both in the same build folder.
> Changing the install to some other folder (a sub folder now of the build
> one) does indeed work.
> Oh well, i'm happy :)
Locally installing shouldn't be necessary anymore
dfaure added a comment.
Isn't it time to uninstall kdelibs3? :-)
Otherwise yes I'm ok with you renaming the helper executable, its use is very
self-contained. Only KIO can call it, it takes a path to a socket created by
KIO...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator
fvogt added a comment.
In https://phabricator.kde.org/D7929#174572, @dfaure wrote:
> That would be the kitemviews framework.
>
> But really, fixing QColumnView in Qt is the much preferred way to go.
> It sure sounds harder right now, but think longer term...
> In the past, any ti
dfaure added a comment.
In https://phabricator.kde.org/D7423#137952, @ngraham wrote:
> This patch doesn't actually directly use statx(); it uses the existing
approach, which goes through QFile, which is used to populate the statbuf
object that we query.
Can you show me where this
dfaure added a comment.
Cool stuff, but who will run this tool and when?
REPOSITORY
R857 CI System Tooling
REVISION DETAIL
https://phabricator.kde.org/D9076
To: apol, #frameworks
Cc: dfaure
chinmoyr updated this revision to Diff 23286.
chinmoyr marked 13 inline comments as done.
chinmoyr added a comment.
Hopefully I haven't missed any more of your comments.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23281&id=23286
BRANCH
master
REV
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in batchrenamejob.cpp:55
> Why special case "not a sequence", rather than just replacing the first
> (last?) sequence?
Because there might not be a first or last sequence present. In case 3 we don't
need a replacement and in case 4
On dimanche 26 novembre 2017 00:19:27 CET René J.V. Bertin wrote:
> Hi,
>
> KDirWatch is mostly rather old code, does anyone really know why it does
> what it does?
"Why" is always hard, but your questions are only about "what", so that's
easy, the code answers that ;)
> For instance, watching
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8970
To: broulik, #frameworks, dfaure
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
To: broulik, #frameworks, dfaure
Cc: apol, anthonyfieroni
This revision was automatically updated to reflect the committed changes.
Closed by commit R292:d636f414dc75: Use https for downloading currency exchange
rates (authored by broulik).
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8970?vs=22836&id=23288
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kjobwidgets.h:76
> + * This is required on Wayland to properly position the menu.
> + * @since 5.41
> + */
Unlikely at this point (tagging today).
REPOSITORY
R288 KJ
This revision was automatically updated to reflect the committed changes.
Closed by commit R292:f3342f4ccaba: Port from QDom to QXmlStreamReader
(authored by broulik).
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8971?vs=22874&id=23289
REVISION DETA
chinmoyr updated this revision to Diff 23290.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.
minor changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9107?vs=23275&id=23290
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
dfaure added a comment.
... because this isn't kde4 anymore, where almost every app provided a
kdeinit module.
QProcess forks from the process that uses QProcess, it might look
inconsistent when looking at process trees but it's really the most standard
Unix way of executing processes:
dfaure added a comment.
I agree that those are really KF5 specific and developer-oriented, so rather
unlikely to be e.g. sent by email to other people.
I'm unsure about mimetypes for special files by name, that seems too
specialized. Mimetypes are for *types* of files, not for each speci
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R246 Sonnet
BRANCH
avoid_check_all_the_time
REVISION DETAIL
https://phabricator.kde.org/D9110
AFFECTED FILES
src/core/backgroundchecker.c
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kopenssl.cpp:1047
> {
> -#if OPENSSL_VERSION_NUMBER < 0x1010L
> +#if OPENSSL_VERSION_NUMBER < 0x1010L || LIBRESSL_VERSION_NUMBER
> if (psig) {
t
mlaurent added reviewers: dfaure, sandsmark.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D9110
To: mlaurent, dfaure, sandsmark
Cc: #frameworks
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Saves a connection and also only schedule if we actually have a window
TEST PLAN
`sc
davidedmundson added a comment.
Not to spam this review request:
> We're still looking for someone to take the time to properly benchmark
that, the last time this happened was 10 years ago at least.
FWIW: I did a very very basic test recently.
I put Q_BENCHMARK round QProcess, and
On Saturday December 02 2017 17:36:03 David Faure wrote:
> "Why" is always hard, but your questions are only about "what", so that's
> easy, the code answers that ;)
No, I think it was really about the why of the what, but thanks for confirming
a few things.
> The goal of what? That categorize
dfaure added inline comments.
INLINE COMMENTS
> chinmoyr wrote in batchrenamejob.cpp:75
> Here it is searching for exactly one sequence. If more than one sequence are
> present like $$file$$name$$ then it is considered invalid.
But why? Why doesn't this lead to 12file$$name$$?
It's a weird inp
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9107
To: chinmoyr, #frameworks, dfaure
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
There's literally just one place where this thing changes so just emit the
signal ther
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
The render loop is responsible for calling polish, I don't think it will
without a window.
I can't this really making a difference. ..but nor any harm.
REPOSITORY
R24
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9112
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Yes.
> any library may place an i18n call before the main program creates
QApplication
No, that's invalid.
Before QApp is created, many things are not initialized, including th
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:da2b6e270fb6: [Icon Item] Explicitly emit overlaysChanged
in the setter rather than… (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8e3a16040a7: [IconItem] Use ItemSceneHasChanged rather
than connect on windowChanged (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9111?vs=23292&id=23295#toc
REPOSITOR
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Fun indeed.
Hmm I see the same issue in at least kdelibs4support, I'll go fix it.
Anyone wants to write a small script to check this? ;)
REPOSITORY
R304 KNewStuff
REVISION DETAI
dfaure added reviewers: apol, ossi.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8532
To: davidk, apol, ossi
Cc: #frameworks
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Good idea.
INLINE COMMENTS
> backgroundchecker.cpp:59
> sentenceOffset=-1;
> +bool autodetectLanguage =
> currentDict.testAttribute(Speller::AutoDetectLanguage);
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
- only one kpackage per applet, minimizes the metadata() cache misses (and
access to json)
chinmoyr updated this revision to Diff 23299.
chinmoyr added a comment.
changed 'first' to 'pos'.
added one more example to the doc.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23286&id=23299
BRANCH
master
REVISION DETAIL
https://phabricator.
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in batchrenamejob.cpp:196
> Ah right KIO::moveAs itself pops up the overwrite dialog, but then can it end
> with KIO::ERR_FILE_ALREADY_EXIST ? At that point the user should overwrite or
> skip or cancel. Are you really sure this err
mart updated this revision to Diff 23300.
mart added a comment.
- Merge branch 'master' into phab/minimizekpackage
- fix build
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9113?vs=23296&id=23300
BRANCH
phab/minimizekpackage
REVISI
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
During my plasmashell startup this saves time for 17 calls. Opening
something like
heikobecker updated this revision to Diff 23301.
heikobecker added a comment.
Added define(..)
REPOSITORY
R239 KDELibs4Support
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8672?vs=21939&id=23301
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8672
AFFECTED FILE
heikobecker marked an inline comment as done.
heikobecker added inline comments.
INLINE COMMENTS
> dfaure wrote in kopenssl.cpp:1047
> this syntax will lead to a preprocessor warning when LIBRESSL_VERSION_NUMBER
> isn't defined.
> Did you mean `|| defined(...)` ?
Yeah, that's indeed better...
1 - 100 of 201 matches
Mail list logo
