D8451: JavaScript: include standard mime types

2017-10-26 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. please also bump the version number REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8451 To: ChALkeR, #framework_syntax_highlighting, vkrause Cc: vkr

Re: Frameworks release schedule?

2017-10-26 Thread laurent Montel
Le jeudi 26 octobre 2017, 01:19:02 CEST Valorie Zimmerman a écrit : > On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote: > > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: > >> Hi, > >> I send this email to kde-frameworks-devel > >> > >> It's the correct ML for having an answer about

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9 - Build # 13 - Fixed!

2017-10-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.9/13/ Project: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 26 Oct 2017 09:51:56 + Build duration: 1 min 18 sec and counting

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 - Build # 12 - Fixed!

2017-10-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/12/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 26 Oct 2017 09:51:57 + Build duration: 2 min 34 sec and counting

D8494: Reduce QString creation in Udev checking

2017-10-26 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY UdevDevice creates a new QString in every wrapper. For the most part this makes sense, but we may as well cache a property if we'r

D8495: Faster UDevManager::devicesFromQuery

2017-10-26 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The current code fetches all devices, filters isOfInterest (which is at least one device property lookup) then filters by type.

D8496: Very lightweight cache over device enumeration

2017-10-26 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On startup various areas of frameworks fetch solid devices. Typically in quick succession for the same type. Caching this list saves

D8494: Reduce QString creation in Udev checking

2017-10-26 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D8494 To: davidedmundson, broulik Cc: #frameworks

D8494: Reduce QString creation in Udev checking

2017-10-26 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > udevmanager.cpp:92 > qDebug() << "Driver:" << device.driver(); > -qDebug() << "Subsystem:" << device.subsystem(); > +qDebug() << "Subsystem:" << subsystem > qDebug() << ""; This is missing a colon

D8496: Very lightweight cache over device enumeration

2017-10-26 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D8496 To: davidedmundson, broulik Cc: #frameworks

D8495: Faster UDevManager::devicesFromQuery

2017-10-26 Thread David Edmundson
davidedmundson planned changes to this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D8495 To: davidedmundson Cc: #frameworks

D8437: KWidgetsAddons : more compact password dialog

2017-10-26 Thread Nathaniel Graham
ngraham added a comment. @kfunk, all good now? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk, ngraham Cc: cfeck, ngraham

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 54 - Still Unstable!

2017-10-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/54/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 26 Oct 2017 21:18:28 + Build duration: 4 min 56 sec and counting JUnit Tes

D8416: really raising window when shown from systray

2017-10-26 Thread Martin Koller
mkoller abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8416 To: mkoller, davidedmundson, graesslin Cc: #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 129 - Still Unstable!

2017-10-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/129/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Fri, 27 Oct 2017 02:46:59 + Build duration: 8 min 19 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 133 - Still Unstable!

2017-10-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/133/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 27 Oct 2017 02:46:59 + Build duration: 12 min and counting JUni

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is fantastic work. I'm running with it full time now and can't imagine going back to the old one. Huge +1 from me. Do you have commit access? REPOSITORY R241 KIO BRANCH openwith