Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-05-04 Thread KJ Tsanaktsidis
> On April 28, 2017, 1:28 p.m., Lamarque Souza wrote: > > Ship It! > > KJ Tsanaktsidis wrote: > Great - thanks for your help and for bearing with my rusty C++! What > happens now? I'm waiting on this patch to land for another patch I submitted > a while ago: https://git.reviewboard.kde.org

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-05-04 Thread KJ Tsanaktsidis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/ --- (Updated May 4, 2017, 12:32 p.m.) Status -- This change has been mar

Jenkins-kde-ci: solid master kf5-qt5 » Linux,gcc - Build # 182 - Failure!

2017-05-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/solid%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/182/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 May 2017 12:32:38 + Build duration: 21 sec CHANGE SET Revision 3c1e1648a94c474c9270e203e9462285cd5d0619 by la

Jenkins-kde-ci: solid master stable-kf5-qt5 » Linux,gcc - Build # 181 - Failure!

2017-05-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/solid%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/181/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 May 2017 12:32:38 + Build duration: 50 sec CHANGE SET Revision 3c1e1648a94c474c9270e203e9462285cd5d061

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-05-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103182 --- Lamarque, you broke the build. - Albert Astals Cid On May

Jenkins-kde-ci: solid master kf5-qt5 » Linux,gcc - Build # 183 - Fixed!

2017-05-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/solid%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/183/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 May 2017 12:46:53 + Build duration: 2 min 37 sec CHANGE SET Revision 929ce607e9cd8019fdbe6bc49822474deee9b745

Jenkins-kde-ci: solid master stable-kf5-qt5 » Linux,gcc - Build # 182 - Fixed!

2017-05-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/solid%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/182/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 May 2017 12:46:53 + Build duration: 2 min 36 sec CHANGE SET Revision 929ce607e9cd8019fdbe6bc49822474de

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-05-04 Thread Lamarque Souza
> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. Fixed. Thanks for the quick report about the broken build and sorry for not adding all files to the commit. - Lamarque --- This is an automatical

Jenkins-kde-ci: solid master kf5-qt5 » Linux,gcc - Build # 183 - Fixed!

2017-05-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/solid%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/183/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 May 2017 12:46:53 + Build duration: 2 min 37 sec CHANGE SET Revision 929ce607e9cd8019fdbe6bc49822474deee9b745

Jenkins-kde-ci: solid master stable-kf5-qt5 » Linux,gcc - Build # 182 - Fixed!

2017-05-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/solid%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/182/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 May 2017 12:46:53 + Build duration: 2 min 36 sec CHANGE SET Revision 929ce607e9cd8019fdbe6bc49822474de

Android bulding guide

2017-05-04 Thread Fernando Theirs
Hi everyone! I'm working with Qt and I have to port a Linux application to Android. Basically I need to manage some compressed files (targz, zip, among others) and in Qt Forum they recommend me to use KArchive. I started working with Qt only a year ago and I'm still a rookie. I could not find bin

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-04 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > httpworker.cpp:36 > +HTTPWorkerNAM() > +: nam(new QNetworkAccessManager) > +, mutex(new QMutex) These all are leaking. > httpworker.cpp:48 > +QNetworkAccessManager* nam; > +QMutex* mutex; > + Drop *, leaking mutexes REP

D5712: Validate surface is valid when sending TextInput leave event

2017-05-04 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's possible for the surface to be unbound when we send the leave event; we've called Resource::unbi

Re: Review Request 130084: Add a pair of flags forcing fsync during copy loop

2017-05-04 Thread KJ Tsanaktsidis
> On April 15, 2017, 8:30 a.m., David Faure wrote: > > But doesn't this make copying much slower in the normal case? (copying onto > > a non-removable harddisk partition). > > > > It sounds to me like this should be > > 1) done internally in kio_file (no Job API for this) > > 2) only when the d

D5712: Validate surface is valid when sending TextInput leave event

2017-05-04 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please add a unit test case. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5712 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-dev