---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130090/#review103087
---
Fix it, then Ship it!
autotests/CMakeLists.txt (line 66)
wbauer updated this revision to Diff 13693.
wbauer edited the test plan for this revision.
wbauer added a comment.
added some tests
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5502?vs=13588&id=13693
REVISION DETAIL
https://phabricator.kde.org/D5502
A
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The icon has been available for a long time in both Breeze and Oxygen
icon themes.
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REV
ltoscano added reviewers: elvisangelaccio, aacid.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D5541
To: ltoscano, elvisangelaccio, aacid
Cc: #frameworks
ltoscano edited the test plan for this revision.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D5541
To: ltoscano, elvisangelaccio, aacid
Cc: #frameworks
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5541
To: ltoscano, elvisangelaccio, aacid
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:5fb6f3c0dfa8: Set the icon for the Donate action
(authored by ltoscano).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5541?vs=13694&id=13696
REVISION DETA
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/93/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 22 Apr 2017 14:02:47 +
Build duration: 1 min 53 sec
CHANGE SET
Revision 4a3572b899a0796118f610252e
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 22 Apr 2017 14:02:47 +
Build duration: 5 min 40 sec
CHANGE SET
Revision 4a3572b899a0796118f
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/94/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 22 Apr 2017 15:20:31 +
Build duration: 1 min 49 sec
CHANGE SET
Revision f760d6bcf11e1c8d60bf0f9cb12
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/94/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 22 Apr 2017 15:20:31 +
Build duration: 1 min 49 sec
CHANGE SET
Revision f760d6bcf11e1c8d60bf0f9cb12
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 22 Apr 2017 15:20:31 +
Build duration: 5 min 47 sec
CHANGE SET
Revision f760d6bcf11e1c8d60bf
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 22 Apr 2017 15:20:31 +
Build duration: 5 min 47 sec
CHANGE SET
Revision f760d6bcf11e1c8d60bf
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122206/
---
(Updated April 22, 2017, 10:35 p.m.)
Status
--
This change has been
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/533/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 23 Apr 2017 02:03:22 +
Build duration: 3 min 53 sec
CHANGE SET
Revision f8b6600d179a1996304dea0533118cba7610ef14 b
mdawson requested changes to this revision.
mdawson added a comment.
This revision now requires changes to proceed.
Excellent! Could you add 4 more rows to the tests, to ensure a path without
a folder (ex. systemConfigLocation + "/test.desktop") works correctly? Once
that's done, it's a shi
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 23 Apr 2017 05:14:44 +
Build duration: 13 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Failed:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 23 Apr 2017 05:14:44 +
Build duration: 13 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Failed:
18 matches
Mail list logo