davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Icon's are generally small, they may as well go in the existing shared
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
thatnks, makes sense
(and let's see if makes a difference with the phone, may be telling)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION D
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8d60a8f1f5b9: Use texture atlas for static icon item
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4342?vs=10695&i
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Avoids
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4348
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Instea
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
it would also be interesting to see why the destructor is being called so
many times at startup (some model somewhere emitting resets that shouldn't?)..
as at start
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fe3990556046: [Containment Interface] No need for
values() as contains() looks up keys (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricat
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d38be811e82b: [FrameData] Avoid iterating keys()
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4350?vs=10719&id=10721
RE
apol added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:565
> QPoint posi; // will be overwritten with the event's position
> -if (m_dropPoints.keys().contains(tjob)) {
> -posi = m_dropPoints[tjob];
> +if (m_dropPoints.contains(tjob)) {
> +
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This a
broulik updated the summary for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4351
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreu
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R296 KDeclarative.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This avoids needless
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4351
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, ma
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4352
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: brouli
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:031bd773b7c2: [ContainmentInterface] Use setSize instead
of setWidth/setHeight in createApplet (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://p
broulik closed this revision.
broulik added a comment.
Committed as
https://cgit.kde.org/kdeclarative.git/commit/?id=2220a46702e670b5758892902797241d9b300bcf
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4351
EMAIL PREFERENCES
https://phabricator.kde.org/se
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129833/
---
(Updated Jan. 30, 2017, 11:08 p.m.)
Status
--
This change has been m
> On Jan. 29, 2017, 10:05 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't the tooltip be the parent of the widget anyway?
I'd say this is up for discussion, since the api is fairly new. Either we make
the tooltip take ownership and we warn about this (to avoid double delete
crashes), or we don't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129694/
---
(Updated Jan. 30, 2017, 11:26 p.m.)
Status
--
This change has been d
elvisangelaccio created this revision.
elvisangelaccio added reviewers: cfeck, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The new `lineedit_reveal_password` kiosk key cannot be queried from
kwidgetsaddons
elvisangelaccio updated the summary for this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D4355
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, cfeck, broulik
Cc: #frameworks
Now that Qt 5.8 is out, should we increase requirement to Qt 5.6 as the rules
say?
Cheers,
Albert
On Tue, Jan 31, 2017 at 12:59 AM, Albert Astals Cid wrote:
> Now that Qt 5.8 is out, should we increase requirement to Qt 5.6 as the rules
> say?
+1
Let's!
hein added a comment.
You have no idea how much I love you right now! This has annoyed me so long.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4351
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
C
cfeck created this revision.
cfeck set the repository for this revision to R289 KNotifications.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4357
AFFECTED
cfeck removed R289 KNotifications as the repository for this revision.
cfeck updated this revision to Diff 10750.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4357?vs=10749&id=10750
REVISION DETAIL
https://phabricator.kde.org/D4357
AFFECTED FILES
src/CMakeLists.txt
src/knotific
cfeck updated the summary for this revision.
cfeck updated the test plan for this revision.
cfeck added a reviewer: mck182.
cfeck set the repository for this revision to R289 KNotifications.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4357
EMAIL PREFERENCES
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/122/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 01:05:15 +
Build duration: 1 min 12 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/122/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 01:05:15 +
Build duration: 1 min 12 sec
CHANGE SET
No changes
JUNIT RESULTS
mpyne added a comment.
When reviewing this, please see also the review chain at
https://git.reviewboard.kde.org/r/127833/#review95717 , which had proposed
removing the then-needless KWallet includes.
In essence the sticking point we have currently is that fixing the Blowfish
implementat
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/180/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 02:07:56 +
Build duration: 14 min
CHANGE SET
No changes
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/143/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 31 Jan 2017 02:45:14 +
Build duration: 59 sec
CHANGE SET
No chan
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/181/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 03:12:45 +
Build duration: 1 min 58 sec
CHANGE SET
No changes
JUNIT RESULTS
Name
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/181/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 03:12:45 +
Build duration: 1 min 58 sec
CHANGE SET
No changes
JUNIT RESULTS
Name
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/145/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 31 Jan 2017 03:25:17 +
Build duration: 1 min 53 sec
CHANGE SET
No changes
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/145/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 31 Jan 2017 03:25:17 +
Build duration: 1 min 2 sec
CHANGE SET
No change
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kdoctools%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 03:59:29 +
Build duration: 23 sec
CHANGE SET
No changes
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdoctools%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/196/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 04:31:50 +
Build duration: 48 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (r
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdoctools%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/196/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 04:31:50 +
Build duration: 48 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (r
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/404/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 04:33:05 +
Build duration: 15 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root)
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/405/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 05:42:12 +
Build duration: 16 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) F
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/405/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 05:42:12 +
Build duration: 16 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) F
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/417/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 06:19:27 +
Build duration: 3 min 8 sec
CHANGE SET
No changes
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/418/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 06:23:38 +
Build duration: 4 min 42 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/418/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 Jan 2017 06:23:38 +
Build duration: 4 min 42 sec
CHANGE SET
No changes
JUNIT RESULTS
46 matches
Mail list logo
