Re: Review Request 129554: RFC: Add KNS support for KPackage

2016-12-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129554/#review101409 --- Ship it! while is true that just having an id is not a go

Re: Review Request 129643: DesktopFileParser: Honor ServiceTypes field

2016-12-13 Thread Aleix Pol Gonzalez
> On Dec. 13, 2016, 5:42 a.m., Michael Pyne wrote: > > src/lib/plugin/desktopfileparser.cpp, line 358 > > > > > > If returning false here is really a fatal error it might be worth using > > a `Q_UNLIKELY` in the

Re: Review Request 129643: DesktopFileParser: Honor ServiceTypes field

2016-12-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129643/ --- (Updated Dec. 13, 2016, 1:42 p.m.) Review request for KDE Frameworks. R

Re: Review Request 129554: RFC: Add KNS support for KPackage

2016-12-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129554/ --- (Updated Dec. 13, 2016, 1:10 p.m.) Status -- This change has been ma

Re: Review Request 129643: DesktopFileParser: Honor ServiceTypes field

2016-12-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129643/ --- (Updated Dec. 13, 2016, 2:20 p.m.) Status -- This change has been ma

Review Request 129648: New widget: tooltip that contains another widget

2016-12-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin

Re: Review Request 129587: Set parent for actions in DropJob's popup menu

2016-12-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129587/ --- (Updated Dec. 13, 2016, 7:35 p.m.) Status -- This change has been ma

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 156 - Fixed!

2016-12-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/156/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Dec 2016 22:28:45 + Build duration: 4 min 16 sec CHANGE SET Revision 8fb78cf50d8a774f92c185990c63ec

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 156 - Fixed!

2016-12-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/156/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Dec 2016 22:28:45 + Build duration: 4 min 16 sec CHANGE SET Revision 8fb78cf50d8a774f92c185990c63ec