Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-10-13 Thread Luigi Toscano
> On Ott. 13, 2016, 8:58 a.m., Anthony Fieroni wrote: > > src/karchive.h, line 292 > > > > > > First of all you must not provide const char interface and you must use > > i18n in all strings. > > Second, i d

Re: Review Request 129159: Major performance improvement when turning previews off in the file dialog.

2016-10-13 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129159/#review99971 --- Ship it! Looks OK to me. Nice improvement! - Mark Gaiser

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 216 - Still Failing!

2016-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/216/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 13 Oct 2016 08:20:08 + Build duration: 1 min 11 sec CHANGE SET Revision e

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 216 - Still Failing!

2016-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/216/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 13 Oct 2016 08:20:09 + Build duration: 4 min 31 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 216 - Still Failing!

2016-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/216/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 13 Oct 2016 08:20:09 + Build duration: 2 min 12 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 216 - Still Failing!

2016-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/216/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 13 Oct 2016 08:20:08 + Build duration: 2 min 13 sec CHANGE SET Revisi

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 234 - Fixed!

2016-10-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/234/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 11:13:01 + Build duration: 6 min 52 sec CHANGE SET Revision f26781054655021c1dbb597c76f3fdfe283d1257 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 234 - Fixed!

2016-10-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/234/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 11:13:01 + Build duration: 6 min 52 sec CHANGE SET Revision f26781054655021c1dbb597c76f3fdfe283d1257 b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 236 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/236/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 11:13:01 + Build duration: 13 min CHANGE SET Revision f26781054655021c1dbb597c76f3fdfe283d1257

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 342 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/342/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 11:26:46 + Build duration: 7 min 3 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 347 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/347/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 11:35:16 + Build duration: 8 min 6 sec CHANGE SET No changes JUNIT RESULTS

Review Request 129172: kioexec: use friendly names

2016-10-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129172/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-10-13 Thread Romário Rios
> On Oct. 13, 2016, 6:58 a.m., Anthony Fieroni wrote: > > > Second, i don't think library should provide strings to translate, it's an > application job. `QIODevice` provides an `errorString` method (although I don't know if it is translated) and I think other frameworks do so too, as well. I

Re: Review Request 129146: Fix emitting close when an event has no actions

2016-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/#review99980 --- Ship it! Makes sense to me, I'd add an assert as well, to

Re: Review Request 129146: Fix emitting close when an event has no actions

2016-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/ --- (Updated Oct. 13, 2016, 2:30 p.m.) Review request for KDE Frameworks. R

Review Request 129173: Fix logic bug if app is built with debug and autostart is disabled.

2016-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129173/ --- Review request for KDE Frameworks. Repository: kactivities Description

Re: Review Request 129172: kioexec: use friendly names

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129172/#review99983 --- Ship it! As an advanced user I liked the temp-looking file

Re: Review Request 129159: Major performance improvement when turning previews off in the file dialog.

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129159/ --- (Updated Oct. 13, 2016, 6:53 p.m.) Status -- This change has been ma

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 237 - Fixed!

2016-10-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/237/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 16:53:37 + Build duration: 9 min 52 sec CHANGE SET Revision 09cd8420e6c901a482c346fdaf4bc1cc385

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 237 - Fixed!

2016-10-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/237/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 16:53:37 + Build duration: 9 min 52 sec CHANGE SET Revision 09cd8420e6c901a482c346fdaf4bc1cc385

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/#review99985 --- I hope your commit log has a better description than "?" :-)

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 348 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/348/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 17:12:55 + Build duration: 8 min 8 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 343 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/343/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 17:09:00 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review99986 --- Fix it, then Ship it! I like this very much. qDebug or qWa

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread Albert Astals Cid
> On oct. 13, 2016, 5:16 p.m., David Faure wrote: > > I hope your commit log has a better description than "?" :-) The title should be good enough, the desciprtion was supposed to be two arrows pointing up, i guess something got messed up :D > On oct. 13, 2016, 5:16 p.m., David Faure wrote: >

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/#review99988 --- src/filewidgets/kfilewidget.cpp (line 1523)

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/ --- (Updated oct. 13, 2016, 5:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/#review99989 --- Fix it, then Ship it! Looks good to me! autotests/kfilew

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/ --- (Updated Oct. 13, 2016, 10:08 p.m.) Status -- This change has been m

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 238 - Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/238/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 22:08:26 + Build duration: 10 min CHANGE SET Revision 4108fd1b90630c9faaf38da34d4ed2c60d9ba657

Jenkins-kde-ci: kdewebkit master stable-kf5-qt5 » Linux,gcc - Build # 238 - Failure!

2016-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdewebkit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/238/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 22:27:20 + Build duration: 2 min 49 sec CHANGE SET No changes

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 344 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/344/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 22:24:55 + Build duration: 8 min 1 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 349 - Still Unstable!

2016-10-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/349/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Oct 2016 22:27:20 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-10-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Oct. 14, 2016, 4:29 a.m.) Review request for KDE Frameworks. C

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-10-13 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review6 --- autotests/karchivetest.cpp (line 353)