Re: Review Request 128555: [kio/kcms/kio/cache.ui] Fix MaxCacheSize limited to 99 KiB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128555/#review97923 --- Ship it! Yeah, that QSpinBox default max value is really a

Re: Review Request 128514: KIconLoader: reduce number of lookups when doing fallbacks

> On July 25, 2016, 11:58 a.m., Anthony Fieroni wrote: > > src/kiconloader.cpp, line 1041 > > > > > > This is not correct. When you have genericFallback && > > !currentName.empty() you never reach line 1071 to

Re: Review Request 128514: KIconLoader: reduce number of lookups when doing fallbacks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128514/ --- (Updated July 30, 2016, 2:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review97926 --- Nice! Can you add a testcase in autotests/fileundomanagertest