OSX/CI: qt5's QSslSocket can't resolve transfer methods

2014-12-11 Thread Marko Käning
Hi, on my OSX/CI system I realised that qtdiag reports that it cannot resolve certain transfer methods and wonder which system path hasn’t been set correctly here (see below). This e.g. doesn’t allow me to run Trojita on the console [1], but its tests at build time run flawlessly! Any ideas? Gr

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71784 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2014, 3:55 a.

Review Request 121446: Ignore child mtp devices

2014-12-11 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121446/ --- Review request for KDE Frameworks and Solid. Repository: solid Descript

Re: Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin wrote: > On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: >> On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson >> >> wrote: >> > You will probably get massively different behaviour regarding your env. >> > >> > pkexec won't copy anything, su

Re: Review Request 121446: Ignore child mtp devices

2014-12-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121446/#review71802 --- +1 makes sense to me, less of a workaround as it used to be.

Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2014-12-11 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Re: Re: pkexec vs kdesu

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 14:06:59 Harald Sitter wrote: > On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin wrote: > > On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: > >> On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson > >> > >> wrote: > >> > You will probably get massively differen

Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson wrote: > That said, polkit is totally the way forward and anything using kdesu should > be ported. I think the biggest concern is our custom desktop entry allowing *any* third party developer to leverage the power of kdesu and easily elevate their

Re: Re: Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Thu, Dec 11, 2014 at 2:29 PM, Martin Gräßlin wrote: > On Thursday 11 December 2014 14:06:59 Harald Sitter wrote: >> On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin wrote: >> > On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: >> >> On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson >> >>

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-12-11 Thread David Edmundson
I'm happy with it now. +1 from me. ​ David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2014-12-11 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/#review71804 --- Your current fix is probably working fine, but it's not a one

Re: Review Request 119607: Support for ".hidden" files

2014-12-11 Thread Bruno Nova
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Dez. 11, 2014, 3:23 p.m.) Review request for KDE Frameworks and

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 11, 2014, 4:40 nachm.) Review request for Extra Cmake Modul

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71815 --- modules/ECMAddAppIcon.cmake

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2014-12-11 Thread Emmanuel Pescosta
> On Dec. 11, 2014, 3:27 p.m., Mark Gaiser wrote: > > src/core/kfileitem.cpp, line 255 > > > > > > --> add here > > > > } else { > > // Fix for IO slaves that don't set UDS_MIME_TYPE for a folder

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- (Updated Dec. 11, 2014, 7:49 p.m.) Status -- This change has been ma

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread David Edmundson
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-12-11 Thread Frank Reininghaus
> On Dez. 11, 2014, 12:43 vorm., Milian Wolff wrote: > > src/core/udsentry.cpp, line 72 > > > > > > you are missing a reserve call here Yes, good catch! Note: I do realise that we could reserve space for only 7 o

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-12-11 Thread Frank Reininghaus
> On Dez. 10, 2014, 11:03 nachm., Milian Wolff wrote: > > src/core/udsentry.cpp, line 155 > > > > > > is this called often? if so, prefer to use a QList for the udsIndexes, > > to prevent the costly conversion h

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-12-11 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/ --- (Updated Dez. 11, 2014, 10:08 nachm.) Review request for KDE Frameworks a

OSX/CI: breeze fails on branch master

2014-12-11 Thread Marko Käning
Breeze suddenly fails to build here, as it now depends on X11, although the OSX/CI system globally sets -DCMAKE_DISABLE_FIND_PACKAGE_X11=ON It fails due to xcb: --- /Users/marko/WC/KDECI-builds/breeze/windec/kdecoration2/config/breezedetectwidget.h:43:10: fatal error: 'xcb/xcb.h' fil

Re: OSX/CI: breeze fails on branch master

2014-12-11 Thread Martin Gräßlin
On Friday 12 December 2014 01:28:09 Marko Käning wrote: > Breeze suddenly fails to build here, as it now depends on X11, although the > OSX/CI system globally sets > > -DCMAKE_DISABLE_FIND_PACKAGE_X11=ON > > It fails due to xcb: X11 and xcb are not the same. That sounds like an incomplete

Re: Re: OSX/CI: breeze fails on branch master

2014-12-11 Thread Martin Gräßlin
Martin GräßlinOn Friday 12 December 2014 08:02:52 wrote: > On Friday 12 December 2014 01:28:09 Marko Käning wrote: > > Breeze suddenly fails to build here, as it now depends on X11, although > > the > > OSX/CI system globally sets > > > > -DCMAKE_DISABLE_FIND_PACKAGE_X11=ON > > > > It fails

Re: OSX/CI: breeze fails on branch master

2014-12-11 Thread Marko Käning
Hi Martin, On 12 Dec 2014, at 08:02 , Martin Gräßlin wrote: > X11 and xcb are not the same. oh, I see. :) On 12 Dec 2014, at 08:12 , Martin Gräßlin wrote: > I hope this fixes it: > http://commits.kde.org/breeze/d35fb88cd9d9a678a170f01d9643c8956c38aee5 Yep, that did it. Thanks for taking ca