Build failed in Jenkins: kde-baseapps_frameworks_qt5 #200

2014-11-20 Thread KDE CI System
See Changes: [lbeltrame] Fix build after review 121078 -- [...truncated 1793 lines...] :67:

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70680 --- dolphin/src/CMakeLists.txt

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70681 --- Actually it's still broken: I didn't notice because I did not

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
> On Nov. 20, 2014, 9 a.m., Luca Beltrame wrote: > > Actually it's still broken: I didn't notice because I did not build tests: > > > > > > /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: > > error: expected initializer before ‘:’ token > > > > The l

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-20 Thread Martin Klapetek
> On Nov. 18, 2014, 12:33 a.m., Jeremy Whiting wrote: > > I tested this here and FileDialog qml still hangs the ui with this patch. > > (though at least the dialog appears) > > Martin Klapetek wrote: > Yes, QML still hangs, not sure why though. Looking into it. So I've spent a considerable

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-20 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/#review70686 --- Sorry to bother you David, but is this good to go, or would yo

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-20 Thread David Edmundson
> > > > > I'm not a fan of the propertiesChanged() method making it into the > > > > public > > > > API which we see in most classes, it's very much an implementation > > > > detail > > > > for QDBusAbstractInterface being rubbish. > > > > > Should we move it to private classes? > > I would. Or ma

Re: Review Request 121181: kcmshell: return -1 if module wasn't found

2014-11-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/#review70700 --- Ship it! Ship It! - Albert Astals Cid On nov. 19, 2014, 11

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-20 Thread Albert Astals Cid
> On nov. 17, 2014, 11:33 p.m., Jeremy Whiting wrote: > > I tested this here and FileDialog qml still hangs the ui with this patch. > > (though at least the dialog appears) > > Martin Klapetek wrote: > Yes, QML still hangs, not sure why though. Looking into it. > > Martin Klapetek wrote: >

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-20 Thread Jeremy Whiting
> On Nov. 17, 2014, 4:33 p.m., Jeremy Whiting wrote: > > I tested this here and FileDialog qml still hangs the ui with this patch. > > (though at least the dialog appears) > > Martin Klapetek wrote: > Yes, QML still hangs, not sure why though. Looking into it. > > Martin Klapetek wrote: >

Re: Review Request 121181: kcmshell: return -1 if module wasn't found

2014-11-20 Thread Teemu Rytilahti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/ --- (Updated Nov. 20, 2014, 6:51 p.m.) Status -- This change has been ma

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/#review70707 --- Well, I don't know anything about these APIs, but if it builds

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-20 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/#review70715 --- Ship it! Ship It! - Marko Käning On Nov. 4, 2014, 4:58 p.m