Review Request 119382: Port kio-mtp to KF5

2014-07-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/ --- Review request for KDE Frameworks and Philipp Schmidt. Repository: kio-mt

Re: Review Request 119382: Port kio-mtp to KF5

2014-07-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/ --- (Updated Čec. 21, 2014, 11:02 dop.) Review request for KDE Frameworks and

Re: Review Request 119382: Port kio-mtp to KF5

2014-07-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/ --- (Updated Čec. 21, 2014, 11:02 dop.) Review request for KDE Frameworks and

Re: Review Request 119382: Port kio-mtp to KF5

2014-07-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/#review62770 --- kio_mtp.cpp

Re: Review Request 119382: Port kio-mtp to KF5

2014-07-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/ --- (Updated Čec. 21, 2014, 11:54 dop.) Review request for KDE Frameworks and

Re: Review Request 119382: Port kio-mtp to KF5

2014-07-21 Thread Jan Grulich
> On Čec. 21, 2014, 11:42 dop., David Edmundson wrote: > > kio_mtp.cpp, line 268 > > > > > > why would there be a trailing slash on a filename? I'm quite confused > > as to the stripping slashes all over here.

Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- Review request for KDE Frameworks and Anne-Marie Mahfouf. Repository: kap

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/#review62803 --- templates/C++/kde-frameworks5-simple/CMakeLists.txt

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-21 Thread Jonathan Riddell
> On July 21, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: > > templates/C++/kde-frameworks5-simple/CMakeLists.txt, line 20 > > > > > > The application you're creating doesn't need XmlGui, I think it's fine > > if

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-21 Thread Jonathan Riddell
> On July 21, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > > > > > No need to do addHelpOption and addVersionOption, they're added by > > setupComm

Re: Review Request 119323: fix auth race condition

2014-07-21 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 21, 2014, 8:47 p.m.) Status -- This change has been ma