Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-15 Thread Martin Gräßlin
> On June 14, 2014, 11:36 a.m., Oswald Buddenhagen wrote: > > src/core/kconfigdata.h, line 68 > > > > > > i didn't bother to re-read the whole code, so maybe that's why i can't > > claim to understand how that is

Re: What to do regarding OPTIONAL packages during KDE/CI builds?

2014-06-15 Thread Marko Käning
Hi Albert, On 08 Jun 2014, at 20:47 , Albert Astals Cid wrote: >> ...but the build runs fine anyways. > Right, that's because they are optional :) I know. ;) > Actually all the combinations should be tested, I thought so. Well, I guess I won’t invest too much time in stg like this, since jenk

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- (Updated June 15, 2014, 4:13 p.m.) Review request for Build System, Extra

Review Request 118768: ECMAddTests: make NAME_PREFIX only apply to the test, not the target

2014-06-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118768/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-15 Thread Albert Astals Cid
> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-15 Thread Aleix Pol Gonzalez
> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118768: ECMAddTests: make NAME_PREFIX only apply to the test, not the target

2014-06-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118768/#review60146 --- Ship it! Thanks. Actually I wouldn't mind if KIO and KConfig

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:45 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:57 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:58 a.m.) Review request for KDE Frameworks, Pl