[kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initially tried to just wrap it in a "#ifndef KDE_NO_DEPRECATED" block, but it

Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

On Friday 08 November 2013 08:23:52 Aurélien Gâteau wrote: > Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. > Committed on 08/11/2013 at 08:23. > Pushed by gateau into branch 'frameworks'. > > Unbreak build > > Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initia

Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

On Fri, Nov 8, 2013 at 9:23 AM, Aurélien Gâteau wrote: > Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. > Committed on 08/11/2013 at 08:23. > Pushed by gateau into branch 'frameworks'. > > Unbreak build > > Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initially

Re: Review Request 113701: Fix KBookmarks standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/#review43248 --- Ship it! Ship It! - David Faure On Nov. 7, 2013, 10:38 a.m.

Re: Review Request 113686: Fix KParts standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43252 --- Ship it! Tested, it builds both independently and with the who

Re: Review Request 113695: Fix KDEWebKit standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/#review43253 --- Ship it! Tested, it builds and looks good. - Àlex Fiestas O

Re: Review Request 113693: Fix KNotifyConfig standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/#review43254 --- Ship it! I think this can go in once the comment is changed.

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

> On Nov. 8, 2013, 5:38 a.m., Martin Gräßlin wrote: > > tier2/knotifications/tests/CMakeLists.txt, line 22 > > > > > > do you need to link XLib? From the code changes you did it looks like > > you don't use any XL

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 8, 2013, 12:12 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113694: Fix KNewStuff standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/#review43256 --- Ship it! Looks good, builds standalone and with frameworks. -

Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

On Fri, 8 Nov 2013 09:59:37 +0100, Martin Klapetek wrote: On Fri, Nov 8, 2013 at 9:23 AM, Aurélien Gâteau wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing

Re: Review Request 113702: Fix KEmoticons standalone build

> On Nov. 7, 2013, 1:47 p.m., Aurélien Gâteau wrote: > > superbuild/CMakeLists.txt, line 34 > > > > > > kemoticons should be listed after kservice, otherwise superbuild won't > > pick up the standalone version of

Re: Review Request 113702: Fix KEmoticons standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43260 --- Ship it! Ship It! - Aurélien Gâteau On Nov. 7, 2013, 11:47

Re: Review Request 113701: Fix KBookmarks standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/ --- (Updated Nov. 8, 2013, 3:13 p.m.) Status -- This change has been mark

Re: Review Request 113701: Fix KBookmarks standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/#review43263 --- This review has been submitted with commit 015062773ed6afa9cc9

Re: Review Request 112896: Rework NETWM classes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Nov. 8, 2013, 4:14 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43271 --- Please use X11 stuff conditionally (Q_WS_X11). - Andrius da Co

Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113702: Fix KEmoticons standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43278 --- This review has been submitted with commit 62fb092823ca5c7ca38

Re: Review Request 113702: Fix KEmoticons standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 8, 2013, 7:41 p.m.) Status -- This change has been mark

Build failed in Jenkins: kdelibs_frameworks_qt5 #1621

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [kde

Re: Review Request 113703: Fix KRoss standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43280 --- This review has been submitted with commit 1bab5c4c483aed3e863

Re: Review Request 113703: Fix KRoss standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/ --- (Updated Nov. 8, 2013, 8:16 p.m.) Status -- This change has been mark

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1622

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

> On Nov. 8, 2013, 4:25 p.m., Andrius da Costa Ribas wrote: > > Please use X11 stuff conditionally (Q_WS_X11). There's no need to put conditionals in the file (since the whole thing is conditionally compiled), but the linking should be done conditionally. Specifically, you should take Qt5::X11

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- (Updated Nov. 8, 2013, 10:04 p.m.) Review request for KDE Frameworks. Ch

kdelibs/interfaces/khexedit

Hi Friedrich, I'm looking at interfaces/khexedit in kdelibs-frameworks, and wondering what to do with it. Are you still happy with it? Should we bring it into the KF5 world? If so, we need to find a place for it. It's only header files so it could be installed by any framework without any add

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43285 --- staging/kio/CMakeLists.txt

Question about kimproxy

Hi Will, I'm looking at interfaces/kimproxy in kdelibs, which has your copyright. http://lxr.kde.org/ident?i=KIMProxy says that it's now unused in all of KDE SC, the only user is playground/pim/leute/services/imaddress/ but an interface requires a provider and a user anyway, so surely this isn't

the kspeech interface

Hi Jeremy, I'm looking at kdelibs-frameworks/interface/kspeech, and trying to find a home for it, in the KF5 reorganization. I see that it's actually used in a number of places (http://lxr.kde.org/ident?i=soPlainText for instance). and that it's basically just a header file that depends only on

Re: the kspeech interface

I was actually wondering that myself the other day as I added to it in kdelibs master (that got branched into KDE/4.12) for a feature that hit jovie in KDE SC 4.12. It's used but really only needed to expose jovie's dbus interface for applications to use. Interestingly, knotify uses jovie but does

Re: the kspeech interface

Oops, that link was just users of soPlainText. It seems http://lxr.kde.org/ident?i=KSpeech the class itself is used in quite a few places, and is how any application uses speech capabilities. I guess kdbusaddons is as good a place as any for it and it will need to stay in kdelibs itself. On Fri,