[PATCH] Remove KDateTime limitation of 4712 BCE.

2012-10-08 Thread Jon Severinsson
QDate in Qt5 now supports dates before 4712 BCE (new limit is 12626108195557530 BCE, well outside the limit of a four digit year). --- This fixes test #12: kdecore-kdatetimetest when building on Qt5. I choose to just rip it out rather than to preserve behaviour for Qt4, as I figgured we could live

Re: [PATCH] Remove KDateTime limitation of 4712 BCE.

2012-10-08 Thread Mark
On Sun, Oct 7, 2012 at 10:30 PM, Jon Severinsson wrote: > QDate in Qt5 now supports dates before 4712 BCE (new limit is > 12626108195557530 BCE, well outside the limit of a four digit year). > --- > This fixes test #12: kdecore-kdatetimetest when building on Qt5. I choose to > just rip it out rat

Re: [PATCH] Remove KDateTime limitation of 4712 BCE.

2012-10-08 Thread David Faure
On Sunday 07 October 2012 22:30:28 Jon Severinsson wrote: > This fixes test #12: kdecore-kdatetimetest when building on Qt5. Thank you! Much appreciated. > I choose to > just rip it out rather than to preserve behaviour for Qt4, as I figgured we > could live with a bad return value from outOfRang

Re: [PATCH] Remove KDateTime limitation of 4712 BCE.

2012-10-08 Thread Jon Severinsson
måndagen den 8 oktober 2012 12:41:21 skrev du: > On Sunday 07 October 2012 22:30:28 Jon Severinsson wrote: > > This fixes test #12: kdecore-kdatetimetest when building on Qt5. > > Thank you! Much appreciated. > > > I choose to > > just rip it out rather than to preserve behaviour for Qt4, as I fi

Re: [PATCH] Remove KDateTime limitation of 4712 BCE.

2012-10-08 Thread David Faure
On Monday 08 October 2012 13:00:44 Jon Severinsson wrote: > måndagen den 8 oktober 2012 12:41:21 skrev du: > > On Sunday 07 October 2012 22:30:28 Jon Severinsson wrote: > > > This fixes test #12: kdecore-kdatetimetest when building on Qt5. > > > > Thank you! Much appreciated. > > > > > I choose to

[PATCH] Remove KDateTime limitation of 4712 BCE [v2].

2012-10-08 Thread Jon Severinsson
QDate in Qt5 now supports dates before 4712 BCE (new limit is 12626108195557530 BCE, well outside the limit of a four digit year). V2 updates: Fixes the unit test to be usefull instead of removing it, updated documentation. --- > Sure, remove the outOfRange check, but QVERIFY(dt.isValid()) or