Re: Re: XCB vs. KModifierKeyInfoProvider

2013-09-03 Thread Martin Gräßlin
On Tuesday 03 September 2013 13:05:05 David Faure wrote: > On Monday 02 September 2013 15:01:13 Martin Graesslin wrote: > > P.S.: looking at lxr it seems that there used to be a unit test. What > > happened to it? Was it just forgotten to be moved? > > What do you mean? > > I can only find kdeui/

Re: XCB vs. KModifierKeyInfoProvider

2013-09-03 Thread David Faure
On Monday 02 September 2013 15:01:13 Martin Graesslin wrote: > P.S.: looking at lxr it seems that there used to be a unit test. What > happened to it? Was it just forgotten to be moved? What do you mean? I can only find kdeui/tests/kmodifierkeyinfotest.cpp in KDE4 which became staging/kguiaddons

Re: XCB vs. KModifierKeyInfoProvider

2013-09-02 Thread Martin Graesslin
On Monday 02 September 2013 10:39:53 you wrote: > On Monday 02 September 2013 09:05:27 Martin Gräßlin wrote: > > 3) I just don't like it and would feel very uncomfortable given that we > > don't have unit tests and that this could break in future if xkb.h > > becomes > > available. > > Why not de

Re: XCB vs. KModifierKeyInfoProvider

2013-09-02 Thread David Faure
On Monday 02 September 2013 09:05:27 Martin Gräßlin wrote: > 3) I just don't like it and would feel very uncomfortable given that we > don't have unit tests and that this could break in future if xkb.h becomes > available. Why not declare the struct but with a different name? Then it can't clash

XCB vs. KModifierKeyInfoProvider

2013-09-02 Thread Martin Gräßlin
Hi all, I just started porting KModifierKeyInfoProvider to a QAbstractNativeEventFilter and hit a problem. The existing x11Event filter looks for X11 XkbEvent. Now in Qt 5 we would have to look for the matching event in XCB. But that doesn't exist. There seems to be an XKB extension for XCB wh