Re: Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Kevin Krammer
On Monday, 2013-08-05, Aurélien Gâteau wrote: > I pushed a first version of the patch here: > > https://codereview.qt-project.org/#change,62119 > > But people are not really sold to the idea so far. > > I am afraid adding this default syntax highlighter is not going to be > enough to get proper

Re: Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Kevin Krammer
On Monday, 2013-08-05, Kevin Ottens wrote: > On Monday 05 August 2013 11:54:15 Aleix Pol wrote: > > On Mon, Aug 5, 2013 at 11:02 AM, Kevin Krammer wrote: > > > On Thursday, 2013-08-01, Aurélien Gâteau wrote: > > > > Should work, but extending the QPlatformIntegration class for such a > > > > featu

Re: Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Aurélien Gâteau
Le lundi 5 août 2013 11:02:32 Kevin Krammer a écrit : > On Thursday, 2013-08-01, Aurélien Gâteau wrote: > > Should work, but extending the QPlatformIntegration class for such a > > feature feels a bit overkill to me. Is there a simpler alternative? > > If at all then QPlatformIntegration is probabl

Re: Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Kevin Ottens
On Monday 05 August 2013 11:54:15 Aleix Pol wrote: > On Mon, Aug 5, 2013 at 11:02 AM, Kevin Krammer wrote: > > On Thursday, 2013-08-01, Aurélien Gâteau wrote: > > > Should work, but extending the QPlatformIntegration class for such a > > > feature feels a bit overkill to me. Is there a simpler alt

Re: Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Aleix Pol
On Mon, Aug 5, 2013 at 11:02 AM, Kevin Krammer wrote: > On Thursday, 2013-08-01, Aurélien Gâteau wrote: > > > Should work, but extending the QPlatformIntegration class for such a > > feature feels a bit overkill to me. Is there a simpler alternative? > > If at all then QPlatformIntegration is pro

Re: Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Kevin Krammer
On Thursday, 2013-08-01, Aurélien Gâteau wrote: > Should work, but extending the QPlatformIntegration class for such a > feature feels a bit overkill to me. Is there a simpler alternative? If at all then QPlatformIntegration is probably the wrong place, more like QPlatformTheme (which handles th

Thoughts on the "default syntax highlighter for QTextEdit" task

2013-08-05 Thread Aurélien Gâteau
Hi, I assigned myself to this Qt5-epic task: > Allow to register a default syntax highlighter type for QTextEdit, the KDE > backend would register the spell checking one coming from sonnet as default After some investigations, it turns out the highlighter is set by QTextEdit on the QTextDocume