Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
On pondělí 3. dubna 2017 15:04:54 CEST Hartmut Goebel wrote: > Am 03.04.2017 um 14:16 schrieb Jan Grulich: > > Pushed two fixes into master branch, hopefully they fix all issues with > > the > > failing unit test. > > Applying both patches make the tests pass. Thanks for the fix. Awesome, I'm gla

Re: Test failures with networkmanager-qt

2017-04-03 Thread Hartmut Goebel
Am 03.04.2017 um 14:16 schrieb Jan Grulich: > Pushed two fixes into master branch, hopefully they fix all issues with the > failing unit test. Applying both patches make the tests pass. Thanks for the fix. -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com

Re: Test failures with networkmanager-qt

2017-04-03 Thread Hartmut Goebel
Hi Jan, > could you please try attached patch? For me it was working even without the > patch, but I think I spotted a potential problem and this hopefully will fix > it. Thanks for the patch, unfortunately it did not solve the problem. I'll send you the log-output via personal mail to avoid cl

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
Pushed two fixes into master branch, hopefully they fix all issues with the failing unit test. Jan On pondělí 3. dubna 2017 13:28:06 CEST David Faure wrote: > On lundi 3 avril 2017 12:57:11 CEST Jan Grulich wrote: > > Hi, > > > > could you please try attached patch? For me it was working even w

Re: Test failures with networkmanager-qt

2017-04-03 Thread David Faure
On lundi 3 avril 2017 12:57:11 CEST Jan Grulich wrote: > Hi, > > could you please try attached patch? For me it was working even without the > patch, but I think I spotted a potential problem and this hopefully will fix > it. This isn't happening on my own system but on a CI server I don't contro

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
Hi, could you please try attached patch? For me it was working even without the patch, but I think I spotted a potential problem and this hopefully will fix it. Regards, Jan On sobota 1. dubna 2017 21:54:04 CEST David Faure wrote: > On mardi 28 mars 2017 08:10:15 CEST Jan Grulich wrote: > > Hi

Re: Test failures with networkmanager-qt

2017-04-01 Thread David Faure
On mardi 28 mars 2017 08:10:15 CEST Jan Grulich wrote: > Hi, > > I can't think of any reason why the test fails for you. Looking to the git > log the only relevant change is fixed uninitialized state variable in > ActiveConnection, which may affect ActiveConnection::stateChanged() signal. This ha

Re: Test failures with networkmanager-qt

2017-03-28 Thread Jan Grulich
Hi, I didn't say you shouldn't investigate the cause. Could you please run the test with "-v2 -vs" parameters? Jan On úterý 28. března 2017 11:43:06 CEST Hartmut Goebel wrote: > Am 28.03.2017 um 08:10 schrieb Jan Grulich: > > I can't think of any reason why the test fails for you. Looking to t

Re: Test failures with networkmanager-qt

2017-03-28 Thread Hartmut Goebel
Am 28.03.2017 um 11:43 schrieb Hartmut Goebel: > Which versions are you referring to in "the only relevant change". Guix > is currently lacking behind and still has 5.28, which we updated from > 5.27 (which passed tests). Update: The error occurs even with 5.32. -- Regards Hartmut Goebel | Hart

Re: Test failures with networkmanager-qt

2017-03-28 Thread Hartmut Goebel
Am 28.03.2017 um 08:10 schrieb Jan Grulich: > I can't think of any reason why the test fails for you. Looking to the git > log > the only relevant change is fixed uninitialized state variable in > ActiveConnection, which may affect ActiveConnection::stateChanged() signal. So you suggest to not

Re: Test failures with networkmanager-qt

2017-03-27 Thread Jan Grulich
Hi, I can't think of any reason why the test fails for you. Looking to the git log the only relevant change is fixed uninitialized state variable in ActiveConnection, which may affect ActiveConnection::stateChanged() signal. Regards, Jan On pondělí 27. března 2017 18:02:05 CEST Hartmut Goebel

Test failures with networkmanager-qt

2017-03-27 Thread Hartmut Goebel
Hi, I try building networkmanager-qt for GNU Guix [1]. Gnu Guix build all software within a container, which does not have any network interface. networkmanager-qt build fine, but one test (ActiveConnectionTest) fails with activeConnectionStateChangedSpy.count()) being 0 instead of 1. There are a