Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- (Updated Aug. 15, 2016, 1:56 p.m.) Status -- This change has been ma

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98393 --- Ship it! Ship It! - David Faure On Aug. 14, 2016, 11:49

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- (Updated Aug. 14, 2016, 11:49 a.m.) Review request for KDE Frameworks and

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98382 --- Well, unittests in kio_desktop would certainly be a good idea

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- (Updated Aug. 14, 2016, 11:32 a.m.) Review request for KDE Frameworks and

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98379 --- Looks great. Two minor fixes and it's good to go. I just pus

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- (Updated Aug. 13, 2016, 5:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 12, 2016, 9:37 a.m., David Faure wrote: > > I don't feel confident about this change, for lack of unit tests. > > > > Please add unittests near kio_desktop (not in kio, which can't use > > kio_desktop). > > You can use my (new) tests in kio's jobtest.cpp as starting point: > > voi

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 12, 2016, 9:37 a.m., David Faure wrote: > > I don't feel confident about this change, for lack of unit tests. > > > > Please add unittests near kio_desktop (not in kio, which can't use > > kio_desktop). > > You can use my (new) tests in kio's jobtest.cpp as starting point: > > voi

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 12, 2016, 9:37 a.m., David Faure wrote: > > I don't feel confident about this change, for lack of unit tests. > > > > Please add unittests near kio_desktop (not in kio, which can't use > > kio_desktop). > > You can use my (new) tests in kio's jobtest.cpp as starting point: > > voi

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 12, 2016, 9:37 a.m., David Faure wrote: > > I don't feel confident about this change, for lack of unit tests. > > > > Please add unittests near kio_desktop (not in kio, which can't use > > kio_desktop). > > You can use my (new) tests in kio's jobtest.cpp as starting point: > > voi

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98236 --- I don't feel confident about this change, for lack of unit te

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- (Updated Aug. 9, 2016, 3:20 p.m.) Review request for KDE Frameworks and D

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

> On Aug. 6, 2016, 12:13 p.m., David Faure wrote: > > src/core/copyjob.cpp, line 1531 > > > > > > CopyJob stats the destination already, no need to do it again. > > > > See line 410, the local path for

Re: Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98157 --- src/core/copyjob.cpp (line 1531)

Review Request 128618: Fix creating symlink in Folder View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc