Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97600 --- This seems to break when used with Qt4. https://build.kde.org

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/ --- (Updated July 18, 2016, 1:08 p.m.) Status -- This change has been ma

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97471 --- Ship it! Ship It! - David Faure On July 12, 2016, 12:21

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-11 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97303 --- Works here, thanks - Antonio Rojas On Jul. 12, 2016, 12:21

Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/ --- Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas.