Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/ --- (Updated May 19, 2016, 9:19 p.m.) Status -- This change has been mar

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-19 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/#review95627 --- Fix it, then Ship it! Excellent, thanks! Just one comment

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/ --- (Updated May 19, 2016, 8:17 p.m.) Review request for KDE Frameworks and M

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-17 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/#review95559 --- +1 from me. Before pushing, can you please add a unit test f

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-17 Thread Kai Uwe Broulik
> On Mai 17, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > +1 > > > > Dolphin probably uses KRun which uses KDesktopFile::isAuthorizedDesktopFile > > which does not check for X-KDE-AuthorizeAction > > David Edmundson wrote: > With the comment about Dolphin, I simply meant I had tested that

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-17 Thread David Edmundson
> On May 17, 2016, 8:12 p.m., Kai Uwe Broulik wrote: > > +1 > > > > Dolphin probably uses KRun which uses KDesktopFile::isAuthorizedDesktopFile > > which does not check for X-KDE-AuthorizeAction With the comment about Dolphin, I simply meant I had tested that I hadn't broken the normal case a

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/#review95556 --- +1 Dolphin probably uses KRun which uses KDesktopFile::isAut

Review Request 127948: Avoid skipping KAuthorized check

2016-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig