Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- (Updated April 28, 2016, 10:50 p.m.) Status -- This change has been

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94997 --- Ship it! Ship It! - Albert Astals Cid On April 28, 2016

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Milian Wolff
> On April 28, 2016, 9:22 a.m., Milian Wolff wrote: > > could you also have a look at it with heaptrack? it should instantly give > > you a total number of allocations after finish, which should already give > > us an indication whether this brings lots to the table. Your callgrind > > numbers

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Aleix Pol Gonzalez
> On April 28, 2016, 11:22 a.m., Milian Wolff wrote: > > could you also have a look at it with heaptrack? it should instantly give > > you a total number of allocations after finish, which should already give > > us an indication whether this brings lots to the table. Your callgrind > > number

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- (Updated April 28, 2016, 2:39 p.m.) Review request for KDE Frameworks and

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- (Updated April 28, 2016, 2:38 p.m.) Review request for KDE Frameworks and

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Aleix Pol Gonzalez
> On April 28, 2016, 11:22 a.m., Milian Wolff wrote: > > could you also have a look at it with heaptrack? it should instantly give > > you a total number of allocations after finish, which should already give > > us an indication whether this brings lots to the table. Your callgrind > > number

Re: Review Request 127763: Reduce memory usage footprint

2016-04-28 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94948 --- could you also have a look at it with heaptrack? it should in

Re: Review Request 127763: Reduce memory usage footprint

2016-04-27 Thread Kai Uwe Broulik
> On April 27, 2016, 2:37 nachm., Kai Uwe Broulik wrote: > > src/kicontheme.cpp, line 697 > > > > > > While at it you could also cache end() and reserve() - Kai Uwe --

Re: Review Request 127763: Reduce memory usage footprint

2016-04-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94907 --- src/kicontheme.cpp (line 696)

Review Request 127763: Reduce memory usage footprint

2016-04-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth