Re: Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-21 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/ --- (Updated Dec. 21, 2015, 7:41 p.m.) Status -- This change has been ma

Re: Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-21 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/#review89808 --- Ship it! Ship It! - Alex Richardson On Dec. 18, 2015, 3:44

Re: Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-20 Thread Michael Pyne
> On Dec. 18, 2015, 3:17 a.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 346 > > > > > > `defs << *def // This must...` instead? And then the `defs << *def` in > > the else block? Wou

Re: Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-17 Thread Michael Pyne
> On Dec. 18, 2015, 3:17 a.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 346 > > > > > > `defs << *def // This must...` instead? And then the `defs << *def` in > > the else block? Wou

Re: Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-17 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/ --- (Updated Dec. 18, 2015, 3:44 a.m.) Review request for KDE Frameworks and

Re: Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-17 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/#review89679 --- src/lib/plugin/desktopfileparser.cpp (line 346)

Review Request 126409: Fix use-after-free in .desktop file parser

2015-12-17 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/ --- Review request for KDE Frameworks and Alex Richardson. Repository: kcorea