Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/ --- (Updated Dec. 15, 2015, 4:14 p.m.) Status -- This change has been ma

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/#review89555 --- Ship it! If you have time, a minimal unit test would be nice

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/ --- (Updated Dec. 15, 2015, 4:27 p.m.) Review request for KDE Frameworks. C

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/#review89553 --- An autotest would be nice, and I think the ASSERT is too aggre

Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description