Re: Review Request 126285: OS X build and warning fix

2016-10-20 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated Oct. 20, 2016, 11:35 a.m.) Status -- This change has been m

Re: Review Request 126285: OS X build and warning fix

2016-05-10 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated May 10, 2016, 10:06 p.m.) Review request for KDE Software on Mac

Re: Review Request 126285: OS X build and warning fix

2016-05-10 Thread Samuel Gaist
> On May 4, 2016, 4:16 p.m., Ivan Čukić wrote: > > Looks good to me - though I can not comment on the OSX API. I must have missed something when generating the patch, the OS X API changes comes from f223ce03d4b94ffbb093fc8be5adf8d968f54434 - Samuel --

Re: Review Request 126285: OS X build and warning fix

2016-05-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/#review95174 --- Ship it! Looks good to me - though I can not comment on th

Re: Review Request 126285: OS X build and warning fix

2015-12-08 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated Dec. 8, 2015, 8:48 p.m.) Review request for KDE Frameworks and I