Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/ --- (Updated Nov. 13, 2015, 2:24 p.m.) Status -- This change has been ma

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-13 Thread Martin Gräßlin
> On Nov. 13, 2015, 7:59 a.m., Martin Gräßlin wrote: > > shouldn't we just delete the code? Qt nowadays does SNI and if not we have > > the xembed-sni-proxy. Thoughts on that? Maybe bound to the Qt version which > > introduced the SNI support? > > David Edmundson wrote: > Could do. > I

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88327 --- Ship it! Ship It! - Martin Gräßlin On Nov. 12, 2015, 8:24

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-13 Thread David Edmundson
> On Nov. 13, 2015, 6:59 a.m., Martin Gräßlin wrote: > > shouldn't we just delete the code? Qt nowadays does SNI and if not we have > > the xembed-sni-proxy. Thoughts on that? Maybe bound to the Qt version which > > introduced the SNI support? Could do. I've not tried Qt's version of SNI mysel

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88310 --- shouldn't we just delete the code? Qt nowadays does SNI and if

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88306 --- +1 - Martin Klapetek On Nov. 12, 2015, 8:24 p.m., David Edm

Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: framewo