Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 16, 2015, 10:17 p.m.) Status -- This change has been

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/#review85463 --- Ship it! Ship It! - David Faure On Sept. 14, 2015, 10:31 a

Re: Review Request 125214: Add support for network shares in kio_trash

> On Sept. 14, 2015, 9:21 a.m., David Faure wrote: > > src/ioslaves/trash/trashimpl.cpp, line 838 > > > > > > strange default value, 1 would work just as well, wouldn't it? > > > > The first time we get

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 14, 2015, 12:31 p.m.) Review request for KDE Frameworks an

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/#review85347 --- Ship it! src/ioslaves/trash/trashimpl.h (line 25)

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 14, 2015, 12:19 a.m.) Review request for KDE Frameworks an

Re: Review Request 125214: Add support for network shares in kio_trash

> On Sept. 13, 2015, 8:48 p.m., David Faure wrote: > > Thanks for the patch! > > > > Protecting write access to a file is better done with QLockFile (which I > > added to Qt 5.0) than with a DBus based mechanism. > > > > (btw I just noticed that KInterProcessLock is now unused in kio_trash, we

Re: Review Request 125214: Add support for network shares in kio_trash

> On Sept. 13, 2015, 10:48 p.m., David Faure wrote: > > Thanks for the patch! > > > > Protecting write access to a file is better done with QLockFile (which I > > added to Qt 5.0) than with a DBus based mechanism. > > > > (btw I just noticed that KInterProcessLock is now unused in kio_trash, w

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/#review85328 --- Thanks for the patch! Protecting write access to a file is be

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 13, 2015, 9:59 p.m.) Review request for KDE Frameworks and

Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- Review request for KDE Frameworks and David Faure. Bugs: 177023 https