Re: Review Request 125106: Minor optimizations

> On Sept. 8, 2015, 4:46 p.m., Milian Wolff wrote: > > src/kconf_update/kconf_update.cpp, line 250 > > > > > > QLatin1String > > Albert Astals Cid wrote: > Seems like a bug in clazy, sometimes it knows that

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/ --- (Updated Oct. 5, 2015, 1:16 p.m.) Status -- This change has been mar

Re: Review Request 125106: Minor optimizations

> On Oct. 3, 2015, 12:28 a.m., Matthew Dawson wrote: > > src/core/kdesktopfile.cpp, line 307 > > > > > > Since this gets converted to a QString immediately, should this not be > > a QStringLiteral? There doesn'

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review86288 --- Ship it! Ship It! - Milian Wolff On Sept. 11, 2015, 11:56

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review86264 --- Sorry, +1 from me generally, but one question about QLatin1Str

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review86262 --- Any comment for/against this? - Albert Astals Cid On set. 1

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/ --- (Updated set. 11, 2015, 11:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 125106: Minor optimizations

> On set. 8, 2015, 4:46 p.m., Milian Wolff wrote: > > src/kconf_update/kconf_update.cpp, line 523 > > > > > > QLatin1String This was already a QLatin1String :D > On set. 8, 2015, 4:46 p.m., Milian Wolff wrote:

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review85019 --- in general +1, but I think some occassions should use QLatin1S

Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig