Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 495-496 > > > > > > This part looks wrong to me and I think is the reason why reading icons > > fails in kwin_wayland now. >

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 495-496 > > > > > > This part looks wrong to me and I think is the reason why reading icons > > fails in kwin_wayland now. >

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 7:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, line 588 > > > > > > This looks wrong to me! This method is supposed to return the actual > > work area as set on X11, not somethin

Re: Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review94357 --- Sorry that I didn't notice this review earlier. But the appro

Re: Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/ --- (Updated Aug. 7, 2015, 9:47 p.m.) Status -- This change has been mar

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On Aug. 7, 2015, 2:13 p.m., Aleix Pol Gonzalez wrote: > > src/kwindowsystem.cpp, line 34 > > > > > > Make static, at least it won't expose this to the linker. > > > > Some documentation wouldn't hurt.

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On Aug. 7, 2015, 4:54 p.m., Aleix Pol Gonzalez wrote: > > src/kwindowsystem.cpp, line 34 > > > > > > I insist. agree on the inststing :p - Marco --- T

Re: Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review83535 --- Ship it! src/kwindowsystem.cpp (line 34)

Re: Review Request 124648: Handle clients having a different device pixel ratio

On Aug. 7, 2015, 2:13 p.m., David Edmundson wrote: > > I'm unsure how good it is though, I would expect to be getting proper > > coordinates already. Will this break on wayland maybe? >I would expect to be getting proper coordinates already. How? >Will this break on wayland maybe? No. - Da

Re: Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review83533 --- src/kwindowsystem.cpp (line 34)

Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio