Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/ --- (Updated July 4, 2015, 10:32 a.m.) Status -- This change has been ma

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review82011 --- Ship it! Ship It! - Kai Uwe Broulik On Juni 7, 2015, 7:30

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/ --- (Updated June 7, 2015, 7:30 a.m.) Review request for KDE Frameworks. Re

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review81262 --- src/qmlcontrols/kquickcontrols/ColorButton.qml (lines 94 - 95

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/ --- (Updated June 6, 2015, 10:23 a.m.) Review request for KDE Frameworks. R

Re: Review Request 124014: Add QQC clone of KColorButton

> On June 5, 2015, 3:44 p.m., Marco Martin wrote: > > for qstyle based stuff we are depending on the qt devicepixelratio var, > > right? For all QQC stuff, yes. > On June 5, 2015, 3:44 p.m., Marco Martin wrote: > > src/qmlcontrols/kquickcontrols/ColorButton.qml, line 40 > >

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review81233 --- for qstyle based stuff we are depending on the qt devicepixelr

Re: Review Request 124014: Add QQC clone of KColorButton

> On June 5, 2015, 11:12 a.m., Kai Uwe Broulik wrote: > > src/qmlcontrols/kquickcontrols/ColorButton.qml, line 54 > > > > > > You probably want to add an alias for the showAlphaChannel, title, and > > currentColo

Re: Review Request 124014: Add QQC clone of KColorButton

> On June 5, 2015, 11:12 a.m., Kai Uwe Broulik wrote: > > src/qmlcontrols/kquickcontrols/ColorButton.qml, line 54 > > > > > > You probably want to add an alias for the showAlphaChannel, title, and > > currentColo

Re: Review Request 124014: Add QQC clone of KColorButton

> On June 5, 2015, 11:12 a.m., Kai Uwe Broulik wrote: > > LGTM > > > > Thanks! It's also used by the wallpaper config. I guess the IconButton used > > by Kickoff and folderview could also be moved to KQC >I guess the IconButton used by Kickoff and folderview could also be moved to >KQC Yes p

Re: Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review81225 --- LGTM Thanks! It's also used by the wallpaper config. I guess

Review Request 124014: Add QQC clone of KColorButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative