Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/ --- (Updated April 20, 2015, 5:10 p.m.) Status -- This change has been m

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79260 --- Ship it! Ship It! - Alex Richardson On April 17, 2015, 3:5

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

> On April 17, 2015, 5:06 p.m., Alex Richardson wrote: > > KF5CoreAddonsMacros.cmake, line 108 > > > > > > I would also grep for Q_PLUGIN_METADATA(IID ... FILE foo.json). > > Also maybe make the macro name cu

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79131 --- KF5CoreAddonsMacros.cmake (line 108)

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/ --- (Updated April 17, 2015, 4:53 p.m.) Review request for KDE Frameworks and

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79123 --- does this error out properly when the install namespace is emp

Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/ --- Review request for KDE Frameworks and Alex Richardson. Repository: kcorea